Unable to fetch older version artifact metadata using search api

[suryaprabhakark]

Description

Registry
Version: 2.4.1 & 2.4.2
Persistence type: sql[postgresql]

Environment

Kubernetes deployement and using rest apis.

Steps to Reproduce

1. Create an artifact A in a group G which will assign a globalId X
2. Update the artifact A which increments the globalId by 1 X+1
3. Try to fetch the metadata of the artifact by globalId X+1 as expected
4. When I try to fetch metadata of the artifact by previous version globalId X then the response is empty.

Problem: Unable to fetch metadata of older versions using search api.

Expected vs Actual Behaviour

Works

curl -X GET http://localhost:8080/apis/registry/v2/search/artifacts\?globalId\=X+1

Not Working

curl -X GET http://localhost:8080/apis/registry/v2/search/artifacts\?globalId\=X

Metadata fetch always works for latest version but not for older version.

Logs

No error logs found

[suryaprabhakark]

I suspect the following code is causing this issue, can someone please let us know if its intentional. If the join with latest version is removed, then it works as expected.

https://github.com/Apicurio/apicurio-registry/blob/main/app/src/main/java/io/apicurio/registry/storage/impl/sql/AbstractSqlRegistryStorage.java#L1245
https://github.com/Apicurio/apicurio-registry/blob/main/app/src/main/java/io/apicurio/registry/storage/impl/sql/AbstractSqlRegistryStorage.java#L1390

[EricWittmann]

The behavior of the server is intentional, but perhaps we should reconsider. Any thoughts on this @Apicurio/developers ?

[suryaprabhakark]

@andreaTP Any chance to pick this up, happy to contribute if its open for modification.

[suryaprabhakark]

I made the following changes in my fork for this problem. We are using it in production, its working as expected.

https://github.com/suryaprabhakark/apicurio-registry/pull/1/files

[carlesarnal]

I don't have any particular opinion against this but, as Eric said, this is intentional, so not a bug. That said, if you have good arguments for it, we're more than happy to discuss it.

[EricWittmann]

So looking at the PR you linked, it's interesting. It specifically allows searching for an artifact by globalId across versions of an artifact. That makes sense for sure and gets around the reason we weren't joining the versions table before, which is that the result would be duplicate rows for the same artifact. But in this case, you only do the join when searching for globalId, which means you're going to be limited to a single row at most.

I'd be open to such a contribution for sure. WDYT @carlesarnal ?

[suryaprabhakark]

@EricWittmann I had implemented the same, Im joining only when searching with globalId, I can raise the PR to main repo if you and @carlesarnal are fine with the changes in below PR

https://github.com/suryaprabhakark/apicurio-registry/pull/1/files

[suryaprabhakark]

@EricWittmann @carlesarnal Any thoughts on the above comment?

[EricWittmann]

I think I'm OK with the changes! Please open the PR and we can discuss it there to give others a chance to dissent.

Thanks!!