Skip to content

[Bug] Compilation error with React Native 0.79.x - StyleLength unit() method not found #731

Description

@biostome

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-safe-area-context@4.14.1 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-safe-area-context/common/cpp/react/renderer/components/safeareacontext/RNCSafeAreaViewShadowNode.cpp b/node_modules/react-native-safe-area-context/common/cpp/react/renderer/components/safeareacontext/RNCSafeAreaViewShadowNode.cpp
index 6d94c52..0fe05e5 100644
--- a/node_modules/react-native-safe-area-context/common/cpp/react/renderer/components/safeareacontext/RNCSafeAreaViewShadowNode.cpp
+++ b/node_modules/react-native-safe-area-context/common/cpp/react/renderer/components/safeareacontext/RNCSafeAreaViewShadowNode.cpp
@@ -16,10 +16,10 @@ inline Style::Length valueFromEdges(
     Style::Length edge,
     Style::Length axis,
     Style::Length defaultValue) {
-  if (edge.unit() != Unit::Undefined) {
+  if (!edge.isUndefined()) {
     return edge;
   }
-  if (axis.unit() != Unit::Undefined) {
+  if (!axis.isUndefined()) {
     return axis;
   }
   return defaultValue;

This issue body was partially generated by patch-package.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions