Fix straight cable rendering

Author: shartte

src/client/java/appeng/client/api/model/parts/PartModel.java

@@ -33,6 +33,14 @@ void collectParts(BlockAndTintGetter level,
 
     Material.Baked particleMaterial();
 
+    /**
+     * @return True if the model supports attaching to a straight cable without forcing it to show as a connecting
+     *         junction.
+     */
+    default boolean canAttachToStraightCable() {
+        return false;
+    }
+
     /**
      * An unbaked {@link PartModel} which is what is deserialized from the JSON file and ultimately used to produce a
      * {@link PartModel} and its dependencies.

src/client/java/appeng/client/model/CableAnchorPartModel.java

@@ -47,6 +47,11 @@ public Material.Baked particleMaterial() {
         return model.particleMaterial();
     }
 
+    @Override
+    public boolean canAttachToStraightCable() {
+        return true;
+    }
+
     public record Unbaked(Identifier model, Identifier shortModel) implements PartModel.Unbaked {
         public static final Identifier ID = AppEng.makeId("cable_anchor");
         public static final MapCodec<Unbaked> MAP_CODEC = RecordCodecBuilder.mapCodec(builder -> builder.group(

src/client/java/appeng/client/render/cablebus/CableBusModel.java

@@ -227,11 +227,7 @@ private void getCableQuads(CableBusRenderState renderState, Consumer<BakedQuad>
         // If the connection is straight, no busses are attached, and no covered core
         // has been forced (in case of glass
         // cables), then render the cable as a simplified straight line.
-        boolean noAttachments = false; /*
-                                        * TODO !renderState.getAttachments().values().stream()
-                                        * .anyMatch(IPartModel::requireCableConnection);
-                                        */
-        if (noAttachments && isStraightLine(cableType, connectionTypes)) {
+        if (isStraightLine(cableType, connectionTypes) && canAllAttachmentsRenderOnStraightCable(renderState)) {
             Direction facing = connectionTypes.keySet().iterator().next();
 
             switch (cableType) {
@@ -320,6 +316,24 @@ private void getCableQuads(CableBusRenderState renderState, Consumer<BakedQuad>
         }
     }
 
+    /**
+     * {@return true if there aren't any attachments or all of them can render on a straight cable without requiring a
+     * cable connecting core}.
+     */
+    private boolean canAllAttachmentsRenderOnStraightCable(CableBusRenderState renderState) {
+        for (var partRenderState : renderState.getAttachments().values()) {
+            var modelsOnSide = partModels.get(partRenderState.partItem());
+            if (modelsOnSide != null) {
+                for (var modelOnSide : modelsOnSide) {
+                    if (!modelOnSide.canAttachToStraightCable()) {
+                        return false;
+                    }
+                }
+            }
+        }
+        return true;
+    }
+
     @Nullable
     private Material.Baked getCableParticleTexture(CableBusRenderState renderState) {
         CableCoreType coreType = CableCoreType.fromCableType(renderState.getCableType());