Fix unnecessary craftable checks for Emi in AE2 screens (#8540)

Author: shartte

gradle.properties

@@ -24,7 +24,7 @@ neoForge.parchment.mappingsVersion=2024.07.07
 guideme_version=21.1.1
 top_minecraft_release=1.20
 top_version=1.20.4_neo-11.0.1-2
-emi_version=1.1.19+1.21.1
+emi_version=1.1.22+1.21.1
 # please learn how to use semver...
 top_version_range=[1.20.0,)
 jade_version_range=[15.0.0,)

src/main/java/appeng/integration/modules/emi/EmiEncodePatternHandler.java

@@ -8,6 +8,7 @@
 import net.minecraft.world.item.crafting.RecipeHolder;
 
 import dev.emi.emi.api.recipe.EmiRecipe;
+import dev.emi.emi.api.recipe.handler.EmiCraftContext;
 
 import appeng.api.stacks.AEItemKey;
 import appeng.api.stacks.AEKey;
@@ -27,6 +28,17 @@ public EmiEncodePatternHandler(Class<T> containerClass) {
         super(containerClass);
     }
 
+    @Override
+    public boolean canCraft(EmiRecipe recipe, EmiCraftContext<T> context) {
+        if (context.getType() == EmiCraftContext.Type.FILL_BUTTON) {
+            return transferRecipe(recipe, context, false).canCraft();
+        } else {
+            // Do not unnecessarily check if a recipe can be crafted
+            // when we're only capable of encoding patterns
+            return false;
+        }
+    }
+
     @Override
     protected Result transferRecipe(T menu, RecipeHolder<?> holder, EmiRecipe emiRecipe, boolean doTransfer) {
 

src/main/java/appeng/integration/modules/emi/EmiUseCraftingRecipeHandler.java

@@ -15,6 +15,7 @@
 import net.minecraft.world.item.crafting.ShapedRecipePattern;
 
 import dev.emi.emi.api.recipe.EmiRecipe;
+import dev.emi.emi.api.recipe.VanillaEmiRecipeCategories;
 import dev.emi.emi.api.stack.EmiStack;
 
 import appeng.core.localization.ItemModText;
@@ -41,6 +42,12 @@ public EmiUseCraftingRecipeHandler(Class<T> containerClass) {
         super(containerClass);
     }
 
+    @Override
+    public boolean supportsRecipe(EmiRecipe recipe) {
+        // For actual crafting, we only support normal crafting recipes
+        return recipe.getCategory().equals(VanillaEmiRecipeCategories.CRAFTING);
+    }
+
     @Override
     protected Result transferRecipe(T menu, RecipeHolder<?> holder, EmiRecipe emiRecipe, boolean doTransfer) {