Add explicit block break/place permission checks to the matter cannon. (#8529)

Fixes #8496

Author: shartte

src/main/java/appeng/items/tools/powered/ColorApplicatorItem.java

@@ -93,7 +93,6 @@
 import appeng.items.tools.powered.powersink.AEBasePoweredItem;
 import appeng.me.cells.BasicCellHandler;
 import appeng.me.helpers.BaseActionSource;
-import appeng.me.helpers.PlayerSource;
 import appeng.util.ConfigInventory;
 import appeng.util.InteractionUtil;
 import appeng.util.Platform;
@@ -164,8 +163,6 @@ public InteractionResult useOn(UseOnContext context) {
 
         var color = this.getColor(is);
 
-        var source = new PlayerSource(p);
-
         var inv = StorageCells.getCellInventory(is, null);
         if (inv != null) {
             if (p != null && !Platform.hasPermissions(new DimensionalBlockPos(level, pos), p)) {

src/main/java/appeng/items/tools/powered/MatterCannonItem.java

@@ -54,6 +54,10 @@
 import net.minecraft.world.phys.Vec3;
 import net.neoforged.api.distmarker.Dist;
 import net.neoforged.api.distmarker.OnlyIn;
+import net.neoforged.neoforge.common.NeoForge;
+import net.neoforged.neoforge.common.util.BlockSnapshot;
+import net.neoforged.neoforge.event.EventHooks;
+import net.neoforged.neoforge.event.level.BlockEvent;
 
 import appeng.api.config.Actionable;
 import appeng.api.config.FuzzyMode;
@@ -263,6 +267,11 @@ private void shootPaintBalls(AEColor color, boolean lit, Level level, @Nullable
                     return;
                 }
 
+                if (EventHooks.onBlockPlace(p, BlockSnapshot.create(p.level().dimension(), level, hitPos),
+                        blockResult.getDirection())) {
+                    return;
+                }
+
                 final BlockState whatsThere = level.getBlockState(hitPos);
                 if (whatsThere.canBeReplaced() && level.isEmptyBlock(hitPos)) {
                     level.setBlock(hitPos, AEBlocks.PAINT.block().defaultBlockState(), 3);
@@ -340,10 +349,11 @@ private void standardAmmo(float penetration, Level level, Player p, Vec3 Vector3
                     final int dmg = getDamageFromPenetration(penetration);
                     if (entityHit instanceof LivingEntity el) {
                         penetration -= dmg;
-                        el.knockback(0, -direction.x, -direction.z);
-                        el.hurt(dmgSrc, dmg);
-                        if (!el.isAlive()) {
-                            hasDestroyed = true;
+                        if (el.hurt(dmgSrc, dmg)) {
+                            el.knockback(0, -direction.x, -direction.z);
+                            if (!el.isAlive()) {
+                                hasDestroyed = true;
+                            }
                         }
                     } else if (entityHit instanceof ItemEntity) {
                         hasDestroyed = true;
@@ -360,8 +370,7 @@ private void standardAmmo(float penetration, Level level, Player p, Vec3 Vector3
                         final BlockState bs = level.getBlockState(blockPos);
 
                         final float hardness = bs.getDestroySpeed(level, blockPos) * 9.0f;
-                        if (hardness >= 0.0 && penetration > hardness
-                                && Platform.hasPermissions(new DimensionalBlockPos(level, blockPos), p)) {
+                        if (hardness >= 0.0 && penetration > hardness && canDestroyBlock(level, blockPos, p)) {
                             hasDestroyed = true;
                             penetration -= hardness;
                             penetration *= 0.60F;
@@ -373,6 +382,16 @@ private void standardAmmo(float penetration, Level level, Player p, Vec3 Vector3
         }
     }
 
+    private boolean canDestroyBlock(Level level, BlockPos pos, Player player) {
+        if (!Platform.hasPermissions(new DimensionalBlockPos(level, pos), player)) {
+            return false;
+        }
+
+        var state = level.getBlockState(pos);
+        var event = new BlockEvent.BreakEvent(level, pos, state, player);
+        return !NeoForge.EVENT_BUS.post(event).isCanceled();
+    }
+
     public static int getDamageFromPenetration(float penetration) {
         return (int) Math.ceil(penetration / 20.0f);
     }