Skip to content

Commit d8ef623

Browse files
authored
E2E instructions update: improve layout, add more E2Es (#968)
1 parent 953da46 commit d8ef623

13 files changed

+2436
-18
lines changed

.github/copilot-instructions.md

Lines changed: 39 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2871,10 +2871,31 @@ The `result` property MUST use `{{{uuid}}}` pattern referencing `$.after-all.out
28712871
- Use AfterAll to ensure cleanup runs after all assertions
28722872
- Connect cleanup components properly
28732873
2874-
8. **Component Coordinates**
2875-
- Use x/y coordinates for visual layout
2876-
- Space components horizontally (200-300px apart)
2877-
- Arrange vertically for parallel branches (especially for multiple Assert components)
2874+
8. **Component Coordinates and Layout**
2875+
- **Horizontal spacing**: Use **192px** between sequentially connected components on the x-axis
2876+
- **Vertical spacing**: Use **128px** between parallel rows/branches on the y-axis
2877+
- **Starting position**: OnStart at `x: 64, y: 16`
2878+
- **Diagonal staircase pattern**: When operations branch off sequentially (Create → Get → Update → ...), each subsequent action moves **+192px right** and **+128px down**, forming a diagonal:
2879+
```
2880+
on-start (64,16) → set-variables (272,16) → create (464,16)
2881+
2882+
get (656,144)
2883+
2884+
update (848,272)
2885+
2886+
get-content (1040,400)
2887+
```
2888+
- **Assert column**: All Assert components are **right-aligned at a fixed x position** (e.g., `x: 1200`), each at the **same y as its corresponding action**:
2889+
```
2890+
create (464,16) → assert-create (1200,16)
2891+
get (656,144) → assert-get (1200,144)
2892+
update (848,272) → assert-update (1200,272)
2893+
get-content (1040,400) → assert-get-content (1200,400)
2894+
```
2895+
- **Tail chain (AfterAll → Cleanup → ProcessResults)**: Place on a **horizontal line** at approximately the vertical center of the flow (e.g., `y: 144`), spaced ~192px apart after the assert column:
2896+
```
2897+
after-all (1392,144) → delete (1616,144) → process-results (1792,144)
2898+
```
28782899
28792900
9. **Naming Conventions**
28802901
- Use descriptive component IDs: `create-document`, `assert-content-exists`
@@ -2890,16 +2911,16 @@ The `result` property MUST use `{{{uuid}}}` pattern referencing `$.after-all.out
28902911
"flow": {
28912912
"start": {
28922913
"type": "appmixer.utils.controls.OnStart",
2893-
"x": 100,
2894-
"y": 200,
2914+
"x": 64,
2915+
"y": 16,
28952916
"source": {},
28962917
"version": "1.0.0",
28972918
"config": {}
28982919
},
28992920
"create-item": {
29002921
"type": "appmixer.service.core.CreateItem",
2901-
"x": 300,
2902-
"y": 200,
2922+
"x": 256,
2923+
"y": 16,
29032924
"version": "1.0.0",
29042925
"source": {
29052926
"in": {
@@ -2926,8 +2947,8 @@ The `result` property MUST use `{{{uuid}}}` pattern referencing `$.after-all.out
29262947
},
29272948
"get-item": {
29282949
"type": "appmixer.service.core.GetItem",
2929-
"x": 500,
2930-
"y": 200,
2950+
"x": 448,
2951+
"y": 144,
29312952
"version": "1.0.0",
29322953
"source": {
29332954
"in": {
@@ -2959,8 +2980,8 @@ The `result` property MUST use `{{{uuid}}}` pattern referencing `$.after-all.out
29592980
},
29602981
"assert-item": {
29612982
"type": "appmixer.utils.test.Assert",
2962-
"x": 700,
2963-
"y": 200,
2983+
"x": 832,
2984+
"y": 144,
29642985
"version": "1.0.0",
29652986
"source": {
29662987
"in": {
@@ -3000,8 +3021,8 @@ The `result` property MUST use `{{{uuid}}}` pattern referencing `$.after-all.out
30003021
},
30013022
"after-all": {
30023023
"type": "appmixer.utils.test.AfterAll",
3003-
"x": 900,
3004-
"y": 200,
3024+
"x": 1024,
3025+
"y": 80,
30053026
"version": "1.0.0",
30063027
"source": {
30073028
"in": {
@@ -3016,8 +3037,8 @@ The `result` property MUST use `{{{uuid}}}` pattern referencing `$.after-all.out
30163037
},
30173038
"delete-item": {
30183039
"type": "appmixer.service.core.DeleteItem",
3019-
"x": 1100,
3020-
"y": 200,
3040+
"x": 1216,
3041+
"y": 80,
30213042
"version": "1.0.0",
30223043
"source": {
30233044
"in": {
@@ -3049,8 +3070,8 @@ The `result` property MUST use `{{{uuid}}}` pattern referencing `$.after-all.out
30493070
},
30503071
"process-results": {
30513072
"type": "appmixer.utils.test.ProcessE2EResults",
3052-
"x": 1300,
3053-
"y": 200,
3073+
"x": 1408,
3074+
"y": 80,
30543075
"version": "1.0.0",
30553076
"source": {
30563077
"in": {

src/appmixer/ragieai/artifacts/ai-artifacts/test-flows/test-flow-life-cycle.json renamed to src/appmixer/ragieai/artifacts/test-flows/test-flow-life-cycle.json

File renamed without changes.

0 commit comments

Comments
 (0)