Skip to content

Commit a77828a

Browse files
committed
Updated version to 6.4 + extended unit tests
1 parent 9d7214b commit a77828a

File tree

3 files changed

+24
-5
lines changed

3 files changed

+24
-5
lines changed

Archipelago.MultiClient.Net.Tests/PlayerInfoFixture.cs

+19
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using Archipelago.MultiClient.Net.Helpers;
22
using NUnit.Framework;
3+
using System;
34

45
namespace Archipelago.MultiClient.Net.Tests
56
{
@@ -50,5 +51,23 @@ public void Equality_should_check_slot_and_team()
5051
Assert.That(PlayerA, Is.Not.EqualTo(PlayerD));
5152
Assert.That((PlayerInfo)null, Is.EqualTo(null));
5253
}
54+
55+
[TestCase(null)]
56+
[TestCase(new int[0])]
57+
public void IsGroup_should_return_false_for_null_or_empty_group(int[] groupMembers)
58+
{
59+
var player = new PlayerInfo { GroupMembers = groupMembers };
60+
61+
Assert.IsFalse(player.IsGroup);
62+
}
63+
64+
[TestCase(new []{1, 2})]
65+
[TestCase(new[]{1})]
66+
public void IsGroup_should_return_true_when_group_members_are_set(int[] groupMembers)
67+
{
68+
var player = new PlayerInfo { GroupMembers = groupMembers };
69+
70+
Assert.IsTrue(player.IsGroup);
71+
}
5372
}
5473
}

Archipelago.MultiClient.Net/Archipelago.MultiClient.Net.csproj

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@
1010
<PackageReadmeFile>README.md</PackageReadmeFile>
1111
<RepositoryUrl>https://github.com/ArchipelagoMW/Archipelago.MultiClient.Net</RepositoryUrl>
1212
<RepositoryType>git</RepositoryType>
13-
<AssemblyVersion>6.3.1.0</AssemblyVersion>
14-
<FileVersion>6.3.1.0</FileVersion>
15-
<Version>6.3.1</Version>
13+
<AssemblyVersion>6.4.0.0</AssemblyVersion>
14+
<FileVersion>6.4.0.0</FileVersion>
15+
<Version>6.4.0</Version>
1616
<PackageLicenseExpression>MIT</PackageLicenseExpression>
1717
<PackageRequireLicenseAcceptance>False</PackageRequireLicenseAcceptance>
1818
<PackageIcon>blue-icon.png</PackageIcon>

Archipelago.MultiClient.Net/Helpers/PlayerHelper.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ public bool IsSharingGroupWith(int team, int slot) =>
285285
/// <returns>returns the players info's of members from a group slot, or null if this slot is not a group</returns>
286286
public IEnumerable<PlayerInfo> GetGroupMembers(IPlayerHelper playerHelper)
287287
{
288-
if (GroupMembers == null || GroupMembers.Length == 0)
288+
if (!IsGroup)
289289
return null;
290290

291291
return GroupMembers.Select(g => playerHelper.GetPlayerInfo(Team, g));
@@ -330,7 +330,7 @@ public bool IsRelatedTo(PlayerInfo other) => this == other
330330
public PlayerInfo() {}
331331

332332
/// <summary>
333-
/// Creates and PlayerInfo object, used by json deserialization
333+
/// Creates an PlayerInfo object, used by json deserialization
334334
/// </summary>
335335
/// <param name="team">The team of this player</param>
336336
/// <param name="slot">The slot of this player</param>

0 commit comments

Comments
 (0)