refactor(annotations): use single unique constraints for identifiers (#7342)

Author: axiomofjoy

packages/phoenix-client/src/phoenix/client/__generated__/v1/.dataclass.txt

@@ -86,13 +86,15 @@ async def _insert_trace_evaluation(
         explanation=explanation,
         metadata_={},  # `metadata_` must match ORM
         annotator_kind="LLM",
+        identifier="",
+        source="API",
     )
     await session.execute(
         insert_on_conflict(
             values,
             dialect=dialect,
             table=models.TraceAnnotation,
-            unique_by=("name", "trace_rowid"),
+            unique_by=("name", "trace_rowid", "identifier"),
         )
     )
     return TraceEvaluationInsertionEvent(project_rowid, evaluation_name)
@@ -128,13 +130,15 @@ async def _insert_span_evaluation(
         explanation=explanation,
         metadata_={},  # `metadata_` must match ORM
         annotator_kind="LLM",
+        identifier="",
+        source="API",
     )
     await session.execute(
         insert_on_conflict(
             values,
             dialect=dialect,
             table=models.SpanAnnotation,
-            unique_by=("name", "span_rowid"),
+            unique_by=("name", "span_rowid", "identifier"),
         )
     )
     return SpanEvaluationInsertionEvent(project_rowid, evaluation_name)
@@ -179,13 +183,21 @@ async def _insert_document_evaluation(
         explanation=explanation,
         metadata_={},  # `metadata_` must match ORM
         annotator_kind="LLM",
+        identifier="",
+        source="API",
     )
     await session.execute(
         insert_on_conflict(
             values,
             dialect=dialect,
             table=models.DocumentAnnotation,
-            unique_by=("name", "span_rowid", "document_position"),
+            unique_by=(
+                "name",
+                "span_rowid",
+                "document_position",
+                "identifier",
+            ),
+            constraint_name="uq_document_annotations_name_span_rowid_document_pos_identifier",  # The name of the unique constraint is specified manually since the auto-generated name is longer than the Postgres limit of 63 characters  # noqa: E501
         )
     )
     return DocumentEvaluationInsertionEvent(project_rowid, evaluation_name)

src/phoenix/db/insertion/evaluation.py

@@ -36,6 +36,7 @@ def insert_on_conflict(
     unique_by: Sequence[str],
     on_conflict: OnConflict = OnConflict.DO_UPDATE,
     set_: Optional[Mapping[str, Any]] = None,
+    constraint_name: Optional[str] = None,
 ) -> Insert:
     """
     Dialect specific insertion statement using ON CONFLICT DO syntax.
@@ -50,7 +51,7 @@ def insert_on_conflict(
             unique_records.append(v)
             seen.add(k)
         records = tuple(reversed(unique_records))
-    constraint = "_".join(("uq", table.__tablename__, *unique_by))
+    constraint = constraint_name or "_".join(("uq", table.__tablename__, *unique_by))
     if dialect is SupportedSQLDialect.POSTGRESQL:
         stmt_postgresql = insert_postgresql(table).values(records)
         if on_conflict is OnConflict.DO_NOTHING: