refactor: allow footer social link labels (#657)

Author: alexbarnsley

resources/views/footer.blade.php

@@ -109,7 +109,7 @@ class="inline-block mr-1 -mt-1 ark-logo-red"
         @if (count($socials) > 0)
             <nav class="flex space-x-3 leading-6">
                 @foreach ($socials as $network)
-                    <x-ark-social-link :url="$network['url']" :icon="$network['icon']" data-safe-external />
+                    <x-ark-social-link :url="$network['url']" :icon="$network['icon']" :label="$network['label'] ?? null" data-safe-external />
                 @endforeach
             </nav>
         @endif

resources/views/icon.blade.php

@@ -32,4 +32,4 @@
     }
 @endphp
 
-@svg($name, collect([$size, $style, $class])->filter()->join(' '), ['wire:key' => Str::random(8)])
+@svg($name, collect([$size, $style, $class])->filter()->join(' '), $attributes->merge(['wire:key' => Str::random(8)])->all())

resources/views/social-link.blade.php

@@ -1,9 +1,23 @@
+@props([
+    'url',
+    'icon',
+    'label' => null,
+])
+
 <a
     {{ $attributes }}
     href="{{ $url }}"
     target="_blank"
     rel="noopener noreferrer"
     class="rounded transition-default hover:text-theme-secondary-200"
+    @if ($label)
+        aria-label="{{ $label }}"
+        title="{{ $label }}"
+    @endif
 >
-    <x-ark-icon :name="$icon" size="sm" />
+    <x-ark-icon :name="$icon" size="sm" aria-hidden="true" />
+
+    @if ($label)
+        <span class="sr-only">{{ $label }}</span>
+    @endif
 </a>

tests/__snapshots__/LinkRendererTest__it_should_render_external_links_with_data_set_(ftpgoogle.com)__1.txt

@@ -1,2 +1,2 @@
-<a href="ftp://google.com" title="Title" target="_blank" data-external="true">Label @svg($name, collect([$size, $style, $class])->filter()->join(' '), ['wire:key' => Str::random(8)])
+<a href="ftp://google.com" title="Title" target="_blank" data-external="true">Label @svg($name, collect([$size, $style, $class])->filter()->join(' '), $attributes->merge(['wire:key' => Str::random(8)])->all())
 </a>

tests/__snapshots__/LinkRendererTest__it_should_render_external_links_with_data_set_(google.com)__1.txt

@@ -1,2 +1,2 @@
-<a href="//google.com" title="Title" target="_blank" data-external="true">Label @svg($name, collect([$size, $style, $class])->filter()->join(' '), ['wire:key' => Str::random(8)])
+<a href="//google.com" title="Title" target="_blank" data-external="true">Label @svg($name, collect([$size, $style, $class])->filter()->join(' '), $attributes->merge(['wire:key' => Str::random(8)])->all())
 </a>

tests/__snapshots__/LinkRendererTest__it_should_render_external_links_with_data_set_(httpsgoogle.com)__1.txt

@@ -1,2 +1,2 @@
-<a href="https://google.com" title="Title" target="_blank" data-external="true">Label @svg($name, collect([$size, $style, $class])->filter()->join(' '), ['wire:key' => Str::random(8)])
+<a href="https://google.com" title="Title" target="_blank" data-external="true">Label @svg($name, collect([$size, $style, $class])->filter()->join(' '), $attributes->merge(['wire:key' => Str::random(8)])->all())
 </a>

tests/__snapshots__/LinkRendererTest__it_should_render_external_links_with_data_set_(unsupportedrelativeurl)__1.txt

@@ -1,2 +1,2 @@
-<a href="unsupported/relative/url" title="Title" target="_blank" data-external="true">Label @svg($name, collect([$size, $style, $class])->filter()->join(' '), ['wire:key' => Str::random(8)])
+<a href="unsupported/relative/url" title="Title" target="_blank" data-external="true">Label @svg($name, collect([$size, $style, $class])->filter()->join(' '), $attributes->merge(['wire:key' => Str::random(8)])->all())
 </a>