test: enforce 100% test coverage (#45)

Author: marianogoldman

composer.json

@@ -44,7 +44,7 @@
             "vendor/bin/php-cs-fixer fix"
         ],
         "test": [
-            "./vendor/bin/pest --coverage --coverage-html=.coverage --coverage-clover=coverage.xml"
+            "./vendor/bin/pest --coverage --min=100 --coverage-html=.coverage --coverage-clover=coverage.xml"
         ]
     },
     "require-dev": {

phpunit.xml

@@ -14,6 +14,11 @@
             <directory suffix=".php">./app</directory>
             <directory suffix=".php">./src</directory>
         </include>
+        <exclude>
+            <file>./src/FortifyServiceProvider.php</file>
+            <file>./src/Components/LogoutOtherBrowserSessionsForm.php</file>
+        </exclude>
+
     </coverage>
     <php>
         <server name="APP_KEY" value="AckfSECXIvnK5r28GVIWUAxmbBSjTsmF"/>

src/FortifyServiceProvider.php

@@ -195,9 +195,7 @@ private function registerViews(): void
     private function registerAuthentication(): void
     {
         Fortify::authenticateUsing(function (Request $request) {
-            $authenticator = new AuthenticateUser($request);
-
-            return (new AuthenticateUser($request))->handle($request);
+            return (new AuthenticateUser($request))->handle();
         });
     }
 

src/Responses/RegisterResponse.php

@@ -5,7 +5,6 @@
 namespace ARKEcosystem\Fortify\Responses;
 
 use Illuminate\Http\JsonResponse;
-use Illuminate\Http\Response;
 use Laravel\Fortify\Contracts\RegisterResponse as RegisterResponseContract;
 
 final class RegisterResponse implements RegisterResponseContract

tests/Actions/AuthenticateUserTest.php

@@ -84,3 +84,21 @@
 
     $this->assertNull($loggedUser);
 });
+
+it('doesnt login the user if password is incorrect', function () {
+    Config::set('fortify.models.user', \ARKEcosystem\Fortify\Models\User::class);
+
+    $user = User::factory()->create();
+
+    $request = new Request();
+
+    $request->replace([
+        'email'    => $user->email,
+        'password' => 'wrong-password',
+    ]);
+
+    $authenticator = new AuthenticateUser($request);
+    $loggedUser = $authenticator->handle();
+
+    $this->assertNull($loggedUser);
+});

tests/Components/DeleteUserFormTest.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Components;
+
+use ARKEcosystem\Fortify\Components\DeleteUserForm;
+use ARKEcosystem\Fortify\Contracts\DeleteUser;
+use Illuminate\Support\Facades\Auth;
+use Livewire\Livewire;
+use function Tests\createUserModel;
+
+it('can interact with the form', function () {
+    $user = createUserModel();
+
+    $this->mock(DeleteUser::class)
+        ->shouldReceive('delete');
+
+    Livewire::actingAs($user)
+        ->test(DeleteUserForm::class)
+        ->assertViewIs('ark-fortify::profile.delete-user-form')
+        ->call('confirmUserDeletion')
+        ->assertSee('Are you sure you want to delete your account? Deleting your account is irreversible and all deleted data is unrecoverable')
+        ->call('deleteUser')
+        ->assertRedirect('/');
+    $this->assertNull(Auth::user());
+});

tests/Components/LogoutOtherBrowserSessionsFormTest.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+use ARKEcosystem\Fortify\Components\LogoutOtherBrowserSessionsForm;
+use Livewire\Livewire;
+use function Tests\createUserModel;
+
+it('can interact with the form', function () {
+    $user = createUserModel();
+
+    Livewire::actingAs($user)
+        ->test(LogoutOtherBrowserSessionsForm::class);
+})->skip('not sure we\'re using this component anyware as it references blade components that don\'t exist');

tests/Components/RegisterFormTest.php

@@ -0,0 +1,50 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Components;
+
+use ARKEcosystem\Fortify\Components\RegisterForm;
+use Faker\Provider\Uuid;
+use Illuminate\Database\Eloquent\Model;
+use Illuminate\Support\Facades\Config;
+use Illuminate\Support\Facades\Route;
+use Livewire\Livewire;
+use Spatie\MediaLibrary\MediaCollections\Models\Concerns\HasUuid;
+
+it('can interact with the form', function () {
+    Config::set('fortify.models.invitation', RegisterFormTest::class);
+    Route::get('terms-of-service', function () {
+        return view('');
+    })->name('terms-of-service');
+    Route::get('privacy-policy', function () {
+        return view('');
+    })->name('privacy-policy');
+    Route::get('notification-settings', function () {
+        return view('');
+    })->name('notification-settings');
+
+    $invitationUuid = Uuid::uuid();
+
+    Livewire::withQueryParams(['invitation' => $invitationUuid])
+        ->test(RegisterForm::class)
+        ->set('state.name', 'John Doe')
+        ->set('state.username', 'jdoe')
+        ->set('state.email', 'jdoe@example.org')
+        ->set('state.email', 'jdoe@example.org')
+        ->assertViewIs('ark-fortify::auth.register-form')
+        ->assertViewHas('invitation');
+});
+
+/**
+ * @coversNothing
+ */
+class RegisterFormTest extends Model
+{
+    use HasUuid;
+
+    public static function findByUuid(string $uuid): ?Model
+    {
+        return new self();
+    }
+}

tests/Components/ResetPasswordFormTest.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tests\Components;
+
+use ARKEcosystem\Fortify\Components\ResetPasswordForm;
+use Livewire\Livewire;
+use function Tests\createUserModel;
+
+it('can interact with the form', function () {
+    $user = createUserModel();
+
+    Livewire::actingAs($user)
+        ->test(ResetPasswordForm::class)
+        ->assertSet('state', [
+            'email'                 => null,
+            'password'              => '',
+            'password_confirmation' => '',
+        ])
+        ->assertViewIs('ark-fortify::auth.reset-password-form');
+});

tests/Components/TwoFactorAuthenticationFormTest.php

@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+use ARKEcosystem\Fortify\Components\TwoFactorAuthenticationForm;
+use Livewire\Livewire;
+use PragmaRX\Google2FALaravel\Google2FA;
+use function Tests\createUserModel;
+
+it('can interact with the form', function () {
+    $user = createUserModel();
+
+    $g2FA = $this->mock(Google2FA::class);
+    $g2FA->shouldReceive('verifyKey')
+        ->andReturnTrue();
+    app()->instance('pragmarx.google2fa', $g2FA);
+
+    $two_factor_secret = 'QHBRXHLWOT3B2T3L';
+    Livewire::actingAs($user)
+        ->test(TwoFactorAuthenticationForm::class)
+        ->assertSee('You have not enabled two factor authentication.')
+        ->set('state.two_factor_secret', $two_factor_secret)
+        ->assertSet('enabled', false)
+        ->assertSee($two_factor_secret)
+        ->set('state.otp', '843733')
+        ->call('enableTwoFactorAuthentication')
+        ->assertSee('Two-Factor Authentication Reset Code')
+        ->assertSee('If you lose your two-factor authentication device')
+        ->call('regenerateRecoveryCodes')
+        ->assertSee('Two-Factor Authentication Reset Code')
+        ->call('hideRecoveryCodes')
+        ->assertSee('You have enabled two factor authentication')
+        ->call('disableTwoFactorAuthentication')
+        ->assertSee('You have not enabled two factor authentication');
+});