Refactor ShouldDispose to be a settable property instead of constructor parameter

Co-authored-by: Arlodotexe <9384894+Arlodotexe@users.noreply.github.com>

Author: Copilot

src/Extensions/CreateRelativeStorageExtensions.cs

@@ -240,7 +240,7 @@ public static async Task<IChildFile> CreateFileByRelativePathAsync(this IChildFi
 
         throw new InvalidOperationException("Resolved item is not a file.");
     }
-    
+
     /// <summary>
     /// Traverses/creates folders along a relative path and yields each folder in order as it is visited/created.
     /// Supports "." and ".." segments. If the last segment looks like a file (no trailing slash and contains '.'),

src/Extensions/FileOpenExtensions.cs

@@ -16,15 +16,15 @@ public static partial class FileExtensions
     /// <param name="cancellationToken">A token that can be used to cancel the ongoing operation.</param>
     /// <returns>A task containing the requested stream.</returns>
     public static Task<Stream> OpenReadAsync(this IFile file, CancellationToken cancellationToken = default) => file.OpenStreamAsync(FileAccess.Read, cancellationToken);
-    
+
     /// <summary>
     /// Opens the file for writing.
     /// </summary>
     /// <param name="file">The file to open.</param>
     /// <param name="cancellationToken">A token that can be used to cancel the ongoing operation.</param>
     /// <returns>A task containing the requested stream.</returns>
     public static Task<Stream> OpenWriteAsync(this IFile file, CancellationToken cancellationToken = default) => file.OpenStreamAsync(FileAccess.Write, cancellationToken);
-    
+
     /// <summary>
     /// Opens the file for reading and writing.
     /// </summary>

src/Extensions/GetItemByRelativePathExtension.cs

@@ -96,7 +96,7 @@ public static async IAsyncEnumerable<IStorable> GetItemsAlongRelativePathAsync(t
         var normalized = (relativePath ?? string.Empty).Replace('\\', '/');
         // Split path into parts (use API available on target framework)
 #if NETSTANDARD2_0
-    var parts = normalized.Split(['/'], StringSplitOptions.RemoveEmptyEntries);
+        var parts = normalized.Split(['/'], StringSplitOptions.RemoveEmptyEntries);
 #else
         var parts = normalized.Split('/', StringSplitOptions.RemoveEmptyEntries);
 #endif

src/Extensions/GetRelativePathToExtension.cs

@@ -21,7 +21,7 @@ public static async Task<string> GetRelativePathToAsync(this IFolder from, IStor
         {
             to.Name,
         };
-        
+
         cancellationToken.ThrowIfCancellationRequested();
         await RecursiveAddParentToPathAsync(to);
 

src/IModifiableFolder.cs

@@ -7,7 +7,7 @@ namespace OwlCore.Storage;
 /// <summary>
 /// Represents a folder that can be modified.
 /// </summary>
-public interface IModifiableFolder : IMutableFolder 
+public interface IModifiableFolder : IMutableFolder
 {
     /// <summary>
     /// Deletes the provided storable item from this folder.
@@ -26,7 +26,7 @@ public interface IModifiableFolder : IMutableFolder
     /// <param name="cancellationToken">A token that can be used to cancel the ongoing operation.</param>
     /// <returns>The newly created (or opened if existing) folder.</returns>
     Task<IChildFolder> CreateFolderAsync(string name, bool overwrite = default, CancellationToken cancellationToken = default);
-    
+
     /// <summary>
     /// Creates a new file with the desired name inside this folder.
     /// </summary>

src/IStorable.cs

@@ -22,5 +22,5 @@ public interface IStorable
     /// <summary>
     /// Gets the name of the item, with the extension (if any).
     /// </summary>
-    string Name { get; } 
+    string Name { get; }
 }

src/IStorableChild.cs

@@ -13,5 +13,5 @@ public interface IStorableChild : IStorable
     /// </summary>
     /// <param name="cancellationToken">A token that can be used to cancel the ongoing operation.</param>
     /// <returns>The containing parent folder, if any.</returns>
-    Task<IFolder?> GetParentAsync(CancellationToken cancellationToken = default); 
+    Task<IFolder?> GetParentAsync(CancellationToken cancellationToken = default);
 }

src/Memory/NonDisposableStreamWrapper.cs

@@ -19,12 +19,12 @@ public NonDisposableStreamWrapper(Stream stream)
     {
         _stream = stream;
     }
-    
+
     /// <inheritdoc />
     protected override void Dispose(bool disposing)
     {
     }
-    
+
     /// <inheritdoc />
     public override void Flush() => _stream.Flush();
 
@@ -50,16 +50,16 @@ public override Task WriteAsync(byte[] buffer, int offset, int count, Cancellati
 
     /// <inheritdoc />
     public override bool CanRead => _stream.CanRead;
-    
+
     /// <inheritdoc />
     public override bool CanSeek => _stream.CanSeek;
-    
+
     /// <inheritdoc />
     public override bool CanWrite => _stream.CanWrite;
-    
+
     /// <inheritdoc />
     public override long Length => _stream.Length;
-    
+
     /// <inheritdoc />
     public override long Position
     {

src/System/IO/StreamFile.cs

@@ -17,29 +17,20 @@ public class StreamFile : IFile
     public Stream Stream { get; }
 
     /// <summary>
-    /// Gets a value indicating whether the underlying stream should be disposed when the returned stream from <see cref="OpenStreamAsync"/> is disposed.
+    /// Gets or sets a value indicating whether the underlying stream should be disposed when the returned stream from <see cref="OpenStreamAsync"/> is disposed.
     /// When true, the underlying stream is returned directly. When false, the stream is wrapped in a non-disposable wrapper.
     /// </summary>
-    public bool ShouldDispose { get; }
+    public bool ShouldDispose { get; set; }
 
     /// <summary>
     /// Creates a new instance of <see cref="StreamFile"/>.
     /// </summary>
     /// <param name="stream">An existing stream which is provided as the file contents.</param>
     public StreamFile(Stream stream)
-        : this(stream, $"{stream.GetHashCode()}", $"{stream.GetHashCode()}", false)
+        : this(stream, $"{stream.GetHashCode()}", $"{stream.GetHashCode()}")
     {
     }
 
-    /// <summary>
-    /// Creates a new instance of <see cref="StreamFile"/>.
-    /// </summary>
-    /// <param name="stream">An existing stream which is provided as the file contents.</param>
-    /// <param name="shouldDispose">When true, the underlying stream will be disposed when the returned stream from <see cref="OpenStreamAsync"/> is disposed. When false, the stream is wrapped in a non-disposable wrapper.</param>
-    public StreamFile(Stream stream, bool shouldDispose)
-        : this(stream, $"{stream.GetHashCode()}", $"{stream.GetHashCode()}", shouldDispose)
-    {
-    }
 
     /// <summary>
     /// Creates a new instance of <see cref="StreamFile"/>.
@@ -48,25 +39,15 @@ public StreamFile(Stream stream, bool shouldDispose)
     /// <param name="id">A unique and consistent identifier for this file or folder.</param>
     /// <param name="name">The name of the file or folder, with the extension (if any).</param>
     public StreamFile(Stream stream, string id, string name)
-        : this(stream, id, name, false)
-    {
-    }
-
-    /// <summary>
-    /// Creates a new instance of <see cref="StreamFile"/>.
-    /// </summary>
-    /// <param name="stream">An existing stream which is provided as the file contents.</param>
-    /// <param name="id">A unique and consistent identifier for this file or folder.</param>
-    /// <param name="name">The name of the file or folder, with the extension (if any).</param>
-    /// <param name="shouldDispose">When true, the underlying stream will be disposed when the returned stream from <see cref="OpenStreamAsync"/> is disposed. When false, the stream is wrapped in a non-disposable wrapper.</param>
-    public StreamFile(Stream stream, string id, string name, bool shouldDispose)
     {
         Stream = stream;
         Id = id;
         Name = name;
-        ShouldDispose = shouldDispose;
+        ShouldDispose = false; // Default to false for backward compatibility
     }
 
+
+
     /// <inheritdoc />
     public string Id { get; }
 

src/TruncatedStream.cs

@@ -14,7 +14,7 @@ public class TruncatedStream(Stream Stream, long MaxLength) : Stream, IAsyncDisp
 {
     // For non-seekable streams, we track how many bytes have been consumed to enforce the window.
     private long _consumed;
-    
+
     // For seekable streams, capture the starting offset to define the truncation window.
     private readonly long _startOffset = Stream.CanSeek ? Stream.Position : 0;