Merge pull request #87 from Arlodotexe/fix/getitembyrelativepath/wasm-windows

Fixed GetItemByRelativePathAsync not recognizing Windows-style path separators when running on WASM on Windows

Author: Arlodotexe

src/Extensions/GetItemByRelativePathExtension.cs

@@ -27,12 +27,17 @@ public static partial class StorableExtensions
     /// <exception cref="FileNotFoundException">A named item was specified in a folder, but the item wasn't found.</exception>
     public static async Task<IStorable> GetItemByRelativePathAsync(this IStorable from, string relativePath, CancellationToken cancellationToken = default)
     {
-        var inputPathChars = new[] { Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar, Path.PathSeparator, Path.VolumeSeparatorChar };
+        // Input path separators should include all possible separators that can be used in a path.
+        // This includes the directory separator, alternate directory separator, path separator, and volume separator.
+        // In some scenarios, such as dotnet running on WASM on Windows, a path separator may be used that is not given by dotnet via these properties.
+        // Therefore, we also include '/' and '\' as valid path separators. 
+        // See also https://github.com/Arlodotexe/OwlCore.Storage/issues/86
+        char[] inputPathSepChars = [Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar, Path.PathSeparator, Path.VolumeSeparatorChar, '/', '\\'];
         var ourPathSeparator = @"/";
 
         // Traverse only one level at a time
         // But recursively, until the target has been reached.
-        var pathParts = relativePath.Split(inputPathChars).Where(x => !string.IsNullOrWhiteSpace(x) && x != ".").ToArray();
+        var pathParts = relativePath.Split([..inputPathSepChars.Distinct()]).Where(x => !string.IsNullOrWhiteSpace(x) && x != ".").ToArray();
 
         // Current directory was specified.
         if (pathParts.Length == 0)

src/OwlCore.Storage.csproj

@@ -2,7 +2,7 @@
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
     <Nullable>enable</Nullable>
-    <LangVersion>10.0</LangVersion>
+    <LangVersion>12.0</LangVersion>
     <WarningsAsErrors>nullable</WarningsAsErrors>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
@@ -14,7 +14,7 @@
     <AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
 
     <Author>Arlo Godfrey</Author>
-    <Version>0.12.2</Version>
+    <Version>0.12.3</Version>
     <Product>OwlCore</Product>
     <Description>The most flexible file system abstraction, ever. Built in partnership with the Windows App Community.
 
@@ -23,6 +23,10 @@
     <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
     <PackageIcon>logo.png</PackageIcon>
     <PackageReleaseNotes>
+--- 0.12.3 ---
+[Fixes]
+Fixed an issue with GetItemByRelativePathAsync not recognizing Windows-style path separators when running on WASM on Windows.
+
 --- 0.12.2 ---
 [Improvements]
 Added the `virtual` keyword to all methods in `MemoryFile` and `MemoryFolder`, allowing consumers to extend these or adjust these methods in a custom derived implementation.