throw exception on ga token is empty

Author: ArtARTs36

src/Infrastructure/Ci/System/Github/Credentials/GithubActionsCredentialsMapper.php

@@ -8,6 +8,7 @@
 use ArtARTs36\MergeRequestLinter\Infrastructure\Contracts\CI\InvalidCredentialsException;
 use ArtARTs36\MergeRequestLinter\Infrastructure\Contracts\Configuration\ConfigValueTransformer;
 use ArtARTs36\MergeRequestLinter\Infrastructure\Contracts\Configuration\TransformConfigValueException;
+use ArtARTs36\Str\Facade\Str;
 
 class GithubActionsCredentialsMapper implements AuthenticatorMapper
 {
@@ -28,7 +29,13 @@ public function map(array $credentials): Authenticator
         }
 
         try {
-            return HeaderAuthenticator::bearer($this->value->tryTransform($credentials['token']));
+            $token = $this->value->tryTransform($credentials['token']);
+
+            if (Str::isEmpty($token)) {
+                throw new InvalidCredentialsException('Failed to resolve github token: token is empty');
+            }
+
+            return HeaderAuthenticator::bearer($token);
         } catch (TransformConfigValueException $e) {
             throw new InvalidCredentialsException(sprintf(
                 'Failed to resolve github token: %s',

tests/Unit/Infrastructure/Ci/System/Github/Credentials/GithubActionsCredentialsMapperTest.php

@@ -6,7 +6,9 @@
 use ArtARTs36\MergeRequestLinter\Infrastructure\Ci\System\Github\Credentials\GithubActionsCredentialsMapper;
 use ArtARTs36\MergeRequestLinter\Infrastructure\Configuration\Value\CompositeTransformer;
 use ArtARTs36\MergeRequestLinter\Infrastructure\Contracts\CI\InvalidCredentialsException;
+use ArtARTs36\MergeRequestLinter\Infrastructure\Contracts\Configuration\ConfigValueTransformer;
 use ArtARTs36\MergeRequestLinter\Tests\TestCase;
+use PHPUnit\Framework\MockObject\Rule\InvokedCount;
 
 final class GithubActionsCredentialsMapperTest extends TestCase
 {
@@ -35,4 +37,25 @@ public function testMapOnInvalidCredentials(): void
 
         $mapper->map([]);
     }
+
+    /**
+     * @covers \ArtARTs36\MergeRequestLinter\Infrastructure\Ci\System\Github\Credentials\GithubActionsCredentialsMapper::map
+     * @covers \ArtARTs36\MergeRequestLinter\Infrastructure\Ci\System\Github\Credentials\GithubActionsCredentialsMapper::__construct
+     */
+    public function testMapOnTransformReturnsEmptyValue(): void
+    {
+        $transformer = $this->createMock(ConfigValueTransformer::class);
+        $transformer
+            ->expects(new InvokedCount(1))
+            ->method('tryTransform')
+            ->willReturn('');
+
+        $mapper = new GithubActionsCredentialsMapper($transformer);
+
+        self::expectExceptionMessage('Failed to resolve github token: token is empty');
+
+        $mapper->map([
+            'token' => '${}',
+        ]);
+    }
 }