Hotfix workshop auto-update

Author: RobertBeekman

src/Artemis.WebClient.Workshop/Services/WorkshopService.cs

@@ -26,9 +26,8 @@ public class WorkshopService : IWorkshopService
     private readonly IWorkshopClient _workshopClient;
     private readonly PluginSetting<bool> _migratedBuiltInPlugins;
 
-
-
     private bool _initialized;
+    private bool _mutating;
 
     public WorkshopService(ILogger logger,
         IHttpClientFactory httpClientFactory,
@@ -173,27 +172,45 @@ public async Task NavigateToEntry(long entryId, EntryType entryType)
     /// <inheritdoc />
     public async Task<EntryInstallResult> InstallEntry(IEntrySummary entry, IRelease release, Progress<StreamProgress> progress, CancellationToken cancellationToken)
     {
-        IEntryInstallationHandler handler = _factory.CreateHandler(entry.EntryType);
-        EntryInstallResult result = await handler.InstallAsync(entry, release, progress, cancellationToken);
-        if (result.IsSuccess && result.Entry != null)
-            OnEntryInstalled?.Invoke(this, result.Entry);
-        else
-            _logger.Warning("Failed to install entry {Entry}: {Message}", entry, result.Message);
-
-        return result;
+        _mutating = true;
+
+        try
+        {
+            IEntryInstallationHandler handler = _factory.CreateHandler(entry.EntryType);
+            EntryInstallResult result = await handler.InstallAsync(entry, release, progress, cancellationToken);
+            if (result.IsSuccess && result.Entry != null)
+                OnEntryInstalled?.Invoke(this, result.Entry);
+            else
+                _logger.Warning("Failed to install entry {Entry}: {Message}", entry, result.Message);
+
+            return result;
+        }
+        finally
+        {
+            _mutating = false;
+        }
     }
 
     /// <inheritdoc />
     public async Task<EntryUninstallResult> UninstallEntry(InstalledEntry installedEntry, CancellationToken cancellationToken)
     {
-        IEntryInstallationHandler handler = _factory.CreateHandler(installedEntry.EntryType);
-        EntryUninstallResult result = await handler.UninstallAsync(installedEntry, cancellationToken);
-        if (result.IsSuccess)
-            OnEntryUninstalled?.Invoke(this, installedEntry);
-        else
-            _logger.Warning("Failed to uninstall entry {EntryId}: {Message}", installedEntry.Id, result.Message);
-
-        return result;
+        _mutating = true;
+
+        try
+        {
+            IEntryInstallationHandler handler = _factory.CreateHandler(installedEntry.EntryType);
+            EntryUninstallResult result = await handler.UninstallAsync(installedEntry, cancellationToken);
+            if (result.IsSuccess)
+                OnEntryUninstalled?.Invoke(this, installedEntry);
+            else
+                _logger.Warning("Failed to uninstall entry {EntryId}: {Message}", installedEntry.Id, result.Message);
+
+            return result;
+        }
+        finally
+        {
+            _mutating = false;
+        }
     }
 
     /// <inheritdoc />
@@ -316,16 +333,28 @@ private async Task MigrateBuiltInPlugins()
         // If already migrated, do nothing
         if (_migratedBuiltInPlugins.Value)
             return;
+
+        _mutating = true;
 
-        MigratingBuildInPlugins?.Invoke(this, EventArgs.Empty);
+        try
+        {
+            MigratingBuildInPlugins?.Invoke(this, EventArgs.Empty);
 
-        bool migrated = await BuiltInPluginsMigrator.Migrate(this, _workshopClient, _logger, _pluginRepository);
-        _migratedBuiltInPlugins.Value = migrated;
-        _migratedBuiltInPlugins.Save();
+            bool migrated = await BuiltInPluginsMigrator.Migrate(this, _workshopClient, _logger, _pluginRepository);
+            _migratedBuiltInPlugins.Value = migrated;
+            _migratedBuiltInPlugins.Save();
+        }
+        finally
+        {
+            _mutating = false;
+        }
     }
 
     private void ProfileServiceOnProfileRemoved(object? sender, ProfileConfigurationEventArgs e)
     {
+        if (_mutating)
+            return;
+
         InstalledEntry? entry = GetInstalledEntryByProfile(e.ProfileConfiguration);
         if (entry == null)
             return;
@@ -336,6 +365,9 @@ private void ProfileServiceOnProfileRemoved(object? sender, ProfileConfiguration
 
     private void PluginManagementServiceOnPluginRemoved(object? sender, PluginEventArgs e)
     {
+        if (_mutating)
+            return;
+        
         InstalledEntry? entry = GetInstalledEntryByPlugin(e.Plugin);
         if (entry == null)
             return;
@@ -349,6 +381,6 @@ private void PluginManagementServiceOnPluginRemoved(object? sender, PluginEventA
     public event EventHandler<InstalledEntry>? OnEntryUninstalled;
 
     public event EventHandler<InstalledEntry>? OnEntryInstalled;
-    
+
     public event EventHandler? MigratingBuildInPlugins;
 }