Fixes #4: support multibytes string split

ArthurHoaro · ArthurHoaro · commit 1f3c3cff8197 · 2017-01-20T11:28:09.000+01:00
Requires php extension mbstring:
diff --git a/README.md b/README.md
@@ -12,6 +12,7 @@ to post it on Twitter.
 
   - PHP 5.3
   - PHP cURL extension
+  - PHP mbstring extension
   - Shaarli >= v0.8.1
 
 ## Installation
diff --git a/shaarli2twitter/shaarli2twitter.php b/shaarli2twitter/shaarli2twitter.php
@@ -206,7 +206,7 @@ function replace_placeholder($tweet, $placeholder, $value)
     // Tweets URL have a fixed size due to t.co
     $valueLength = ($placeholder != 'url' && $placeholder != 'permalink') ? strlen($value) : TWEET_URL_LENGTH;
     if ($current + $valueLength > TWEET_LENGTH) {
-        $value = substr($value, 0, TWEET_LENGTH - $current - 3) . '…';
+        $value = mb_strcut($value, 0, TWEET_LENGTH - $current - 3) . '…';
     }
     return str_replace('${'. $placeholder .'}', $value, $tweet);
 }

Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ function replace_placeholder($tweet, $placeholder, $value)`
`206`	`206`	`// Tweets URL have a fixed size due to t.co`
`207`	`207`	`$valueLength = ($placeholder != 'url' && $placeholder != 'permalink') ? strlen($value) : TWEET_URL_LENGTH;`
`208`	`208`	`if ($current + $valueLength > TWEET_LENGTH) {`
`209`		`- $value = substr($value, 0, TWEET_LENGTH - $current - 3) . '…';`
	`209`	`+ $value = mb_strcut($value, 0, TWEET_LENGTH - $current - 3) . '…';`
`210`	`210`	`}`
`211`	`211`	`return str_replace('${'. $placeholder .'}', $value, $tweet);`
`212`	`212`	`}`