Skip to content

Commit 3afe2dc

Browse files
committed
refactor extracted methods and members
1 parent 8b15262 commit 3afe2dc

1 file changed

Lines changed: 11 additions & 5 deletions

File tree

mesh/src/main/java/mesh/creator/archimedian/RhombicuboctahedronCreator.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,19 @@
66

77
public class RhombicuboctahedronCreator implements IMeshCreator {
88

9+
float a = 1.0f;
10+
11+
float b = 1.0f + Mathf.sqrt(2.0f);
12+
913
@Override
1014
public Mesh3D create() {
1115
Mesh3D mesh = new Mesh3D();
16+
createVertices(mesh);
17+
createFaces(mesh);
18+
return mesh;
19+
}
1220

13-
float a = 1.0f;
14-
float b = 1.0f + Mathf.sqrt(2.0f);
15-
21+
private void createVertices(Mesh3D mesh) {
1622
mesh.addVertex(+a, +a, +b);
1723
mesh.addVertex(+a, +a, -b);
1824
mesh.addVertex(+a, -a, +b);
@@ -39,7 +45,9 @@ public Mesh3D create() {
3945
mesh.addVertex(-b, +a, -a);
4046
mesh.addVertex(-b, -a, +a);
4147
mesh.addVertex(-b, -a, -a);
48+
}
4249

50+
private void createFaces(Mesh3D mesh) {
4351
mesh.addFace(0, 16, 8);
4452
mesh.addFace(1, 9, 17);
4553
mesh.addFace(2, 10, 18);
@@ -67,7 +75,5 @@ public Mesh3D create() {
6775
mesh.addFace(14, 22, 23, 15);
6876
mesh.addFace(16, 18, 20, 17);
6977
mesh.addFace(19, 21, 23, 22);
70-
71-
return mesh;
7278
}
7379
}

0 commit comments

Comments
 (0)