Will this be OK for ArWeave?

[LaserWorker]

Does anyone over there at Arweave know if some base modifications for new C++ standards would work fine with the existing structure of Arweave... the Rebar3 seems to be calling for some direct code modification:

ADD LINE:
"#include "
arweave/_build/default/lib/rocksdb/deps/rocksdb/db/compaction/sst_partitioner.cc
arweave/_build/default/lib/rocksdb/deps/rocksdb/include/rocksdb/sst_partitioner.h
arweave/_build/default/lib/rocksdb/deps/rocksdb/db/blob/blob_file_meta.h
arweave/_build/default/lib/rocksdb/deps/rocksdb/db/blob/blob_file_meta.cc
.... and many other code files

REMOVE TEXT:
""
arweave/build/default/lib/rocksdb/deps/rocksdb/db/kv_checksum.h
86 | ProtectionInfo(T val) : val(val) {
99 | ProtectionInfoKVO() = default;
120 | ProtectionInfoKVO(T val) : info_(val) {
133 | ProtectionInfoKVOC() = default;
171 | ProtectionInfoKVOS() = default;

[JamesPiechota]

I'm afraid I don't understand the question.

[LaserWorker]

My mistake I failed to use the code designation method ...
The line to be added is :
#include <cstdint>
that would be added to the top of :
arweave/_build/default/lib/rocksdb/deps/rocksdb/db/compaction/sst_partitioner.cc
arweave/_build/default/lib/rocksdb/deps/rocksdb/include/rocksdb/sst_partitioner.h
arweave/_build/default/lib/rocksdb/deps/rocksdb/db/blob/blob_file_meta.h
arweave/_build/default/lib/rocksdb/deps/rocksdb/db/blob/blob_file_meta.cc
arweave/_build/default/lib/rocksdb/deps/rocksdb/include/rocksdb/trace_record.h

The little part to be removed : <T>
it would be removed from: arweave/_build/default/lib/rocksdb/deps/rocksdb/db/kv_checksum.h
In the key places that seem to construct some structures incorrectly...
86 | ProtectionInfo<T>(T val) : val_(val) { 99 | ProtectionInfoKVO<T>() = default; 120 | ProtectionInfoKVO<T>(T val) : info_(val) { 133 | ProtectionInfoKVOC<T>() = default; 171 | ProtectionInfoKVOS<T>() = default;
Anyway, I wanted to go ahead and put this build onto the main network, so I just wanted to check these changes to the code would be OK.

[LaserWorker]

Honestly we are more concerned with the constructors inside " _build/default/lib/rocksdb/deps/rocksdb/db/kv_checksum.h " ... clearly adding an include of cstdint does not change much.
"ProtectiononInfo" sounds important!
I'm not sure why my Rebar3 here on Arch is calling for me to remove the ...
<T>
any time it is right before a variable input bracket of the structure "("
I'm just glad someone cares about the ArWeave ideals enough to check on this.
Thank you.

[JamesPiechota]

Got it. All those files are from the upstream rocksdb dependency: https://github.com/ArweaveTeam/erlang-rocksdb.git

We build off that fork, but have made minimal changes from the source: https://gitlab.com/barrel-db/erlang-rocksdb (which is in turn an erlang wrapper around https://github.com/facebook/rocksdb)

I'm not too familiar with the rocksdb files you're referencing so unfortunately don't have any guidance on whether the changes you're proposing will cause a problem or not. You may have to ask the erlang-rocksdb devs or perhaps even the rocksdb team