more cleanup

Author: seanwentzel

build.js

@@ -56,9 +56,6 @@ if (!force) {
 
 // Build it
 function build() {
-	if (process.versions.electron) {
-		args.push('--target='+ process.versions.electron,  '--dist-url=https://atom.io/download/atom-shell');
-	}
 	cp.spawn(
 		'node-gyp',
 		['rebuild'].concat(args),
@@ -106,9 +103,4 @@ function afterBuild() {
 	}
 	fs.renameSync(targetPath, installPath);
 	console.log('Installed in `'+ installPath+ '`');
-	if (process.versions.electron) {
-		process.nextTick(function() {
-			require('electron').app.quit();
-		});
-	}
 }

test.js

@@ -11,11 +11,6 @@ function runTest(test, cb) {
 	}
 	env.NODE_PATH = __dirname;
 	var args = [];
-	if (process.versions.modules >= 57 && process.versions.modules < 59) {
-		// Node v8 requires forcing async hook checks. In Node v9 (>=59) and beyond,
-		// async hooks checks are on by default (and the param no longer exists).
-		args.push('--force-async-hooks-checks');
-	}
 	args.push(path.join('test', test));
 	var proc = spawn(process.execPath, args, { env: env });
 	proc.stdout.setEncoding('utf8');

test/async-hooks.js

@@ -1,9 +1,5 @@
 'use strict';
-// This test must be run with --force-async-hooks-checks
-if (process.versions.modules < 57) {
-	console.log('pass');
-	return;
-}
+
 const { AsyncResource } = require('async_hooks');
 const Fiber = require('fibers');
 
@@ -13,15 +9,7 @@ class TestResource extends AsyncResource {
 	}
 
 	run(cb) {
-		// In the v8 API, only emitBefore() and emitAfter() are available
-		if (process.versions.modules < 59) {
-			this.emitBefore();
-			cb();
-			this.emitAfter();
-		} else {
-			// In v9 and higher, emitBefore() and emitAfter() are deperecated in favor of runInAsyncScope().
-			this.runInAsyncScope(cb);
-		}
+		this.runInAsyncScope(cb);
 	}
 }
 

test/cleanup.js

@@ -1,49 +1,42 @@
 "use strict";
 var Fiber = require('fibers');
 Fiber.poolSize = 100;
-let v8 = /^([0-9]+)\.([0-9]+)/.exec(process.versions.v8);
-if (v8[1] > 4 || (v8[1] == 4 && v8[2] >= 10)) {
 
-	// Vague benchmark of fiber performance, lower is better
-	function bench() {
-		var d = new Date;
-		for (var ii = 0; ii < 100; ++ii) {
-			var fibers = [];
-			for (var jj = 0; jj < Fiber.poolSize; ++jj) {
-				var fiber = Fiber(function() {
-					Fiber.yield();
-				});
-				fiber.run();
-				fibers.push(fiber);
-			}
-			fibers.map(function(fiber) {
-				fiber.run();
+// Vague benchmark of fiber performance, lower is better
+function bench() {
+	var d = new Date;
+	for (var ii = 0; ii < 100; ++ii) {
+		var fibers = [];
+		for (var jj = 0; jj < Fiber.poolSize; ++jj) {
+			var fiber = Fiber(function() {
+				Fiber.yield();
 			});
+			fiber.run();
+			fibers.push(fiber);
 		}
-		return new Date - d;
-	}
-
-	// Run initial benchmark
-	var ts1 = Math.min(bench(), bench());
-
-	// Dirty up isolate list
-	var fibers = [];
-	for (var ii = 0; ii < Fiber.poolSize + 1000; ++ii) {
-		let fiber = Fiber(function() {
-			Fiber.yield();
+		fibers.map(function(fiber) {
+			fiber.run();
 		});
-		fiber.run();
-		fibers.push(fiber);
 	}
-	fibers.map(function(fiber) {
-		fiber.run();
-	});
+	return new Date - d;
+}
 
-	// Test again
-	var ts2 = Math.min(bench(), bench());
-	console.log(ts1 * 2 < ts2 ? 'fail' : 'pass');
-} else {
+// Run initial benchmark
+var ts1 = Math.min(bench(), bench());
 
-	// Feature is not supported
-	console.log('pass');
+// Dirty up isolate list
+var fibers = [];
+for (var ii = 0; ii < Fiber.poolSize + 1000; ++ii) {
+	let fiber = Fiber(function() {
+		Fiber.yield();
+	});
+	fiber.run();
+	fibers.push(fiber);
 }
+fibers.map(function(fiber) {
+	fiber.run();
+});
+
+// Test again
+var ts2 = Math.min(bench(), bench());
+console.log(ts1 * 2 < ts2 ? 'fail' : 'pass');