cut down on network usage && bugfixes

Author: AsertCreator

NetBlox.Common/Version.cs

@@ -8,6 +8,6 @@ public static class Version
 	{
 		public const int VersionMajor = 16;
 		public const int VersionMinor = 9;
-		public const int VersionPatch = 2;
+		public const int VersionPatch = 3;
 	}
 }

NetBlox/AppManager.cs

@@ -113,9 +113,12 @@ public static async Task<string> DownloadFileAsync(string from, string to)
 				return path;
 			using var stream = await HttpClient.GetStreamAsync(from);
 			using var file = File.OpenWrite(path);
-			byte[] bytes = new byte[stream.Length];
-			stream.Read(bytes);
-			file.Write(bytes);
+			int b = stream.ReadByte();
+			while (b != -1)
+			{
+				file.Write([(byte)b]);
+				b = stream.ReadByte();
+			}
 			file.Flush();
 			return Path.GetFullPath(path).Replace('\\', '/');
 		}

NetBlox/Instances/Character.cs

@@ -75,50 +75,55 @@ public override void Process()
 
 			if (IsLocalPlayer && (GameManager.NetworkManager.IsClient && !GameManager.NetworkManager.IsServer) && Health > 0)
 			{
-				bool dot = false;
+				bool poschg = false;
+				bool rotchg = false;
 
 				if (Raylib.IsKeyDown(KeyboardKey.Space))
 				{
 					Position = Position + new Vector3(0, 0.1f * WalkSpeed / 6, 0);
-					dot = true;
+					poschg = true;
 				}
 				if (Raylib.IsKeyDown(KeyboardKey.LeftShift))
 				{
 					Position = Position + new Vector3(0, 0.1f * -WalkSpeed / 6, 0);
-					dot = true;
+					poschg = true;
 				}
 				if (Raylib.IsKeyDown(KeyboardKey.Q))
 				{
 					Rotation += new Vector3(0, -0.1f * -WalkSpeed, 0);
-					dot = true;
+					rotchg = true;
 				}
 				if (Raylib.IsKeyDown(KeyboardKey.E))
 				{
 					Rotation += new Vector3(0, 0.1f * -WalkSpeed, 0);
-					dot = true;
+					rotchg = true;
 				}
 				if (Raylib.IsKeyDown(KeyboardKey.W))
 				{
 					Position = Position + new Vector3(0.1f * WalkSpeed / 6 * MathF.Cos(angle), 0, 0.1f * WalkSpeed / 6 * MathF.Sin(angle));
-					dot = true;
+					poschg = true;
 				}
 				if (Raylib.IsKeyDown(KeyboardKey.A))
 				{
 					Position = Position + new Vector3(0.1f * WalkSpeed / 6 * MathF.Cos(angle - 1.5708f), 0, 0.1f * WalkSpeed / 6 * MathF.Sin(angle - 1.5708f));
-					dot = true;
+					poschg = true;
 				}
 				if (Raylib.IsKeyDown(KeyboardKey.S))
 				{
 					Position = Position + new Vector3(-0.1f * WalkSpeed / 6 * MathF.Cos(angle), 0, -0.1f * WalkSpeed / 6 * MathF.Sin(angle));
-					dot = true;
+					poschg = true;
 				}
 				if (Raylib.IsKeyDown(KeyboardKey.D))
 				{
 					Position = Position + new Vector3(-0.1f * WalkSpeed / 6 * MathF.Cos(angle - 1.5708f), 0, -0.1f * WalkSpeed / 6 * MathF.Sin(angle - 1.5708f));
-					dot = true;
+					poschg = true;
 				}
 
-				if (dot)
+				if (poschg && !rotchg)
+					ReplicateProperties(["Position"], false);
+				if (!poschg && rotchg)
+					ReplicateProperties(["Rotation"], false);
+				if (poschg && rotchg)
 					ReplicateProperties(["Position", "Rotation"], false);
 			}
 

NetBlox/Instances/DataModel.cs

@@ -78,6 +78,7 @@ public Instance[] GetObjects(string url)
 			RbxlParser.Load(url, ins);
 			Instance[] chlidren = ins.GetChildren();
 			ins.ClearAllChildren();
+			ins.Destroy();
 			return chlidren;
 		}
 		[Lua([Security.Capability.CoreSecurity])]

NetBlox/NetworkManager.cs

@@ -654,7 +654,7 @@ public void RequestOwnerReplication(Instance ins, PropertyInfo[] props)
 
 			bw.Write(ins.UniqueID.ToByteArray());
 			bw.Write(ins.ParentID.ToByteArray());
-			bw.Write(ins.ClassName);
+			bw.Write(""); // we dont actually
 
 			var c = 0;
 
@@ -666,6 +666,8 @@ public void RequestOwnerReplication(Instance ins, PropertyInfo[] props)
 					continue;
 				if (prop.PropertyType == LST)
 					continue;
+				if (!prop.CanWrite)
+					continue;
 				if (!SerializationManager.NetworkSerializers.TryGetValue(prop.PropertyType.FullName ?? "", out var x))
 					continue;
 
@@ -724,6 +726,8 @@ private void PerformReplicationNew(Instance ins, PropertyInfo[] props, RemoteCli
 					continue;
 				if (prop.PropertyType == LST)
 					continue;
+				if (!prop.CanWrite)
+					continue;
 				if (!SerializationManager.NetworkSerializers.TryGetValue(prop.PropertyType.FullName ?? "", out var x))
 					continue;
 

NetBlox/RbxlParser.cs

@@ -20,7 +20,11 @@ public static void Load(string url, Instance dm)
 			var xml = new XmlDocument();
 			var ic = CultureInfo.InvariantCulture;
 			var slist = new SortedSet<string>();
-			xml.LoadXml(File.ReadAllText(AppManager.ResolveUrlAsync(url, true).WaitAndGetResult()));
+			var raw = File.ReadAllText(AppManager.ResolveUrlAsync(url, true).WaitAndGetResult());
+			xml.LoadXml(raw);
+
+			var ogr = dm.GameManager.IsRunning;
+			dm.GameManager.IsRunning = false; // is this bad idea?
 
 			void LoadChildren(Instance inst, XmlNode node)
 			{
@@ -131,6 +135,8 @@ void LoadChildren(Instance inst, XmlNode node)
 				for (int i = 0; i < slist.Count; i++)
 					LogManager.LogWarn(arr[i]);
 			}
+
+			dm.GameManager.IsRunning = ogr;
 		}
 	}
 }

UniversalServer/Program.cs

@@ -35,14 +35,49 @@ public static void Main(string[] args)
 				GameName = "NetBlox Server"
 			}, args, (x) =>
 			{
-				x.CurrentRoot.Clear();
-				x.CurrentIdentity.PlaceName = "Welcoming";
-				x.CurrentIdentity.UniverseName = "Welcoming";
-				x.CurrentIdentity.MaxPlayerCount = 8;
-				x.CurrentIdentity.Author = "Roblox original places";
-				x.CurrentRoot.Name = x.CurrentIdentity.PlaceName;
-				RbxlParser.Load("rbxasset://places/Crossroads.rbxl", x.CurrentRoot);
 				Task.Run(x.NetworkManager.StartServer);
+				Task.Run(() =>
+				{
+					Console.WriteLine("NetBlox Server commmand line:");
+					while (!x.ShuttingDown)
+					{
+						try
+						{
+
+							Console.Write(">> ");
+							string cmd = Console.ReadLine();
+							string[] words = cmd.Split(' ');
+							if (words.Length == 0) continue;
+
+							switch (words[0])
+							{
+								case "load":
+									try
+									{
+										x.CurrentRoot.Clear();
+										x.CurrentIdentity.PlaceName = "Place downloaded from Web";
+										x.CurrentIdentity.UniverseName = "NetBlox";
+										x.CurrentIdentity.MaxPlayerCount = 16;
+										x.CurrentIdentity.Author = "NetBlox";
+										x.CurrentRoot.Name = x.CurrentIdentity.PlaceName;
+										x.CurrentRoot.Load(words[1]);
+									}
+									catch (Exception ex)
+									{
+										Console.WriteLine("Could not load the place: " + ex.Message);
+									}
+									break;
+								case "lua":
+									TaskScheduler.ScheduleScript(x, cmd[4..], 8, null);
+									break;
+							}
+						}
+						catch (Exception ex)
+						{
+							Console.WriteLine("Could not execute requested command: " + ex.Message);
+						}
+					}
+				});
 			});
 			g.MainManager = true;
 			AppManager.SetRenderTarget(g);