Commit 14acbef
committed
fix: cleanup FIXME comments and replace magic numbers with constants
- Replace hardcoded '12' with SEMITONES constant in turtle-singer.js for octave transposition calculations
- Add proper explanations for unclear 'voodoo' and 'fragile' comments
- Convert incomplete feature FIXMEs to descriptive TODOs
- Document SVG structure assumptions in activity.js
- Explain stroke width compensation in blockfactory.js
- Document backup canvas sizing in turtle-painter.js
Files modified:
- js/turtle-singer.js: Use SEMITONES constant instead of magic number 12
- js/block.js: Explain preventDefault() call for drag behavior
- js/blockfactory.js: Document intentional stroke width adjustment
- js/turtle-painter.js: Explain bezier SVG TODO and canvas sizing
- js/piemenus.js: Convert interval tabs FIXME to TODO
- js/activity.js: Document initialization guard and SVG parsing
- js/utils/musicutils.js: Document pitch range and solfege enhancement
All tests pass (1868 tests). Formatted with Prettier. ESLint clean.1 parent 2f41508 commit 14acbef
File tree
7 files changed
+25
-18
lines changed- js
- utils
7 files changed
+25
-18
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1290 | 1290 | | |
1291 | 1291 | | |
1292 | 1292 | | |
1293 | | - | |
| 1293 | + | |
| 1294 | + | |
1294 | 1295 | | |
1295 | 1296 | | |
1296 | 1297 | | |
| |||
1314 | 1315 | | |
1315 | 1316 | | |
1316 | 1317 | | |
1317 | | - | |
| 1318 | + | |
| 1319 | + | |
1318 | 1320 | | |
1319 | 1321 | | |
1320 | 1322 | | |
| |||
5209 | 5211 | | |
5210 | 5212 | | |
5211 | 5213 | | |
5212 | | - | |
| 5214 | + | |
5213 | 5215 | | |
5214 | 5216 | | |
5215 | 5217 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2990 | 2990 | | |
2991 | 2991 | | |
2992 | 2992 | | |
2993 | | - | |
| 2993 | + | |
| 2994 | + | |
2994 | 2995 | | |
2995 | 2996 | | |
2996 | 2997 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
859 | 859 | | |
860 | 860 | | |
861 | 861 | | |
862 | | - | |
| 862 | + | |
| 863 | + | |
863 | 864 | | |
864 | 865 | | |
865 | 866 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2928 | 2928 | | |
2929 | 2929 | | |
2930 | 2930 | | |
2931 | | - | |
| 2931 | + | |
2932 | 2932 | | |
2933 | 2933 | | |
2934 | 2934 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1007 | 1007 | | |
1008 | 1008 | | |
1009 | 1009 | | |
1010 | | - | |
| 1010 | + | |
1011 | 1011 | | |
1012 | 1012 | | |
1013 | 1013 | | |
| |||
1344 | 1344 | | |
1345 | 1345 | | |
1346 | 1346 | | |
1347 | | - | |
| 1347 | + | |
| 1348 | + | |
1348 | 1349 | | |
1349 | 1350 | | |
1350 | 1351 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
1009 | 1010 | | |
1010 | 1011 | | |
1011 | 1012 | | |
| 1013 | + | |
1012 | 1014 | | |
1013 | 1015 | | |
1014 | 1016 | | |
1015 | | - | |
1016 | | - | |
| 1017 | + | |
1017 | 1018 | | |
1018 | 1019 | | |
1019 | 1020 | | |
| |||
1223 | 1224 | | |
1224 | 1225 | | |
1225 | 1226 | | |
| 1227 | + | |
1226 | 1228 | | |
1227 | 1229 | | |
1228 | 1230 | | |
1229 | | - | |
1230 | | - | |
| 1231 | + | |
1231 | 1232 | | |
1232 | 1233 | | |
1233 | 1234 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4280 | 4280 | | |
4281 | 4281 | | |
4282 | 4282 | | |
4283 | | - | |
4284 | | - | |
4285 | | - | |
4286 | | - | |
| 4283 | + | |
| 4284 | + | |
| 4285 | + | |
| 4286 | + | |
4287 | 4287 | | |
4288 | 4288 | | |
4289 | 4289 | | |
| |||
5786 | 5786 | | |
5787 | 5787 | | |
5788 | 5788 | | |
5789 | | - | |
| 5789 | + | |
| 5790 | + | |
5790 | 5791 | | |
5791 | 5792 | | |
5792 | 5793 | | |
| |||
0 commit comments