fix: replace hardcoded octave interval with dynamic temperament value

Author: Ashutoshx7

js/turtle-singer.js

@@ -42,6 +42,32 @@
 
 /* exported Singer */
 
+/**
+ * Gets the number of pitch intervals per octave for the current temperament.
+ * Defaults to 12 (standard Western tuning) if temperament is not set or not found.
+ * @param {Object} activity - The activity object containing synth information.
+ * @returns {number} The number of intervals per octave.
+ */
+const getOctaveInterval = activity => {
+    try {
+        if (!activity?.logo?.synth) {
+            return 12;
+        }
+        const temperamentName = activity.logo.synth.inTemperament;
+        if (!temperamentName) {
+            return 12;
+        }
+        const temperament = getTemperament(temperamentName);
+        if (temperament && typeof temperament.pitchNumber === "number") {
+            return temperament.pitchNumber;
+        }
+        return 12;
+    } catch (e) {
+        console.warn("getOctaveInterval: Error getting temperament, using default 12", e);
+        return 12;
+    }
+};
+
 /**
  * Class pertaining to music related actions for each turtle.
  *
@@ -1012,8 +1038,7 @@ class Singer {
                 noteObj = getNote(
                     anote,
                     octave,
-                    // FIXME: should not be hardwired to 12
-                    atrans + tur.singer.register * 12,
+                    atrans + tur.singer.register * getOctaveInterval(activity),
                     tur.singer.keySignature,
                     tur.singer.movable,
                     direction,
@@ -1226,8 +1251,7 @@ class Singer {
                 const noteObj = getNote(
                     note,
                     octave,
-                    // FIXME: should not be hardwired to 12
-                    transposition + tur.singer.register * 12,
+                    transposition + tur.singer.register * getOctaveInterval(activity),
                     tur.singer.keySignature,
                     tur.singer.movable,
                     direction,