remove unused code

Author: Assem-Uber

src/views/schedule-actions/__fixtures__/schedule-actions-config.tsx

@@ -29,9 +29,7 @@ export const mockPauseActionConfig: ScheduleAction<
   modal: {
     banner: {
       kind: 'warning',
-      icon: ({ size, color }) => (
-        <MdOutlineWarningAmber size={size} color={color} />
-      ),
+      icon: MdOutlineWarningAmber,
       render: () => 'Mock pause banner message',
     },
     withForm: true,

src/views/schedule-actions/config/schedule-actions-banner-icons.tsx

@@ -1,4 +1,8 @@
-import { MdPauseCircleOutline, MdPlayCircleOutline } from 'react-icons/md';
+import {
+  MdOutlineWarningAmber,
+  MdPauseCircleOutline,
+  MdPlayCircleOutline,
+} from 'react-icons/md';
 
 import { type PauseScheduleResponse } from '@/route-handlers/pause-schedule/pause-schedule.types';
 import { type UnpauseScheduleResponse } from '@/route-handlers/unpause-schedule/unpause-schedule.types';
@@ -18,8 +22,6 @@ import {
   type ScheduleAction,
 } from '../schedule-actions.types';
 
-import { pauseScheduleBannerIcon } from './schedule-actions-banner-icons';
-
 const pauseScheduleActionConfig: ScheduleAction<
   PauseScheduleResponse,
   PauseScheduleFormData,
@@ -31,7 +33,7 @@ const pauseScheduleActionConfig: ScheduleAction<
   modal: {
     banner: {
       kind: 'warning',
-      icon: pauseScheduleBannerIcon,
+      icon: MdOutlineWarningAmber,
       render: () =>
         'Pausing stops new executions but does not stop workflows already in progress.',
     },

src/views/schedule-actions/config/schedule-actions.config.ts

@@ -0,0 +1,11 @@
+import {
+  type ExplicitResumeCatchUpPolicy,
+  type ResumeCatchUpPolicyOptionId,
+  USE_SCHEDULE_CATCH_UP_POLICY,
+} from '../schedule-action-resume-form.constants';
+
+export default function isExplicitCatchUpPolicy(
+  value: ResumeCatchUpPolicyOptionId | undefined
+): value is ExplicitResumeCatchUpPolicy {
+  return value !== undefined && value !== USE_SCHEDULE_CATCH_UP_POLICY;
+}

src/views/schedule-actions/schedule-action-resume-form/helpers/is-explicit-catch-up-policy.ts

@@ -1,18 +1,20 @@
-import { isExplicitCatchUpPolicy } from '../schedule-action-resume-form.constants';
 import {
   type ResumeScheduleFormData,
   type ResumeScheduleSubmissionData,
 } from '../schedule-action-resume-form.types';
 
+import isExplicitCatchUpPolicy from './is-explicit-catch-up-policy';
+
 export default function transformResumeScheduleFormToSubmission(
   formData: ResumeScheduleFormData
 ): ResumeScheduleSubmissionData {
-  const reason = formData.reason?.trim();
+  const reason = formData.reason?.trim() || undefined;
+  const catchUpPolicy = isExplicitCatchUpPolicy(formData.catchUpPolicy)
+    ? formData.catchUpPolicy
+    : undefined;
 
   return {
-    ...(reason ? { reason } : {}),
-    ...(isExplicitCatchUpPolicy(formData.catchUpPolicy)
-      ? { catchUpPolicy: formData.catchUpPolicy }
-      : {}),
+    reason,
+    catchUpPolicy,
   };
 }

src/views/schedule-actions/schedule-action-resume-form/helpers/transform-resume-schedule-form-to-submission.ts

@@ -3,8 +3,6 @@ import { SCHEDULE_CATCH_UP_POLICY_LABELS } from '@/views/shared/constants/schedu
 
 export const USE_SCHEDULE_CATCH_UP_POLICY = 'USE_SCHEDULE_POLICY' as const;
 
-export const DEFAULT_RESUME_CATCH_UP_POLICY = USE_SCHEDULE_CATCH_UP_POLICY;
-
 export const SCHEDULE_ACTION_RESUME_FORM_FIELD_IDS = {
   reason: 'schedule-action-resume-reason',
 } as const;
@@ -25,8 +23,3 @@ export type ResumeCatchUpPolicyOptionId =
 
 export type ExplicitResumeCatchUpPolicy =
   (typeof SCHEDULE_CATCH_UP_POLICIES)[number];
-
-export const isExplicitCatchUpPolicy = (
-  value: ResumeCatchUpPolicyOptionId | undefined
-): value is ExplicitResumeCatchUpPolicy =>
-  value !== undefined && value !== USE_SCHEDULE_CATCH_UP_POLICY;

src/views/schedule-actions/schedule-action-resume-form/schedule-action-resume-form.constants.ts

@@ -7,9 +7,9 @@ import { RESUME_SCHEDULE_FORM_FIELD_DESCRIPTIONS } from '@/views/schedule-action
 import getFieldErrorMessage from '@/views/workflow-actions/workflow-action-start-form/helpers/get-field-error-message';
 
 import {
-  DEFAULT_RESUME_CATCH_UP_POLICY,
   RESUME_CATCH_UP_POLICY_OPTIONS,
   SCHEDULE_ACTION_RESUME_FORM_FIELD_IDS,
+  USE_SCHEDULE_CATCH_UP_POLICY,
 } from './schedule-action-resume-form.constants';
 import { type Props } from './schedule-action-resume-form.types';
 
@@ -27,7 +27,7 @@ export default function ScheduleActionResumeForm({
         <Controller
           name="catchUpPolicy"
           control={control}
-          defaultValue={DEFAULT_RESUME_CATCH_UP_POLICY}
+          defaultValue={USE_SCHEDULE_CATCH_UP_POLICY}
           render={({ field: { value, onChange, ref, ...field } }) => (
             <RadioGroup
               {...field}

src/views/schedule-actions/schedule-action-resume-form/schedule-action-resume-form.tsx

@@ -142,28 +142,6 @@ describe(ScheduleActionsModalContent.name, () => {
       );
     });
   });
-
-  it('calls resume API with default submission when confirmed', async () => {
-    const { user, mockOnClose, getLatestRequestBody, waitForRequest } = setup({
-      actionConfig: mockScheduleActionsConfig[1],
-    });
-
-    await user.click(
-      await screen.findByRole('button', { name: 'Mock resume schedule' })
-    );
-
-    await waitForRequest();
-    expect(getLatestRequestBody()).toEqual({});
-
-    await waitFor(() => {
-      expect(mockEnqueue).toHaveBeenCalledWith(
-        expect.objectContaining({
-          message: 'Mock resume notification',
-        })
-      );
-    });
-    expect(mockOnClose).toHaveBeenCalled();
-  });
 });
 
 function setup({