memo and json

Author: Assem-Uber

src/views/schedule-details/__fixtures__/schedule-details-sections-config.ts

@@ -11,15 +11,15 @@ export const mockScheduleDetailsSectionsConfig: ScheduleDetailsSectionConfig[] =
         {
           key: 'primary',
           getLabel: () => 'Primary row',
-          getValue: ({ describeSchedule }) =>
-            describeSchedule.policies?.overlapPolicy,
+          getValue: ({ formattedScheduleDetails: { policies } }) =>
+            policies?.overlapPolicy,
         },
         {
           key: 'conditional',
           getLabel: () => 'Conditional row',
           getValue: () => 'conditional-value',
-          hide: ({ describeSchedule }) =>
-            describeSchedule.policies?.overlapPolicy !==
+          hide: ({ formattedScheduleDetails: { policies } }) =>
+            policies?.overlapPolicy !==
             ScheduleOverlapPolicy.SCHEDULE_OVERLAP_POLICY_BUFFER,
         },
       ],

src/views/schedule-details/config/schedule-policies-details.config.ts

@@ -14,45 +14,45 @@ const schedulePoliciesDetailsConfig: ScheduleDetailRowConfig[] = [
   {
     key: 'overlapPolicy',
     getLabel: () => 'Overlap policy',
-    getValue: ({ describeSchedule }) =>
+    getValue: ({ formattedScheduleDetails: { policies } }) =>
       formatScheduleEnumWithDefault(
-        describeSchedule.policies?.overlapPolicy,
+        policies?.overlapPolicy,
         SCHEDULE_OVERLAP_POLICY_LABELS,
         SERVER_OVERLAP_POLICY_DEFAULT
       ),
   },
   {
     key: 'catchUpPolicy',
     getLabel: () => 'Catchup policy',
-    getValue: ({ describeSchedule }) =>
+    getValue: ({ formattedScheduleDetails: { policies } }) =>
       formatScheduleEnumWithDefault(
-        describeSchedule.policies?.catchUpPolicy,
+        policies?.catchUpPolicy,
         SCHEDULE_CATCH_UP_POLICY_LABELS,
         SERVER_CATCH_UP_POLICY_DEFAULT
       ),
   },
   {
     key: 'pauseOnFailure',
     getLabel: () => 'Pause on failure',
-    getValue: ({ describeSchedule }) =>
-      describeSchedule.policies?.pauseOnFailure ? 'Yes' : 'No',
+    getValue: ({ formattedScheduleDetails: { policies } }) =>
+      policies?.pauseOnFailure ? 'Yes' : 'No',
   },
   {
     key: 'bufferLimit',
     getLabel: () => 'Buffer limit',
-    getValue: ({ describeSchedule }) =>
-      formatScheduleLimitValue(describeSchedule.policies?.bufferLimit),
-    hide: ({ describeSchedule }) =>
-      describeSchedule.policies?.overlapPolicy !==
+    getValue: ({ formattedScheduleDetails: { policies } }) =>
+      formatScheduleLimitValue(policies?.bufferLimit),
+    hide: ({ formattedScheduleDetails: { policies } }) =>
+      policies?.overlapPolicy !==
       ScheduleOverlapPolicy.SCHEDULE_OVERLAP_POLICY_BUFFER,
   },
   {
     key: 'concurrencyLimit',
     getLabel: () => 'Concurrency limit',
-    getValue: ({ describeSchedule }) =>
-      formatScheduleLimitValue(describeSchedule.policies?.concurrencyLimit),
-    hide: ({ describeSchedule }) =>
-      describeSchedule.policies?.overlapPolicy !==
+    getValue: ({ formattedScheduleDetails: { policies } }) =>
+      formatScheduleLimitValue(policies?.concurrencyLimit),
+    hide: ({ formattedScheduleDetails: { policies } }) =>
+      policies?.overlapPolicy !==
       ScheduleOverlapPolicy.SCHEDULE_OVERLAP_POLICY_CONCURRENT,
   },
 ];

src/views/schedule-details/config/schedule-specifications-details.config.ts

@@ -3,7 +3,7 @@ import { createElement } from 'react';
 import { type ScheduleDetailRowConfig } from '@/views/schedule-details/schedule-details.types';
 
 import ScheduleDetailsBadges from '../schedule-details-badges/schedule-details-badges';
-import ScheduleDetailsMemo from '../schedule-details-memo/schedule-details-memo';
+import ScheduleDetailsJsonView from '../schedule-details-json-view/schedule-details-json-view';
 import { formatScheduleCronExpression } from '../helpers/format-schedule-cron-expression';
 import { formatScheduleDuration } from '../helpers/format-schedule-duration';
 import { formatScheduleTimestamp } from '../helpers/format-schedule-timestamp';
@@ -17,26 +17,26 @@ const scheduleSpecificationsDetailsConfig: ScheduleDetailRowConfig[] = [
   {
     key: 'cronExpression',
     getLabel: () => 'Cron execution',
-    getValue: ({ describeSchedule }) =>
-      formatScheduleCronExpression(describeSchedule.spec?.cronExpression),
+    getValue: ({ formattedScheduleDetails: { spec } }) =>
+      formatScheduleCronExpression(spec?.cronExpression),
   },
   {
     key: 'nextRunTime',
     getLabel: () => 'Next run',
-    getValue: ({ describeSchedule }) =>
-      formatScheduleTimestamp(describeSchedule.info?.nextRunTime),
+    getValue: ({ formattedScheduleDetails: { info } }) =>
+      formatScheduleTimestamp(info?.nextRunTime),
   },
   {
     key: 'lastRunTime',
     getLabel: () => 'Last run',
-    getValue: ({ describeSchedule }) =>
-      formatScheduleTimestamp(describeSchedule.info?.lastRunTime),
+    getValue: ({ formattedScheduleDetails: { info } }) =>
+      formatScheduleTimestamp(info?.lastRunTime),
   },
   {
     key: 'totalRuns',
     getLabel: () => 'Total runs',
-    getValue: ({ describeSchedule }) => {
-      const total = describeSchedule.info?.totalRuns || '0';
+    getValue: ({ formattedScheduleDetails: { info } }) => {
+      const total = info?.totalRuns || '0';
       return createElement(ScheduleDetailsBadges, {
         labels: [`${total} runs`],
       });
@@ -45,38 +45,41 @@ const scheduleSpecificationsDetailsConfig: ScheduleDetailRowConfig[] = [
   {
     key: 'createTime',
     getLabel: () => 'Creation time',
-    getValue: ({ describeSchedule }) =>
-      formatScheduleTimestamp(describeSchedule.info?.createTime),
-    hide: ({ describeSchedule }) => !describeSchedule.info?.createTime,
+    getValue: ({ formattedScheduleDetails: { info } }) =>
+      formatScheduleTimestamp(info?.createTime),
+    hide: ({ formattedScheduleDetails: { info } }) => !info?.createTime,
   },
   {
     key: 'startTime',
     getLabel: () => 'Start time',
-    getValue: ({ describeSchedule }) =>
-      formatScheduleTimestamp(describeSchedule.spec?.startTime),
-    hide: ({ describeSchedule }) => !describeSchedule.spec?.startTime,
+    getValue: ({ formattedScheduleDetails: { spec } }) =>
+      formatScheduleTimestamp(spec?.startTime),
+    hide: ({ formattedScheduleDetails: { spec } }) => !spec?.startTime,
   },
   {
     key: 'endTime',
     getLabel: () => 'End time',
-    getValue: ({ describeSchedule }) =>
-      formatScheduleTimestamp(describeSchedule.spec?.endTime),
-    hide: ({ describeSchedule }) => !describeSchedule.spec?.endTime,
+    getValue: ({ formattedScheduleDetails: { spec } }) =>
+      formatScheduleTimestamp(spec?.endTime),
+    hide: ({ formattedScheduleDetails: { spec } }) => !spec?.endTime,
   },
   {
     key: 'memo',
     getLabel: () => 'Memo',
-    getValue: ({ describeSchedule }) =>
-      createElement(ScheduleDetailsMemo, { memo: describeSchedule.memo }),
-    hide: ({ describeSchedule }) => !describeSchedule.memo?.fields,
+    getValue: ({ formattedScheduleDetails: { action } }) =>
+      createElement(ScheduleDetailsJsonView, {
+        json: action?.startWorkflow?.memo?.fields ?? null,
+      }),
+    hide: ({ formattedScheduleDetails: { action } }) =>
+      !action?.startWorkflow?.memo?.fields,
   },
 
   {
     key: 'jitter',
     getLabel: () => 'Jitter duration',
-    getValue: ({ describeSchedule }) =>
-      formatScheduleDuration(describeSchedule.spec?.jitter),
-    hide: ({ describeSchedule }) => !describeSchedule.spec?.jitter,
+    getValue: ({ formattedScheduleDetails: { spec } }) =>
+      formatScheduleDuration(spec?.jitter),
+    hide: ({ formattedScheduleDetails: { spec } }) => !spec?.jitter,
   },
 ];
 

src/views/schedule-details/helpers/__tests__/format-schedule-details.test.ts

@@ -0,0 +1,63 @@
+import { getMockRunningDescribeScheduleResponse } from '@/route-handlers/describe-schedule/__fixtures__/mock-describe-schedule-response';
+
+import { formatScheduleDetails } from '../format-schedule-details';
+
+describe(formatScheduleDetails.name, () => {
+  it('formats workflow input and memo fields in place', () => {
+    const describeSchedule = getMockRunningDescribeScheduleResponse({
+      action: {
+        startWorkflow: {
+          workflowType: { name: 'ScheduleWorker' },
+          taskList: {
+            name: 'schedule-task-list',
+            kind: 'TASK_LIST_KIND_NORMAL',
+            baseName: 'schedule-task-list',
+          },
+          input: {
+            data: 'eyJ3b3JrZmxvd0FyZyI6InRlc3QtdmFsdWUifQ==',
+          },
+          workflowIdPrefix: 'schedule-prefix',
+          executionStartToCloseTimeout: null,
+          taskStartToCloseTimeout: null,
+          retryPolicy: null,
+          memo: {
+            fields: {
+              owner: { data: 'ImVuZy1sZWFkIg==' },
+            },
+          },
+          searchAttributes: null,
+        },
+      },
+      memo: {
+        fields: {
+          team: { data: 'ImNhZGVuY2Ui' },
+          note: { data: 'dGVzdC1ub3Rl' },
+        },
+      },
+    });
+
+    const { memo: _scheduleMemo, ...scheduleWithoutMemo } = describeSchedule;
+
+    expect(formatScheduleDetails(describeSchedule)).toEqual({
+      ...scheduleWithoutMemo,
+      action: {
+        ...describeSchedule.action,
+        startWorkflow: {
+          ...describeSchedule.action!.startWorkflow!,
+          input: [{ workflowArg: 'test-value' }],
+          memo: { fields: { owner: 'eng-lead' } },
+        },
+      },
+    });
+  });
+
+  it('omits root memo when action is absent', () => {
+    const describeSchedule = getMockRunningDescribeScheduleResponse();
+    const { memo: _scheduleMemo, ...scheduleWithoutMemo } = describeSchedule;
+
+    expect(formatScheduleDetails(describeSchedule)).toEqual({
+      ...scheduleWithoutMemo,
+      action: null,
+    });
+  });
+});

src/views/schedule-details/helpers/__tests__/get-rows-from-config.test.ts

@@ -3,6 +3,7 @@ import { getMockRunningDescribeScheduleResponse } from '@/route-handlers/describ
 import { type DescribeScheduleResponse } from '@/route-handlers/describe-schedule/describe-schedule.types';
 
 import { type ScheduleDetailRowConfig } from '../../schedule-details.types';
+import { formatScheduleDetails } from '../format-schedule-details';
 import { getRowsFromConfig } from '../get-rows-from-config';
 
 describe(getRowsFromConfig.name, () => {
@@ -12,6 +13,7 @@ describe(getRowsFromConfig.name, () => {
     },
   } as Partial<DescribeScheduleResponse>);
   const scheduleId = 'my-schedule';
+  const formattedScheduleDetails = formatScheduleDetails(describeSchedule);
 
   it('maps row config to table rows', () => {
     const config: ScheduleDetailRowConfig[] = [
@@ -22,7 +24,9 @@ describe(getRowsFromConfig.name, () => {
       },
     ];
 
-    expect(getRowsFromConfig(config, describeSchedule, scheduleId)).toEqual([
+    expect(
+      getRowsFromConfig(config, formattedScheduleDetails, scheduleId)
+    ).toEqual([
       { key: 'overlap', label: 'Overlap', value: 'my-schedule-value' },
     ]);
   });
@@ -42,27 +46,24 @@ describe(getRowsFromConfig.name, () => {
       },
     ];
 
-    expect(getRowsFromConfig(config, describeSchedule, scheduleId)).toEqual([
-      { key: 'visible', label: 'Visible', value: 'shown' },
-    ]);
+    expect(
+      getRowsFromConfig(config, formattedScheduleDetails, scheduleId)
+    ).toEqual([{ key: 'visible', label: 'Visible', value: 'shown' }]);
   });
 
-  it('passes describeSchedule and scheduleId to hide predicate', () => {
+  it('passes formatted schedule details to hide predicate', () => {
+    const hide = jest.fn(() => false);
     const config: ScheduleDetailRowConfig[] = [
       {
         key: 'conditional',
         getLabel: () => 'Conditional',
         getValue: () => 'value',
-        hide: ({ describeSchedule: data, scheduleId: id }) =>
-          data.policies?.overlapPolicy !==
-            ScheduleOverlapPolicy.SCHEDULE_OVERLAP_POLICY_BUFFER ||
-          id !== 'my-schedule',
+        hide,
       },
     ];
 
-    expect(getRowsFromConfig(config, describeSchedule, scheduleId)).toEqual([
-      { key: 'conditional', label: 'Conditional', value: 'value' },
-    ]);
-    expect(getRowsFromConfig(config, describeSchedule, 'other-id')).toEqual([]);
+    getRowsFromConfig(config, formattedScheduleDetails, scheduleId);
+
+    expect(hide).toHaveBeenCalledWith({ formattedScheduleDetails, scheduleId });
   });
 });

src/views/schedule-details/helpers/format-schedule-details.ts

@@ -0,0 +1,29 @@
+import formatInputPayload from '@/utils/data-formatters/format-input-payload';
+import formatPayloadMap from '@/utils/data-formatters/format-payload-map';
+import { type DescribeScheduleResponse } from '@/views/shared/hooks/use-describe-schedule/use-describe-schedule.types';
+
+import { type FormattedScheduleDetails } from '../schedule-details.types';
+
+export function formatScheduleDetails(
+  describeSchedule: DescribeScheduleResponse
+): FormattedScheduleDetails {
+  const { memo: _scheduleMemo, action, ...scheduleWithoutMemo } =
+    describeSchedule;
+  const startWorkflow = action?.startWorkflow;
+
+  return {
+    ...scheduleWithoutMemo,
+    action: action
+      ? {
+          ...action,
+          startWorkflow: startWorkflow
+            ? {
+                ...startWorkflow,
+                input: formatInputPayload(startWorkflow.input),
+                memo: formatPayloadMap(startWorkflow.memo, 'fields'),
+              }
+            : startWorkflow,
+        }
+      : action,
+  } as FormattedScheduleDetails;
+}

src/views/schedule-details/helpers/get-rows-from-config.ts

@@ -2,20 +2,18 @@ import { type ScheduleDetailsTableRow } from '@/views/schedule-details/schedule-
 
 import {
   type ScheduleDetailRowConfig,
-  type ScheduleDetailRowArgs,
+  type FormattedScheduleDetails,
 } from '../schedule-details.types';
 
 export function getRowsFromConfig(
   config: ScheduleDetailRowConfig[],
-  data: ScheduleDetailRowArgs['describeSchedule'],
+  formattedScheduleDetails: FormattedScheduleDetails,
   scheduleId: string
 ): ScheduleDetailsTableRow[] {
-  const args = { describeSchedule: data, scheduleId };
+  const args = { formattedScheduleDetails, scheduleId };
   return config
     .filter(
-      (rowConfig) =>
-        !rowConfig.hide ||
-        !rowConfig.hide({ describeSchedule: data, scheduleId })
+      (rowConfig) => !rowConfig.hide || !rowConfig.hide(args)
     )
     .map((rowConfig) => ({
       key: rowConfig.key,