fix(api): use DELETE on schedule resource with no request body

Delete schedule is a body-less resource deletion — wire it as DELETE
on the schedule route instead of POST on a separate /delete action path.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: Assem-Uber

src/app/api/domains/[domain]/[cluster]/schedules/[scheduleId]/(actions)/delete/route.ts

@@ -1,5 +1,6 @@
 import { type NextRequest } from 'next/server';
 
+import { deleteSchedule } from '@/route-handlers/delete-schedule/delete-schedule';
 import { describeSchedule } from '@/route-handlers/describe-schedule/describe-schedule';
 import { type RouteParams } from '@/route-handlers/describe-schedule/describe-schedule.types';
 import { routeHandlerWithMiddlewares } from '@/utils/route-handlers-middleware';
@@ -16,3 +17,15 @@ export async function GET(
     routeHandlersDefaultMiddlewares
   );
 }
+
+export async function DELETE(
+  request: NextRequest,
+  options: { params: RouteParams }
+) {
+  return routeHandlerWithMiddlewares(
+    deleteSchedule,
+    request,
+    options,
+    routeHandlersDefaultMiddlewares
+  );
+}

src/app/api/domains/[domain]/[cluster]/schedules/[scheduleId]/route.ts

@@ -24,15 +24,6 @@ describe(deleteSchedule.name, () => {
     expect(await res.json()).toEqual({});
   });
 
-  it('accepts an empty request body', async () => {
-    const { res, mockDeleteSchedule } = await setup({
-      requestBody: JSON.stringify({}),
-    });
-
-    expect(mockDeleteSchedule).toHaveBeenCalled();
-    expect(res.status).toEqual(200);
-  });
-
   it('returns an error if deleteSchedule throws a GRPCError (not found)', async () => {
     const { res, mockDeleteSchedule } = await setup({
       error: new GRPCError('Schedule not found', {
@@ -78,23 +69,12 @@ describe(deleteSchedule.name, () => {
       })
     );
   });
-
-  it('treats malformed JSON body as empty object', async () => {
-    const { res, mockDeleteSchedule } = await setup({
-      requestBody: 'not-json',
-    });
-
-    expect(mockDeleteSchedule).toHaveBeenCalled();
-    expect(res.status).toEqual(200);
-  });
 });
 
 async function setup({
-  requestBody = null,
   scheduleId = 'mock-schedule-id',
   error,
 }: {
-  requestBody?: string | null;
   scheduleId?: string;
   error?: Error;
 }) {
@@ -108,10 +88,7 @@ async function setup({
     });
 
   const res = await deleteSchedule(
-    new NextRequest('http://localhost', {
-      method: 'POST',
-      ...(requestBody === null ? {} : { body: requestBody }),
-    }),
+    new NextRequest('http://localhost', { method: 'DELETE' }),
     {
       params: {
         domain: 'mock-domain',

src/route-handlers/delete-schedule/__tests__/delete-schedule.node.ts

@@ -3,31 +3,17 @@ import { type NextRequest, NextResponse } from 'next/server';
 import { getHTTPStatusCode, GRPCError } from '@/utils/grpc/grpc-error';
 import logger, { type RouteHandlerErrorPayload } from '@/utils/logger';
 
-import deleteScheduleRequestBodySchema from './schemas/delete-schedule-request-body-schema';
 import {
   type Context,
   type DeleteScheduleResponse,
   type RequestParams,
 } from './delete-schedule.types';
 
 export async function deleteSchedule(
-  request: NextRequest,
+  _: NextRequest,
   requestParams: RequestParams,
   ctx: Context
 ) {
-  const requestBody = await request.json().catch(() => ({}));
-  const { error } = deleteScheduleRequestBodySchema.safeParse(requestBody);
-
-  if (error) {
-    return NextResponse.json(
-      {
-        message: 'Invalid values provided for schedule deletion',
-        validationErrors: error.errors,
-      },
-      { status: 400 }
-    );
-  }
-
   const params = requestParams.params;
 
   try {