fix coverage

Author: Assem-Uber

src/views/domain-schedules/domain-schedules-create-advanced-form/__tests__/domain-schedules-create-advanced-form.test.tsx

@@ -116,18 +116,40 @@ describe(DomainSchedulesCreateAdvancedForm.name, () => {
     await user.click(screen.getByRole('radio', { name: 'Skip' }));
     expect(screen.queryByLabelText('Catch-up window')).not.toBeInTheDocument();
   });
+
+  it('clears schedule id and workflow id prefix when inputs are emptied', async () => {
+    const { user, getValues } = setup();
+
+    await user.click(
+      screen.getByRole('button', { name: /show advanced configurations/i })
+    );
+
+    const scheduleId = screen.getByLabelText('Schedule Id');
+    await user.type(scheduleId, 'my-schedule');
+    await user.clear(scheduleId);
+    expect(getValues().scheduleId).toBeUndefined();
+
+    const workflowIdPrefix = screen.getByLabelText('Workflow Id Prefix');
+    await user.type(workflowIdPrefix, 'prefix');
+    await user.clear(workflowIdPrefix);
+    expect(getValues().workflowIdPrefix).toBeUndefined();
+  });
 });
 
 function setup() {
   const user = userEvent.setup();
+  let getValues: () => DomainSchedulesCreateFormData;
 
   function Wrapper() {
     const {
       control,
+      getValues: readValues,
       formState: { errors: fieldErrors },
     } = useForm<DomainSchedulesCreateFormData>({
       defaultValues: {},
     });
+    getValues = readValues;
+
     return (
       <DomainSchedulesCreateAdvancedForm
         control={control}
@@ -137,5 +159,5 @@ function setup() {
   }
 
   render(<Wrapper />);
-  return { user };
+  return { user, getValues: () => getValues() };
 }

src/views/domain-schedules/domain-schedules-create-modal/__tests__/transform-domain-schedules-create-form-to-body.test.ts

@@ -134,4 +134,26 @@ describe(transformDomainSchedulesCreateFormToBody.name, () => {
     );
     expect(result.catchUpWindowSeconds).toBeUndefined();
   });
+
+  it('omits catchUpPolicy when not set on form data', () => {
+    const result = transformDomainSchedulesCreateFormToBody(baseForm);
+
+    expect(result.catchUpPolicy).toBeUndefined();
+  });
+
+  it('omits buffer and concurrency limits when limit strings are empty', () => {
+    const bufferResult = transformDomainSchedulesCreateFormToBody({
+      ...baseForm,
+      overlapPolicy: ScheduleOverlapPolicy.SCHEDULE_OVERLAP_POLICY_BUFFER,
+      bufferLimit: '',
+    });
+    expect(bufferResult.bufferLimit).toBeUndefined();
+
+    const concurrentResult = transformDomainSchedulesCreateFormToBody({
+      ...baseForm,
+      overlapPolicy: ScheduleOverlapPolicy.SCHEDULE_OVERLAP_POLICY_CONCURRENT,
+      concurrencyLimit: '',
+    });
+    expect(concurrentResult.concurrencyLimit).toBeUndefined();
+  });
 });