Skip to content

Commit d9fba97

Browse files
committed
chore: clean up
1 parent 7cd582d commit d9fba97

4 files changed

Lines changed: 21 additions & 75 deletions

File tree

src/module.ts

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3899,17 +3899,19 @@ function prepareType(builder: binaryen.TypeBuilderRef, seen: Map<Type,HeapTypeRe
38993899
if (DEBUG_TYPEBUILDER) {
39003900
console.log(` field ${fieldType.toString()}`);
39013901
}
3902-
fieldTypes.push(
3903-
fieldType.is(TypeFlags.Nullable)
3904-
? binaryen._TypeBuilderGetTempRefType(
3905-
builder,
3906-
binaryen._BinaryenTypeGetHeapType(
3907-
prepareType(builder, seen, fieldType.nonNullableType)
3908-
),
3909-
true
3910-
)
3911-
: prepareType(builder, seen, fieldType)
3912-
);
3902+
if (fieldType.is(TypeFlags.Nullable)) {
3903+
fieldTypes.push(
3904+
binaryen._TypeBuilderGetTempRefType(
3905+
builder,
3906+
binaryen._BinaryenTypeGetHeapType(
3907+
prepareType(builder, seen, fieldType.nonNullableType)
3908+
),
3909+
true
3910+
)
3911+
);
3912+
} else {
3913+
fieldTypes.push(prepareType(builder, seen, fieldType));
3914+
}
39133915
packedTypes.push(determinePackedType(fieldType));
39143916
fieldMutables.push(1);
39153917
}

src/parser.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -610,13 +610,7 @@ export class Parser extends DiagnosticEmitter {
610610
return null;
611611
}
612612
}
613-
type = Node.createTupleType(
614-
elements,
615-
hasElementNames ? elementNames : null,
616-
false,
617-
tn.range(startPos, tn.pos),
618-
false
619-
);
613+
type = Node.createTupleType(elements, hasElementNames ? elementNames : null, false, tn.range(startPos, tn.pos), false);
620614

621615
// 'void'
622616
} else if (token == Token.Void) {

src/resolver.ts

Lines changed: 6 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -447,34 +447,14 @@ export class Resolver extends DiagnosticEmitter {
447447
} else {
448448
if (returnTypeNode.kind == NodeKind.TupleType && (<TupleTypeNode>returnTypeNode).isReadonly) {
449449
returnType = Type.void;
450-
returnTypes = this.resolveMultiValueReturnTypes(
451-
<TupleTypeNode>returnTypeNode,
452-
flow,
453-
ctxElement,
454-
ctxTypes,
455-
reportMode
456-
);
450+
returnTypes = this.resolveMultiValueReturnTypes(<TupleTypeNode>returnTypeNode, flow, ctxElement, ctxTypes, reportMode);
457451
if (!returnTypes) return null;
458452
} else {
459-
returnType = this.resolveType(
460-
returnTypeNode,
461-
flow,
462-
ctxElement,
463-
ctxTypes,
464-
reportMode
465-
);
453+
returnType = this.resolveType(returnTypeNode, flow, ctxElement, ctxTypes, reportMode);
466454
}
467455
if (!returnType) return null;
468456
}
469-
let signature = Signature.create(
470-
this.program,
471-
parameterTypes,
472-
returnType,
473-
thisType,
474-
requiredParameters,
475-
hasRest,
476-
returnTypes
477-
);
457+
let signature = Signature.create(this.program, parameterTypes, returnType, thisType, requiredParameters, hasRest, returnTypes);
478458
return node.isNullable ? signature.type.asNullable() : signature.type;
479459
}
480460

@@ -2998,36 +2978,16 @@ export class Resolver extends DiagnosticEmitter {
29982978
}
29992979
if (typeNode.kind == NodeKind.TupleType && (<TupleTypeNode>typeNode).isReadonly) {
30002980
returnType = Type.void;
3001-
returnTypes = this.resolveMultiValueReturnTypes(
3002-
<TupleTypeNode>typeNode,
3003-
null,
3004-
prototype.parent,
3005-
ctxTypes,
3006-
reportMode
3007-
);
2981+
returnTypes = this.resolveMultiValueReturnTypes(<TupleTypeNode>typeNode, null, prototype.parent, ctxTypes, reportMode);
30082982
if (!returnTypes) return null;
30092983
} else {
3010-
let type = this.resolveType(
3011-
typeNode,
3012-
null,
3013-
prototype.parent, // relative to function
3014-
ctxTypes,
3015-
reportMode
3016-
);
2984+
let type = this.resolveType(typeNode, null, prototype.parent, ctxTypes, reportMode);
30172985
if (!type) return null;
30182986
returnType = type;
30192987
}
30202988
}
30212989

3022-
let signature = Signature.create(
3023-
this.program,
3024-
parameterTypes,
3025-
returnType,
3026-
thisType,
3027-
requiredParameters,
3028-
hasRest,
3029-
returnTypes
3030-
);
2990+
let signature = Signature.create(this.program, parameterTypes, returnType, thisType, requiredParameters, hasRest, returnTypes);
30312991

30322992
let nameInclTypeParameters = prototype.name;
30332993
if (instanceKey.length) nameInclTypeParameters += `<${instanceKey}>`;

src/types.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -962,17 +962,7 @@ export class Signature {
962962
let nextId = program.nextSignatureId;
963963

964964
// construct the signature and calculate it's unique key
965-
let signature = new Signature(
966-
program,
967-
parameterTypes,
968-
returnType,
969-
thisType,
970-
requiredParameters,
971-
hasRest,
972-
nextId,
973-
type,
974-
returnTypes
975-
);
965+
let signature = new Signature(program, parameterTypes, returnType, thisType, requiredParameters, hasRest, nextId, type, returnTypes );
976966
let uniqueKey = signature.toString();
977967

978968
// check if it exists, and return it

0 commit comments

Comments
 (0)