fix: clear unavailable sandbox booter config

Author: zouyonghe

astrbot/dashboard/routes/config.py

@@ -285,6 +285,22 @@ def _protected_2fa_config_changed(old_config: dict, new_config: dict) -> bool:
     )
 
 
+def _normalize_unavailable_sandbox_booter(config: dict) -> dict:
+    sandbox = config.get("provider_settings", {}).get("sandbox", {})
+    if not isinstance(sandbox, dict):
+        return config
+    booter = str(sandbox.get("booter") or "").strip()
+    if not booter:
+        return config
+    provider_ids = {
+        str(provider.get("provider_id") or "")
+        for provider in computer_client.list_sandbox_providers()
+    }
+    if booter not in provider_ids:
+        sandbox["booter"] = ""
+    return config
+
+
 async def _validate_neo_connectivity(
     post_config: dict,
 ) -> str | None:
@@ -629,7 +645,8 @@ async def get_default_config(self):
         metadata = ConfigMetadataI18n.convert_to_i18n_keys(
             self._inject_sandbox_provider_options(copy.deepcopy(CONFIG_METADATA_3))
         )
-        return Response().ok({"config": DEFAULT_CONFIG, "metadata": metadata}).__dict__
+        config = _normalize_unavailable_sandbox_booter(copy.deepcopy(DEFAULT_CONFIG))
+        return Response().ok({"config": config, "metadata": metadata}).__dict__
 
     async def get_abconf_list(self):
         """获取所有 AstrBot 配置文件的列表"""
@@ -660,7 +677,9 @@ async def get_abconf(self):
 
         try:
             if system_config:
-                abconf = self.acm.confs["default"]
+                abconf = _normalize_unavailable_sandbox_booter(
+                    copy.deepcopy(dict(self.acm.confs["default"]))
+                )
                 metadata = ConfigMetadataI18n.convert_to_i18n_keys(
                     self._inject_sandbox_provider_options(
                         copy.deepcopy(CONFIG_METADATA_3_SYSTEM)
@@ -669,7 +688,9 @@ async def get_abconf(self):
                 return Response().ok({"config": abconf, "metadata": metadata}).__dict__
             if abconf_id is None:
                 raise ValueError("abconf_id cannot be None")
-            abconf = self.acm.confs[abconf_id]
+            abconf = _normalize_unavailable_sandbox_booter(
+                copy.deepcopy(dict(self.acm.confs[abconf_id]))
+            )
             metadata = ConfigMetadataI18n.convert_to_i18n_keys(
                 self._inject_sandbox_provider_options(copy.deepcopy(CONFIG_METADATA_3))
             )
@@ -1086,6 +1107,8 @@ async def post_astrbot_configs(self):
                     config, ("dashboard", "totp", "recovery_code_hash"), ""
                 )
 
+            _normalize_unavailable_sandbox_booter(config)
+
             set_pending_totp_secret(None)
             await self._save_astrbot_configs(config, conf_id)
             if protected_2fa_changed:

tests/test_dashboard.py

@@ -480,6 +480,79 @@ async def test_config_metadata_includes_registered_sandbox_providers(
     assert "dashboard-generic" in metadata_text
 
 
+@pytest.mark.asyncio
+async def test_config_abconf_clears_unavailable_sandbox_booter_for_display(
+    app: Quart,
+    authenticated_header: dict,
+    monkeypatch: pytest.MonkeyPatch,
+    core_lifecycle_td: AstrBotCoreLifecycle,
+):
+    from astrbot.core.computer import computer_client
+    from astrbot.core.computer.sandbox_manager import SandboxManager
+    from astrbot.core.computer.sandbox_registry import SandboxRegistry
+
+    manager = SandboxManager(registry=SandboxRegistry(), providers={})
+    monkeypatch.setattr(computer_client, "sandbox_manager", manager)
+    original_booter = core_lifecycle_td.astrbot_config["provider_settings"][
+        "sandbox"
+    ].get("booter")
+    core_lifecycle_td.astrbot_config["provider_settings"]["sandbox"]["booter"] = (
+        "shipyard"
+    )
+
+    try:
+        test_client = app.test_client()
+        response = await test_client.get(
+            "/api/config/abconf?id=default", headers=authenticated_header
+        )
+        data = await response.get_json()
+
+        assert response.status_code == 200
+        assert data["status"] == "ok"
+        assert data["data"]["config"]["provider_settings"]["sandbox"]["booter"] == ""
+    finally:
+        core_lifecycle_td.astrbot_config["provider_settings"]["sandbox"]["booter"] = (
+            original_booter
+        )
+
+
+@pytest.mark.asyncio
+async def test_config_save_clears_unavailable_sandbox_booter(
+    app: Quart,
+    authenticated_header: dict,
+    monkeypatch: pytest.MonkeyPatch,
+    core_lifecycle_td: AstrBotCoreLifecycle,
+):
+    from astrbot.core.computer import computer_client
+    from astrbot.core.computer.sandbox_manager import SandboxManager
+    from astrbot.core.computer.sandbox_registry import SandboxRegistry
+
+    manager = SandboxManager(registry=SandboxRegistry(), providers={})
+    monkeypatch.setattr(computer_client, "sandbox_manager", manager)
+    original_config = copy.deepcopy(dict(core_lifecycle_td.astrbot_config))
+    post_config = copy.deepcopy(original_config)
+    post_config["provider_settings"]["computer_use_runtime"] = "sandbox"
+    post_config["provider_settings"]["sandbox"]["booter"] = "shipyard"
+
+    try:
+        test_client = app.test_client()
+        response = await test_client.post(
+            "/api/config/astrbot/update",
+            headers=authenticated_header,
+            json={"conf_id": "default", "config": post_config},
+        )
+        data = await response.get_json()
+
+        assert response.status_code == 200
+        assert data["status"] == "ok"
+        assert (
+            core_lifecycle_td.astrbot_config["provider_settings"]["sandbox"]["booter"]
+            == ""
+        )
+    finally:
+        core_lifecycle_td.astrbot_config.save_config(original_config)
+
+
 @pytest.mark.asyncio
 async def test_sandbox_dashboard_lists_managed_sandboxes(
     app: Quart,