fix: guard desktop-managed core restart

Author: zouyonghe

astrbot/core/desktop_runtime.py

@@ -0,0 +1,10 @@
+import os
+
+DESKTOP_MANAGED_RESTART_MESSAGE = (
+    "AstrBot Desktop manages this backend process. Please restart or update from "
+    "the desktop app instead of the core WebUI."
+)
+
+
+def is_desktop_managed_backend() -> bool:
+    return os.environ.get("ASTRBOT_DESKTOP_MANAGED") == "1"

astrbot/core/updator.py

@@ -6,6 +6,10 @@
 
 from astrbot.core import logger
 from astrbot.core.config.default import VERSION
+from astrbot.core.desktop_runtime import (
+    DESKTOP_MANAGED_RESTART_MESSAGE,
+    is_desktop_managed_backend,
+)
 from astrbot.core.utils.astrbot_path import get_astrbot_path
 
 from .zip_updator import ReleaseInfo, RepoZipUpdator
@@ -115,6 +119,9 @@ def _reboot(self, delay: int = 3) -> None:
         在指定的延迟后，终止所有子进程并重新启动程序
         这里只能使用 os.exec* 来重启程序
         """
+        if is_desktop_managed_backend():
+            raise RuntimeError(DESKTOP_MANAGED_RESTART_MESSAGE)
+
         time.sleep(delay)
         self.terminate_child_processes()
         executable = sys.executable

astrbot/dashboard/routes/stat.py

@@ -20,6 +20,10 @@
 from astrbot.core.db import BaseDatabase
 from astrbot.core.db.migration.helper import check_migration_needed_v4
 from astrbot.core.db.po import ProviderStat
+from astrbot.core.desktop_runtime import (
+    DESKTOP_MANAGED_RESTART_MESSAGE,
+    is_desktop_managed_backend,
+)
 from astrbot.core.utils.astrbot_path import get_astrbot_path
 from astrbot.core.utils.auth_password import (
     is_default_dashboard_password,
@@ -70,6 +74,8 @@ async def restart_core(self):
                 .error("You are not permitted to do this operation in demo mode")
                 .__dict__
             )
+        if is_desktop_managed_backend():
+            return Response().error(DESKTOP_MANAGED_RESTART_MESSAGE).__dict__
 
         await self.core_lifecycle.restart()
         return Response().ok().__dict__

astrbot/dashboard/routes/update.py

@@ -7,6 +7,10 @@
 from astrbot.core.config.default import VERSION
 from astrbot.core.core_lifecycle import AstrBotCoreLifecycle
 from astrbot.core.db.migration.helper import check_migration_needed_v4, do_migration_v4
+from astrbot.core.desktop_runtime import (
+    DESKTOP_MANAGED_RESTART_MESSAGE,
+    is_desktop_managed_backend,
+)
 from astrbot.core.updator import AstrBotUpdator
 from astrbot.core.utils.io import download_dashboard, get_dashboard_version
 
@@ -184,6 +188,9 @@ async def get_releases(self):
             return Response().error(e.__str__()).__dict__
 
     async def update_project(self):
+        if is_desktop_managed_backend():
+            return Response().error(DESKTOP_MANAGED_RESTART_MESSAGE).__dict__
+
         data = await request.json
         version = data.get("version", "")
         reboot = data.get("reboot", True)

tests/test_dashboard.py

@@ -1797,6 +1797,35 @@ async def mock_get_dashboard_version(*args, **kwargs):
     assert data["data"]["has_new_version"] is False
 
 
+@pytest.mark.asyncio
+async def test_restart_core_rejects_desktop_managed_backend(
+    app: Quart,
+    authenticated_header: dict,
+    core_lifecycle_td: AstrBotCoreLifecycle,
+    monkeypatch,
+):
+    test_client = app.test_client()
+    restart_called = False
+
+    async def mock_restart():
+        nonlocal restart_called
+        restart_called = True
+
+    monkeypatch.setenv("ASTRBOT_DESKTOP_MANAGED", "1")
+    monkeypatch.setattr(core_lifecycle_td, "restart", mock_restart)
+
+    response = await test_client.post(
+        "/api/stat/restart-core",
+        headers=authenticated_header,
+    )
+
+    assert response.status_code == 200
+    data = await response.get_json()
+    assert data["status"] == "error"
+    assert "desktop" in data["message"].lower()
+    assert restart_called is False
+
+
 @pytest.mark.asyncio
 async def test_do_update(
     app: Quart,
@@ -1863,6 +1892,39 @@ async def mock_pip_install(*args, **kwargs):
     assert progress_data["data"]["overall_percent"] == 100
 
 
+@pytest.mark.asyncio
+async def test_do_update_rejects_desktop_managed_backend(
+    app: Quart,
+    authenticated_header: dict,
+    core_lifecycle_td: AstrBotCoreLifecycle,
+    monkeypatch,
+):
+    test_client = app.test_client()
+    calls = []
+
+    async def mock_update(*args, **kwargs):
+        calls.append("core")
+
+    async def mock_restart():
+        calls.append("restart")
+
+    monkeypatch.setenv("ASTRBOT_DESKTOP_MANAGED", "1")
+    monkeypatch.setattr(core_lifecycle_td.astrbot_updator, "update", mock_update)
+    monkeypatch.setattr(core_lifecycle_td, "restart", mock_restart)
+
+    response = await test_client.post(
+        "/api/update/do",
+        headers=authenticated_header,
+        json={"version": "v3.4.0", "progress_id": "desktop-progress"},
+    )
+
+    assert response.status_code == 200
+    data = await response.get_json()
+    assert data["status"] == "error"
+    assert "desktop" in data["message"].lower()
+    assert calls == []
+
+
 @pytest.mark.asyncio
 async def test_install_pip_package_returns_pip_install_error_message(
     app: Quart,