fix(gull): report degraded health when probe fails

Author: w31r4

pkgs/gull/app/main.py

@@ -325,10 +325,12 @@ async def health() -> HealthResponse:
         timeout=5,
     )
 
-    browser_active = SESSION_NAME in stdout if code == 0 else False
+    probe_ok = code == 0
+    browser_active = SESSION_NAME in stdout if probe_ok else False
+    status = "healthy" if probe_ok else "degraded"
 
     return HealthResponse(
-        status="healthy" if agent_browser_available else "unhealthy",
+        status=status,
         browser_active=browser_active,
         session=SESSION_NAME,
     )

pkgs/gull/tests/unit/test_runner.py

@@ -182,3 +182,42 @@ async def fake_run(_cmd: str, **kwargs):
     assert 0 < captured_timeouts[0] <= 0.3 + 1e-9
     assert captured_timeouts[0] < 1.0
 
+
+@pytest.mark.asyncio
+async def test_health_unhealthy_when_agent_browser_missing(monkeypatch: pytest.MonkeyPatch):
+    monkeypatch.setattr(gull_main.shutil, "which", lambda _name: None)
+
+    response = await gull_main.health()
+
+    assert response.status == "unhealthy"
+    assert response.browser_active is False
+
+
+@pytest.mark.asyncio
+async def test_health_healthy_when_probe_succeeds(monkeypatch: pytest.MonkeyPatch):
+    monkeypatch.setattr(gull_main.shutil, "which", lambda _name: "/usr/bin/agent-browser")
+
+    async def fake_run(_cmd: str, **_kwargs):
+        return gull_main.SESSION_NAME, "", 0
+
+    monkeypatch.setattr(gull_main, "_run_agent_browser", fake_run)
+
+    response = await gull_main.health()
+
+    assert response.status == "healthy"
+    assert response.browser_active is True
+
+
+@pytest.mark.asyncio
+async def test_health_degraded_when_probe_fails(monkeypatch: pytest.MonkeyPatch):
+    monkeypatch.setattr(gull_main.shutil, "which", lambda _name: "/usr/bin/agent-browser")
+
+    async def fake_run(_cmd: str, **_kwargs):
+        return "", "probe failed", 2
+
+    monkeypatch.setattr(gull_main, "_run_agent_browser", fake_run)
+
+    response = await gull_main.health()
+
+    assert response.status == "degraded"
+    assert response.browser_active is False