Fix test case

hyperxpro · hyperxpro · commit 5a2ca9f733aa · 2026-06-07T12:22:08.000Z
diff --git a/client/src/jmh/java/org/asynchttpclient/bench/AcceptEncodingHpackBenchmark.java b/client/src/jmh/java/org/asynchttpclient/bench/AcceptEncodingHpackBenchmark.java
@@ -6,6 +6,12 @@
  *    You may obtain a copy of the License at
  *
  *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
  */
 package org.asynchttpclient.bench;
 
diff --git a/client/src/jmh/java/org/asynchttpclient/bench/ChannelPoolCheckoutBenchmark.java b/client/src/jmh/java/org/asynchttpclient/bench/ChannelPoolCheckoutBenchmark.java
@@ -1,11 +1,17 @@
 /*
- *    Copyright (c) 2024 AsyncHttpClient Project. All rights reserved.
+ *    Copyright (c) 2026 AsyncHttpClient Project. All rights reserved.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
  *    You may obtain a copy of the License at
  *
  *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
  */
 package org.asynchttpclient.bench;
 
diff --git a/client/src/jmh/java/org/asynchttpclient/bench/CookieStoreGetBenchmark.java b/client/src/jmh/java/org/asynchttpclient/bench/CookieStoreGetBenchmark.java
@@ -1,11 +1,17 @@
 /*
- *    Copyright (c) 2024 AsyncHttpClient Project. All rights reserved.
+ *    Copyright (c) 2026 AsyncHttpClient Project. All rights reserved.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
  *    You may obtain a copy of the License at
  *
  *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
  */
 package org.asynchttpclient.bench;
 
diff --git a/client/src/jmh/java/org/asynchttpclient/bench/FormParamsEncodeBenchmark.java b/client/src/jmh/java/org/asynchttpclient/bench/FormParamsEncodeBenchmark.java
@@ -1,11 +1,17 @@
 /*
- *    Copyright (c) 2024 AsyncHttpClient Project. All rights reserved.
+ *    Copyright (c) 2026 AsyncHttpClient Project. All rights reserved.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
  *    You may obtain a copy of the License at
  *
  *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
  */
 package org.asynchttpclient.bench;
 
diff --git a/client/src/jmh/java/org/asynchttpclient/bench/HeaderEncodeBenchmark.java b/client/src/jmh/java/org/asynchttpclient/bench/HeaderEncodeBenchmark.java
@@ -6,6 +6,12 @@
  *    You may obtain a copy of the License at
  *
  *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
  */
 package org.asynchttpclient.bench;
 
diff --git a/client/src/jmh/java/org/asynchttpclient/bench/MultipartPreContentBenchmark.java b/client/src/jmh/java/org/asynchttpclient/bench/MultipartPreContentBenchmark.java
@@ -1,11 +1,17 @@
 /*
- *    Copyright (c) 2024 AsyncHttpClient Project. All rights reserved.
+ *    Copyright (c) 2026 AsyncHttpClient Project. All rights reserved.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
  *    You may obtain a copy of the License at
  *
  *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
  */
 package org.asynchttpclient.bench;
 
diff --git a/client/src/jmh/java/org/asynchttpclient/bench/RequestHeaderCopyBenchmark.java b/client/src/jmh/java/org/asynchttpclient/bench/RequestHeaderCopyBenchmark.java
@@ -6,6 +6,12 @@
  *    You may obtain a copy of the License at
  *
  *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
  */
 package org.asynchttpclient.bench;
 
diff --git a/client/src/jmh/java/org/asynchttpclient/bench/ResponseBodyPartBenchmark.java b/client/src/jmh/java/org/asynchttpclient/bench/ResponseBodyPartBenchmark.java
@@ -6,6 +6,12 @@
  *    You may obtain a copy of the License at
  *
  *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
  */
 package org.asynchttpclient.bench;
 
diff --git a/client/src/jmh/java/org/asynchttpclient/bench/UriEncoderBenchmark.java b/client/src/jmh/java/org/asynchttpclient/bench/UriEncoderBenchmark.java
@@ -1,11 +1,17 @@
 /*
- *    Copyright (c) 2024 AsyncHttpClient Project. All rights reserved.
+ *    Copyright (c) 2026 AsyncHttpClient Project. All rights reserved.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
  *    You may obtain a copy of the License at
  *
  *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
  */
 package org.asynchttpclient.bench;
 
diff --git a/client/src/jmh/java/org/asynchttpclient/bench/UriParseBenchmark.java b/client/src/jmh/java/org/asynchttpclient/bench/UriParseBenchmark.java
@@ -1,11 +1,17 @@
 /*
- *    Copyright (c) 2024 AsyncHttpClient Project. All rights reserved.
+ *    Copyright (c) 2026 AsyncHttpClient Project. All rights reserved.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
  *    You may obtain a copy of the License at
  *
  *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
  */
 package org.asynchttpclient.bench;
 
diff --git a/client/src/test/java/org/asynchttpclient/netty/channel/DefaultChannelPoolTest.java b/client/src/test/java/org/asynchttpclient/netty/channel/DefaultChannelPoolTest.java
@@ -217,14 +217,20 @@ public void cleanerLeavesHealthyChannelLeasable() throws Exception {
 
     @Test
     public void channelReofferedAfterExpiryIsNotReaped() throws Exception {
+        // maxIdleTime must comfortably exceed the re-offer -> cleaner-fire gap below: reset() stamps a
+        // fresh start, and the channel must read as fresh when the cleaner runs. A tiny timeout (e.g.
+        // 1ms) is shorter than millisecond clock granularity, so the re-offered channel would re-expire
+        // before fire() and be reaped — a test artifact, not a pool bug.
+        final long maxIdle = 1000;
         CapturingTimer timer = new CapturingTimer();
-        DefaultChannelPool pool = idlePool(timer, Duration.ofMillis(1));
+        DefaultChannelPool pool = idlePool(timer, Duration.ofMillis(maxIdle));
         Channel channel = new EmbeddedChannel();
 
         pool.offer(channel, KEY);
-        Thread.sleep(40); // channel is now idle-expired
+        Thread.sleep(maxIdle + 100); // first lifetime exceeds maxIdleTime: this channel was reapable
 
-        // Lease and re-offer it: reset() stamps a fresh start, so the next cleaner pass must spare it.
+        // Lease and re-offer it: reset() stamps a fresh start, so the cleaner (firing immediately,
+        // far inside maxIdleTime) must spare it.
         assertSame(channel, pool.poll(KEY));
         pool.offer(channel, KEY);
 
