Skip to content

Commit f1c234f

Browse files
fix(ci): use workflow_dispatch input for version instead of GITHUB_REF_NAME
When triggered manually, GITHUB_REF_NAME is the branch name (e.g. 'main'), not a version tag. This caused dpkg-deb to fail with 'version number does not start with digit'. Now uses APP_VERSION env var resolved from inputs.
1 parent 5a4def4 commit f1c234f

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

.github/workflows/release.yml

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ env:
2525
FLUTTER_VERSION: '3.41.2'
2626
RUST_TOOLCHAIN: 'stable'
2727
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
28+
# Resolve version: prefer workflow_dispatch input, then strip 'v' from release tag, fallback 0.0.1-dev
29+
APP_VERSION: ${{ github.event.inputs.version && github.event.inputs.version != 'dev' && github.event.inputs.version || (github.event_name == 'release' && github.event.release.tag_name || '0.0.1-dev') }}
2830

2931
jobs:
3032
# ==========================================================================
@@ -118,9 +120,9 @@ jobs:
118120
Keywords=cloud;sync;storage;
119121
DESKTOP
120122
121-
# Get version
122-
VERSION="${GITHUB_REF_NAME#v}"
123-
VERSION="${VERSION:-1.0.0}"
123+
# Get version (strip leading 'v' if present)
124+
VERSION="${APP_VERSION#v}"
125+
VERSION="${VERSION:-0.0.1}"
124126
125127
# Control file
126128
cat > "$PKG_DIR/DEBIAN/control" << CONTROL
@@ -141,8 +143,8 @@ jobs:
141143
142144
- name: Package — .rpm
143145
run: |
144-
VERSION="${GITHUB_REF_NAME#v}"
145-
VERSION="${VERSION:-1.0.0}"
146+
VERSION="${APP_VERSION#v}"
147+
VERSION="${VERSION:-0.0.1}"
146148
147149
mkdir -p rpmbuild/{SPECS,BUILD,RPMS,SOURCES}
148150
@@ -338,8 +340,8 @@ jobs:
338340
- name: Create InnoSetup installer
339341
shell: pwsh
340342
run: |
341-
$version = "${{ github.ref_name }}".TrimStart("v")
342-
if (-not $version) { $version = "1.0.0" }
343+
$version = "${{ env.APP_VERSION }}".TrimStart("v")
344+
if (-not $version -or $version -eq "main") { $version = "0.0.1" }
343345
344346
@"
345347
[Setup]

0 commit comments

Comments
 (0)