Skip to content

Commit 8de5062

Browse files
mcdurdinTheyCreeper
authored andcommitted
Write HKCU\Keyboard Layout\Toggle and ...\Accessibility values as REG_SZ instead of REG_DWORD
The three values rewritten in `HKCU\Keyboard Layout\Toggle` should be of type REG_SZ: https://github.com/Atlas-OS/Atlas/blob/0b41102f1ee9696274a177db6aa913b8481377de/src/playbook/Executables/AtlasModules/Scripts/Modules/Qol/Qol.psm1#L47-L50 Expectation: <img width="1052" height="646" alt="Image" src="https://github.com/user-attachments/assets/7894fb5b-460f-46dd-b634-a5c23b4c432a" /> I also checked the `HKCU\Control Panel\Accessibility\...` `Flag` values rewritten in the same function in the registry in a stock install of Windows, and those were also of type REG_SZ, so have patched those too. I have not checked other values in other functions. We received reports of this causing crashes in Keyman; see keymanapp/keyman#14342. (We have now patched Keyman to work around the unexpected data type.)
1 parent 0b41102 commit 8de5062

File tree

1 file changed

+8
-8
lines changed
  • src/playbook/Executables/AtlasModules/Scripts/Modules/Qol

1 file changed

+8
-8
lines changed

src/playbook/Executables/AtlasModules/Scripts/Modules/Qol/Qol.psm1

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,16 @@ function Disable-ReadAndScan {
3838

3939
# Function to disable commonly annoying features and shortcuts
4040
function Disable-AnnoyingFeaturesAndShortcuts {
41-
reg add "HKCU\Control Panel\Accessibility\HighContrast" /v "Flags" /t REG_DWORD /d 0 /f
42-
reg add "HKCU\Control Panel\Accessibility\Keyboard Response" /v "Flags" /t REG_DWORD /d 0 /f
43-
reg add "HKCU\Control Panel\Accessibility\MouseKeys" /v "Flags" /t REG_DWORD /d 0 /f
44-
reg add "HKCU\Control Panel\Accessibility\StickyKeys" /v "Flags" /t REG_DWORD /d 0 /f
45-
reg add "HKCU\Control Panel\Accessibility\ToggleKeys" /v "Flags" /t REG_DWORD /d 0 /f
41+
reg add "HKCU\Control Panel\Accessibility\HighContrast" /v "Flags" /t REG_SZ /d "0" /f
42+
reg add "HKCU\Control Panel\Accessibility\Keyboard Response" /v "Flags" /t REG_SZ /d "0" /f
43+
reg add "HKCU\Control Panel\Accessibility\MouseKeys" /v "Flags" /t REG_SZ /d "0" /f
44+
reg add "HKCU\Control Panel\Accessibility\StickyKeys" /v "Flags" /t REG_SZ /d "0" /f
45+
reg add "HKCU\Control Panel\Accessibility\ToggleKeys" /v "Flags" /t REG_SZ /d "0" /f
4646

4747
reg delete "HKCU\Control Panel\Input Method\Hot Keys\00000104" /f
48-
reg add "HKCU\Keyboard Layout\Toggle" /v "Layout Hotkey" /t REG_DWORD /d 3 /f
49-
reg add "HKCU\Keyboard Layout\Toggle" /v "Language Hotkey" /t REG_DWORD /d 3 /f
50-
reg add "HKCU\Keyboard Layout\Toggle" /v "Hotkey" /t REG_DWORD /d 3 /f
48+
reg add "HKCU\Keyboard Layout\Toggle" /v "Layout Hotkey" /t REG_SZ /d "3" /f
49+
reg add "HKCU\Keyboard Layout\Toggle" /v "Language Hotkey" /t REG_SZ /d "3" /f
50+
reg add "HKCU\Keyboard Layout\Toggle" /v "Hotkey" /t REG_SZ /d "3" /f
5151

5252
reg add "HKCU\Software\Microsoft\Narrator\NoRoam" /v "WinEnterLaunchEnabled" /t REG_DWORD /d 0 /f
5353
}

0 commit comments

Comments
 (0)