Skip to content

Setting attachHeadersAsQueryString flag to False breaks long polling #2428

Open
@devslam

Description

@devslam

Describe the bug
I'm creating a socket with long polling and it works when the attachHeadersAsQueryString flag is set True. However, it breaks when the attachHeadersAsQueryString flag is set True. It sends a request once and does not poll again.

I suspect it's because we're not sending in the ?X-Atmosphere-Transport=long-polling query parameter when the flag is set to False
Atmosphere Info

  • version: 2.4.30
  • atmosphere.js version: 2.3.8-javascript

Expected behavior
I'm expecting long polling to work when I set the attachHeadersAsQueryString flag to False. However it does not. I'm expecting it to poll consistently. It sends a request once and does not poll again.

It's my understanding that setting the flag to False would still send in query parameters that are required for long polling to work; it would not send in "debug/informational" headers as a query string

Note: Long polling works when the attachHeadersAsQueryString flag is set to True

Screenshots
If you look at the screenshots here. The X-Atmosphere-Transport=long-polling query parameter isn't being passed in when the attachHeadersAsQueryString flag is set to True

Flag set to True

image
Flag set to False
image

Systems (please complete the following information):

  • OS: macOS
  • Browser name and version: Chrome 88
  • Java version and distribution: Java 8
  • Server name and version: Tomcat 7.0.94

Additional context
The reason why I'm setting the attachHeadersAsQueryString flag to False is because I don't think it's necessary to send in the following headers as query strings
X-Atmosphere-tracking-id=*************
X-Atmosphere-Framework=2.3.8-javascript
X-atmo-protocol=true

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions