feat: ci (#13)

* feat: ci

* chore: .nvmrc

* feat: ci

* feat: ci

* chore: build stage ci

* chore: simplify CI workflow trigger configuration

* fix: lint

* chore: more conservative linting

* fix lint in transactions.ts

* fix interface lints

* fix more

* fmt index.ts

* fix errors

* complete format

---------

Co-authored-by: fishonamos <amosfishon@gmail.com>

Author: francis2tm

.github/workflows/ci.yml

@@ -0,0 +1,36 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - '**'
+
+jobs:
+  quality:
+    name: Code Quality
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version-file: '.nvmrc'
+
+      - name: Setup PNPM
+        uses: pnpm/action-setup@v2
+        with:
+          version: '8.9.0'
+
+      - name: Install dependencies
+        run: pnpm install
+
+      - name: Check formatting
+        run: pnpm format --check
+
+      - name: Run linting
+        run: pnpm lint
+
+      - name: Build
+        run: pnpm build

.nvmrc

@@ -0,0 +1 @@
+18.19.1 

apps/web/.eslintrc.json

@@ -0,0 +1,17 @@
+{
+  "parser": "@typescript-eslint/parser",
+  "plugins": ["@typescript-eslint"],
+  "extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
+  "parserOptions": {
+    "ecmaVersion": 2020,
+    "sourceType": "module"
+  },
+  "rules": {
+    "@typescript-eslint/no-explicit-any": "error",
+    "@typescript-eslint/no-unused-vars": "error"
+  },
+  "env": {
+    "node": true,
+    "es6": true
+  }
+}

apps/web/src/routes/v1/query.ts

@@ -2,7 +2,7 @@ import { Router } from 'express';
 import { Request, Response } from 'express';
 import { config } from '../../config';
 import Agent from '@atoma-agents/sui-agent/src/agents/SuiAgent';
-let suiAgent = new Agent(config.atomaSdkBearerAuth);
+const suiAgent = new Agent(config.atomaSdkBearerAuth);
 const queryRouter: Router = Router();
 
 // Health check endpoint
@@ -21,7 +21,7 @@ const handleQuery = async (req: Request, res: Response): Promise<void> => {
       return;
     }
     // TODO: Implement query handling with sui-agent
-    let result = await suiAgent.SuperVisorAgent(query);
+    const result = await suiAgent.SuperVisorAgent(query);
     res.status(200).json(result);
   } catch (error) {
     console.error('Error handling query:', error);

packages/sui-agent/.eslintrc.json

@@ -1,13 +1,13 @@
 {
-    "parser": "@typescript-eslint/parser",
-    "plugins": ["@typescript-eslint"],
-    "extends": [
-        "eslint:recommended",
-        "plugin:@typescript-eslint/recommended"
-    ],
-    "parserOptions": {
-        "ecmaVersion": 2020,
-        "sourceType": "module"
-    },
-    "rules": {}
+  "parser": "@typescript-eslint/parser",
+  "plugins": ["@typescript-eslint"],
+  "extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
+  "parserOptions": {
+    "ecmaVersion": 2020,
+    "sourceType": "module"
+  },
+  "rules": {
+    "@typescript-eslint/no-explicit-any": "error",
+    "@typescript-eslint/no-unused-vars": "error"
+  }
 }

packages/sui-agent/src/@types/interface.d.ts

@@ -4,15 +4,15 @@ export interface IntentAgentResponse {
   response: null | string;
   needs_additional_info: boolean;
   additional_info_required: null | string[];
-  tool_arguments: any[];
+  tool_arguments: (string | number | boolean | bigint)[];
 }
 export interface toolResponse {
   success: boolean;
   selected_tool: null | string;
   response: null | string;
   needs_additional_info: boolean;
   additional_info_required: null | string[];
-  tool_arguments: any[];
+  tool_arguments: (string | number | boolean | bigint)[];
 }
 export interface ToolParameter {
   name: string;
@@ -24,7 +24,9 @@ export interface Tool {
   name: string;
   description: string;
   parameters: ToolParameter[];
-  process: (...args: any[]) => Promise<string> | string;
+  process: (
+    ...args: (string | number | boolean | bigint)[]
+  ) => Promise<string> | string;
 }
 export declare const COIN_SYNONYMS: Record<string, string>;
 export declare const COIN_ADDRESSES: {

packages/sui-agent/src/@types/interface.ts

@@ -5,17 +5,19 @@ export interface IntentAgentResponse {
   response: null | string; // Response message from the operation
   needs_additional_info: boolean; // Indicates if more information is needed
   additional_info_required: null | string[]; // List of additional information fields needed
-  tool_arguments: any[]; // Arguments passed to the tool
+  tool_arguments: (string | number | boolean | bigint)[]; // Arguments passed to the tool
 }
 
+export type ToolArgument = string | number | boolean | bigint;
+
 // Response interface for tool operations (similar to IntentAgentResponse)
 export interface toolResponse {
   success: boolean;
   selected_tool: null | string;
   response: null | string;
   needs_additional_info: boolean;
   additional_info_required: null | string[];
-  tool_arguments: any[];
+  tool_arguments: (string | number | boolean | bigint)[];
 }
 
 // Defines the structure for tool parameters
@@ -31,7 +33,9 @@ export interface Tool {
   name: string; // Name of the tool
   description: string; // Description of what the tool does
   parameters: ToolParameter[]; // List of parameters the tool accepts
-  process: (...args: any[]) => Promise<string> | string; // Function to execute the tool
+  process: (
+    ...args: (string | number | boolean | bigint)[]
+  ) => Promise<string> | string; // Function to execute the tool
 }
 
 // Mapping of different coin names/variants to their standardized symbol

packages/sui-agent/src/agents/SuiAgent.ts

@@ -42,7 +42,10 @@ class Agents {
    * @param query - Original user query
    * @returns Processed response after decision making
    */
-  async DecisionMakingAgent(intentResponse: any, query: string) {
+  async DecisionMakingAgent(
+    intentResponse: IntentAgentResponse,
+    query: string,
+  ) {
     return await this.utils.processQuery(query);
   }
 

packages/sui-agent/src/tools/aftermath/PoolTool.ts

@@ -1,22 +1,18 @@
-import { Aftermath } from 'aftermath-ts-sdk';
+import { Aftermath, Pool } from 'aftermath-ts-sdk';
 import { PoolInfo } from '../../@types/interface';
 import { handleError } from '../../utils';
 
 // Initialize Aftermath SDK for mainnet
 const af = new Aftermath('MAINNET');
 const pools = af.Pools();
 
-// Type definitions for pool operations
-type RankingMetric = 'apr' | 'tvl' | 'fees' | 'volume';
-type SortOrder = 'asc' | 'desc';
-
 /**
  * Processes raw pool data into standardized format
  * @param pool - Raw pool data from Aftermath
  * @param poolId - Unique identifier for the pool
  * @returns Standardized pool information
  */
-async function processPool(pool: any, poolId: string): Promise<PoolInfo> {
+async function processPool(pool: Pool, poolId: string): Promise<PoolInfo> {
   try {
     const metrics = await pools.getPoolsStats({ poolIds: [poolId] });
     const poolMetrics = metrics[0];
@@ -54,7 +50,10 @@ async function processPool(pool: any, poolId: string): Promise<PoolInfo> {
  * @param poolId - Unique identifier for the pool
  * @returns JSON string containing pool details or error information
  */
-export async function getPool(poolId: string): Promise<string> {
+export async function getPool(
+  ...args: (string | number | bigint | boolean)[]
+): Promise<string> {
+  const poolId = args[0] as string;
   try {
     const pool = await pools.getPool({ objectId: poolId });
     if (!pool) {
@@ -132,10 +131,9 @@ export async function getAllPools(): Promise<string> {
  * @returns JSON string containing event information
  */
 export async function getPoolEvents(
-  poolId: string,
-  eventType: 'deposit' | 'withdraw',
-  limit = 10,
+  ...args: (string | number | bigint | boolean)[]
 ): Promise<string> {
+  const [poolId, eventType, limit] = args as [string, string, number];
   try {
     const pool = await pools.getPool({ objectId: poolId });
     if (!pool) {
@@ -171,29 +169,6 @@ export async function getPoolEvents(
   }
 }
 
-/**
- * Calculates pool APR based on volume and TVL
- * @param pool - Pool data containing volume and TVL information
- * @returns Calculated APR as a percentage
- */
-export function calculatePoolApr(pool: any): number {
-  try {
-    // Convert values from base units
-    const volume24h = Number(pool.pool.volume24h || 0) / 1e9;
-    const tvl = Number(pool.pool.lpCoinSupply || 0) / 1e9;
-    if (tvl === 0) return 0;
-
-    // Calculate annual revenue and APR
-    const feeRate = Number(pool.pool.flatness || 0) / 1e9;
-    const feeRevenue24h = volume24h * feeRate;
-    const annualRevenue = feeRevenue24h * 365;
-    return (annualRevenue / tvl) * 100;
-  } catch (error) {
-    console.error('Error calculating pool APR:', error);
-    return 0;
-  }
-}
-
 /**
  * Gets ranked pools by specified metric
  * @param metric - Metric to rank by (apr, tvl, fees, volume)
@@ -202,10 +177,9 @@ export function calculatePoolApr(pool: any): number {
  * @returns JSON string containing ranked pool information
  */
 export async function getRankedPools(
-  metric: RankingMetric = 'tvl',
-  limit = 10,
-  order: SortOrder = 'desc',
+  ...args: (string | number | bigint | boolean)[]
 ): Promise<string> {
+  const [metric, limit, order] = args as [string, number, string];
   try {
     // Fetch and process all pools
     const allPools = await pools.getAllPools();
@@ -299,10 +273,9 @@ export async function getRankedPools(
  * @returns JSON string containing filtered pool information
  */
 export async function getFilteredPools(
-  minTvl?: number,
-  minApr?: number,
-  tokens?: string[],
+  ...args: (string | number | bigint | boolean)[]
 ): Promise<string> {
+  const [minTvl, minApr, tokens] = args as [number, number, string[]];
   try {
     // Fetch and process all pools
     const allPools = await pools.getAllPools();

packages/sui-agent/src/tools/aftermath/PoolTransactionTool.ts

@@ -38,7 +38,7 @@ interface RankedPool {
 function convertAftermathTransaction(tx: unknown): AftermathTransaction {
   const rawTx = tx as {
     target: string;
-    arguments: any[];
+    arguments: (string | number | boolean | bigint)[];
     typeArguments: string[];
   };