use BTreeMap::extract_if for remove_topic_*_with_prefix #71
Annotations
3 errors and 10 warnings
|
msrv
Process completed with exit code 101.
|
|
lint
reviewdog exited with status code: 1
|
|
lint
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
|
lint:
src/network/udp_listener.rs#L72
[clippy] reported by reviewdog 🐶
warning: this can be `std::io::Error::other(_)`
--> src/network/udp_listener.rs:72:22
|
72 | .map_err(|e| io::Error::new(io::ErrorKind::Other, e))?,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
|
72 - .map_err(|e| io::Error::new(io::ErrorKind::Other, e))?,
72 + .map_err(|e| io::Error::other(e))?,
|
Raw Output:
src/network/udp_listener.rs:72:22:w:warning: this can be `std::io::Error::other(_)`
--> src/network/udp_listener.rs:72:22
|
72 | .map_err(|e| io::Error::new(io::ErrorKind::Other, e))?,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
|
72 - .map_err(|e| io::Error::new(io::ErrorKind::Other, e))?,
72 + .map_err(|e| io::Error::other(e))?,
|
__END__
|
|
lint:
src/messages/submessages/elements/serialized_payload.rs#L95
[clippy] reported by reviewdog 🐶
warning: this can be `std::io::Error::other(_)`
--> src/messages/submessages/elements/serialized_payload.rs:95:18
|
95 | return Err(io::Error::new(
| __________________^
96 | | io::ErrorKind::Other,
97 | | "Too short DATA submessage.",
98 | | ));
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
|
95 ~ return Err(io::Error::other(
96 ~ "Too short DATA submessage.",
|
Raw Output:
src/messages/submessages/elements/serialized_payload.rs:95:18:w:warning: this can be `std::io::Error::other(_)`
--> src/messages/submessages/elements/serialized_payload.rs:95:18
|
95 | return Err(io::Error::new(
| __________________^
96 | | io::ErrorKind::Other,
97 | | "Too short DATA submessage.",
98 | | ));
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
|
95 ~ return Err(io::Error::other(
96 ~ "Too short DATA submessage.",
|
__END__
|
|
lint:
src/messages/submessages/elements/parameter.rs#L101
[clippy] reported by reviewdog 🐶
warning: manual implementation of `.is_multiple_of()`
--> src/messages/submessages/elements/parameter.rs:101:18
|
101 | let pad = if length % 4 != 0 { 4 - (length % 4) } else { 0 };
| ^^^^^^^^^^^^^^^ help: replace with: `!length.is_multiple_of(4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
= note: `#[warn(clippy::manual_is_multiple_of)]` on by default
Raw Output:
src/messages/submessages/elements/parameter.rs:101:18:w:warning: manual implementation of `.is_multiple_of()`
--> src/messages/submessages/elements/parameter.rs:101:18
|
101 | let pad = if length % 4 != 0 { 4 - (length % 4) } else { 0 };
| ^^^^^^^^^^^^^^^ help: replace with: `!length.is_multiple_of(4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
= note: `#[warn(clippy::manual_is_multiple_of)]` on by default
__END__
|
|
lint:
src/messages/submessages/data_frag.rs#L235
[clippy] reported by reviewdog 🐶
warning: this can be `std::io::Error::other(_)`
--> src/messages/submessages/data_frag.rs:235:18
|
235 | return Err(io::Error::new(
| __________________^
236 | | io::ErrorKind::Other,
237 | | format!(
238 | | "DataFrag fragmentStartingNum={fragment_starting_num:?} \
... |
241 | | ),
242 | | ));
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
|
235 ~ return Err(io::Error::other(
236 ~ format!(
|
Raw Output:
src/messages/submessages/data_frag.rs:235:18:w:warning: this can be `std::io::Error::other(_)`
--> src/messages/submessages/data_frag.rs:235:18
|
235 | return Err(io::Error::new(
| __________________^
236 | | io::ErrorKind::Other,
237 | | format!(
238 | | "DataFrag fragmentStartingNum={fragment_starting_num:?} \
... |
241 | | ),
242 | | ));
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
|
235 ~ return Err(io::Error::other(
236 ~ format!(
|
__END__
|
|
lint:
src/messages/submessages/data_frag.rs#L206
[clippy] reported by reviewdog 🐶
warning: this can be `std::io::Error::other(_)`
--> src/messages/submessages/data_frag.rs:206:18
|
206 | return Err(io::Error::new(
| __________________^
207 | | io::ErrorKind::Other,
208 | | format!(
209 | | "Invalid DataFrag. fragment_size={fragment_size} data_size={data_size} Expected 1 <= \
210 | | fragment_size <= data_size."
211 | | ),
212 | | ));
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
|
206 ~ return Err(io::Error::other(
207 ~ format!(
|
Raw Output:
src/messages/submessages/data_frag.rs:206:18:w:warning: this can be `std::io::Error::other(_)`
--> src/messages/submessages/data_frag.rs:206:18
|
206 | return Err(io::Error::new(
| __________________^
207 | | io::ErrorKind::Other,
208 | | format!(
209 | | "Invalid DataFrag. fragment_size={fragment_size} data_size={data_size} Expected 1 <= \
210 | | fragment_size <= data_size."
211 | | ),
212 | | ));
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
|
206 ~ return Err(io::Error::other(
207 ~ format!(
|
__END__
|
|
lint:
src/messages/submessages/data_frag.rs#L193
[clippy] reported by reviewdog 🐶
warning: this can be `std::io::Error::other(_)`
--> src/messages/submessages/data_frag.rs:193:18
|
193 | return Err(io::Error::new(
| __________________^
194 | | io::ErrorKind::Other,
195 | | "DataFrag SequenceNumber < 1. Discarding as invalid.",
196 | | ));
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
|
193 ~ return Err(io::Error::other(
194 ~ "DataFrag SequenceNumber < 1. Discarding as invalid.",
|
Raw Output:
src/messages/submessages/data_frag.rs:193:18:w:warning: this can be `std::io::Error::other(_)`
--> src/messages/submessages/data_frag.rs:193:18
|
193 | return Err(io::Error::new(
| __________________^
194 | | io::ErrorKind::Other,
195 | | "DataFrag SequenceNumber < 1. Discarding as invalid.",
196 | | ));
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
|
193 ~ return Err(io::Error::other(
194 ~ "DataFrag SequenceNumber < 1. Discarding as invalid.",
|
__END__
|
|
lint:
src/messages/submessages/data_frag.rs#L156
[clippy] reported by reviewdog 🐶
warning: this can be `std::io::Error::other(_)`
--> src/messages/submessages/data_frag.rs:156:18
|
156 | return Err(io::Error::new(
| __________________^
157 | | io::ErrorKind::Other,
158 | | format!("DataFrag has too low octetsToInlineQos = {octets_to_inline_qos}"),
159 | | ));
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
|
156 ~ return Err(io::Error::other(
157 ~ format!("DataFrag has too low octetsToInlineQos = {octets_to_inline_qos}"),
|
Raw Output:
src/messages/submessages/data_frag.rs:156:18:w:warning: this can be `std::io::Error::other(_)`
--> src/messages/submessages/data_frag.rs:156:18
|
156 | return Err(io::Error::new(
| __________________^
157 | | io::ErrorKind::Other,
158 | | format!("DataFrag has too low octetsToInlineQos = {octets_to_inline_qos}"),
159 | | ));
| |_______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
|
156 ~ return Err(io::Error::other(
157 ~ format!("DataFrag has too low octetsToInlineQos = {octets_to_inline_qos}"),
|
__END__
|
|
lint:
src/messages/submessages/data_frag.rs#L117
[clippy] reported by reviewdog 🐶
warning: this can be `std::io::Error::other(_)`
--> src/messages/submessages/data_frag.rs:117:37
|
117 | let map_speedy_err = |p: Error| io::Error::new(io::ErrorKind::Other, p);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
|
117 - let map_speedy_err = |p: Error| io::Error::new(io::ErrorKind::Other, p);
117 + let map_speedy_err = |p: Error| io::Error::other(p);
|
Raw Output:
src/messages/submessages/data_frag.rs:117:37:w:warning: this can be `std::io::Error::other(_)`
--> src/messages/submessages/data_frag.rs:117:37
|
117 | let map_speedy_err = |p: Error| io::Error::new(io::ErrorKind::Other, p);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
|
117 - let map_speedy_err = |p: Error| io::Error::new(io::ErrorKind::Other, p);
117 + let map_speedy_err = |p: Error| io::Error::other(p);
|
__END__
|
|
lint:
src/messages/submessages/data.rs#L60
[clippy] reported by reviewdog 🐶
warning: this can be `std::io::Error::other(_)`
--> src/messages/submessages/data.rs:60:37
|
60 | let map_speedy_err = |p: Error| io::Error::new(io::ErrorKind::Other, p);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
= note: `#[warn(clippy::io_other_error)]` on by default
help: use `std::io::Error::other`
|
60 - let map_speedy_err = |p: Error| io::Error::new(io::ErrorKind::Other, p);
60 + let map_speedy_err = |p: Error| io::Error::other(p);
|
Raw Output:
src/messages/submessages/data.rs:60:37:w:warning: this can be `std::io::Error::other(_)`
--> src/messages/submessages/data.rs:60:37
|
60 | let map_speedy_err = |p: Error| io::Error::new(io::ErrorKind::Other, p);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
= note: `#[warn(clippy::io_other_error)]` on by default
help: use `std::io::Error::other`
|
60 - let map_speedy_err = |p: Error| io::Error::new(io::ErrorKind::Other, p);
60 + let map_speedy_err = |p: Error| io::Error::other(p);
|
__END__
|
|
lint:
src/discovery/sedp_messages.rs#L387
[clippy] reported by reviewdog 🐶
warning: using `map_err` over `inspect_err`
--> src/discovery/sedp_messages.rs:387:6
|
387 | .map_err(|e| {
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
387 ~ .inspect_err(|e| {
388 | warn!(
389 | "Content filter was: {:?}",
390 | pl_map.get(&ParameterId::PID_CONTENT_FILTER_PROPERTY)
391 ~ );
|
Raw Output:
src/discovery/sedp_messages.rs:387:6:w:warning: using `map_err` over `inspect_err`
--> src/discovery/sedp_messages.rs:387:6
|
387 | .map_err(|e| {
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
387 ~ .inspect_err(|e| {
388 | warn!(
389 | "Content filter was: {:?}",
390 | pl_map.get(&ParameterId::PID_CONTENT_FILTER_PROPERTY)
391 ~ );
|
__END__
|