misc fixes

Author: Aytackydln

Project-Aurora/Project-Aurora/Bitmaps/GdiPlus/GdiPartialCopyBitmapReader.cs

@@ -18,6 +18,7 @@ public sealed class GdiPartialCopyBitmapReader : IBitmapReader
     // ReSharper disable once CollectionNeverQueried.Local //to keep reference
     private static readonly Dictionary<Size, int[]> BitmapBuffers = new(20);
     private static readonly Vector256<int> FullVector = Vector256.Create(0xFF);
+    private static GraphicsUnit _graphicsUnit = GraphicsUnit.Pixel;
 
     private readonly Bitmap _bitmap;
     private readonly GdiBitmap _gdiBitmap;
@@ -31,8 +32,7 @@ public GdiPartialCopyBitmapReader(Bitmap bitmap, GdiBitmap gdiBitmap)
     {
         _bitmap = bitmap;
         _gdiBitmap = gdiBitmap;
-        var graphicsUnit = GraphicsUnit.Pixel;
-        _dimension = bitmap.GetBounds(ref graphicsUnit);
+        _dimension = bitmap.GetBounds(ref _graphicsUnit);
     }
 
     /**

Project-Aurora/Project-Aurora/Nodes/Razer/RazerFetcher.cs

@@ -11,7 +11,7 @@ namespace AuroraRgb.Nodes.Razer;
 
 internal abstract class RazerFetcher : IDisposable
 {
-    private const string? GLOBAL_RAZERLINKREADWRITEGUARDMUTEX = "Global\\RazerLinkReadWriteGuardMutex";
+    private const string GlobalRazerlinkreadwriteguardmutex = "Global\\RazerLinkReadWriteGuardMutex";
 
     private const int HidReqSetReport = 0x09;
     private const int HidReqGetReport = 0x01; // Add GET_REPORT request
@@ -23,15 +23,12 @@ internal abstract class RazerFetcher : IDisposable
     private const int UsbTypeRequestIn = UsbTypeClass | UsbRecipInterface | UsbDirIn;
     private const int RazerUsbReportLen = 90; // Example length, set this according to actual length
 
-    private readonly Mutex _mutex;
+    private static readonly Mutex Mutex;
 
     static RazerFetcher()
     {
         UsbDevice.ForceLibUsbWinBack = true;
-    }
 
-    protected RazerFetcher()
-    {
         var rule = new MutexAccessRule(new SecurityIdentifier(WellKnownSidType.WorldSid, null), 
             MutexRights.Synchronize | MutexRights.Modify | MutexRights.FullControl | MutexRights.ReadPermissions | MutexRights.TakeOwnership, 
             AccessControlType.Allow);
@@ -40,31 +37,16 @@ protected RazerFetcher()
         mutexSecurity.AddAccessRule(rule);
 
         // Create a mutex with a well-known name use acl
-        _mutex = MutexAcl.Create(false, GLOBAL_RAZERLINKREADWRITEGUARDMUTEX, out _, mutexSecurity);
-
-        try
-        {
-            if (!_mutex.WaitOne(TimeSpan.FromMilliseconds(2000), false))
-            {
-                _mutex.ReleaseMutex();
-                return;
-            }
-        }
-        catch (AbandonedMutexException)
-        {
-            //continue
-        }
-
-        _mutex.ReleaseMutex();
+        Mutex = MutexAcl.Create(false, GlobalRazerlinkreadwriteguardmutex, out _, mutexSecurity);
     }
 
     protected byte[]? Update()
     {
         try
         {
-            if (!_mutex.WaitOne(TimeSpan.FromMilliseconds(2000), false))
+            if (!Mutex.WaitOne(TimeSpan.FromMilliseconds(2000), false))
             {
-                _mutex.ReleaseMutex();
+                Mutex.ReleaseMutex();
                 return null;
             }
         }
@@ -74,7 +56,7 @@ protected RazerFetcher()
         }
 
         var report = UpdateLocked();
-        _mutex.ReleaseMutex();
+        Mutex.ReleaseMutex();
 
         return report;
     }
@@ -169,9 +151,6 @@ private static string GetDeviceProductKeyString(UsbRegistry device)
 
     protected virtual void Dispose(bool disposing)
     {
-        if (!disposing) return;
-        _mutex.Close();
-        _mutex.Dispose();
     }
 
     public void Dispose()

Project-Aurora/Project-Aurora/Settings/Layers/Controls/Control_PercentLayer.xaml

@@ -30,10 +30,10 @@
         <ComboBox SelectedValue="{Binding Properties.PercentType}" ItemsSource="{utils:EnumToItemsSource {x:Type settings:PercentEffectType}}" DisplayMemberPath="Text" SelectedValuePath="Value" Margin="67,114,0,0" Width="200" HorizontalAlignment="Left" VerticalAlignment="Top" />
 
         <Label HorizontalAlignment="Left" Margin="0,145,0,-23" Padding="0" Content="Blink threshold: " VerticalAlignment="Top"/>
-        <xctk:IntegerUpDown Value="{Binding Properties._BlinkThreshold, Converter={StaticResource PercentageConverter}}" Minimum="0" Maximum="100" Margin="90,141,0,-27" Width="50" Height="24" HorizontalAlignment="Left" VerticalAlignment="Top" />
+        <xctk:IntegerUpDown Value="{Binding Properties.BlinkThreshold, Converter={StaticResource PercentageConverter}}" Minimum="0" Maximum="100" Margin="90,141,0,-27" Width="50" Height="24" HorizontalAlignment="Left" VerticalAlignment="Top" />
         <Label HorizontalAlignment="Left" Margin="145,145,0,-23" Padding="0" Content="%" VerticalAlignment="Top" RenderTransformOrigin="0.6,0.542"/>
-        <CheckBox Content="Reverse blink threshold" IsChecked="{Binding Properties._BlinkDirection}" Margin="3,166,0,0" HorizontalAlignment="Left" VerticalAlignment="Top" />
-        <CheckBox Content="Blink background instead" IsChecked="{Binding Properties._BlinkBackground}" Margin="3,181,0,0" HorizontalAlignment="Left" VerticalAlignment="Top" />
+        <CheckBox Content="Reverse blink threshold" IsChecked="{Binding Properties.BlinkDirection}" Margin="3,166,0,0" HorizontalAlignment="Left" VerticalAlignment="Top" />
+        <CheckBox Content="Blink background instead" IsChecked="{Binding Properties.BlinkBackground}" Margin="3,181,0,0" HorizontalAlignment="Left" VerticalAlignment="Top" />
 
         <controls1:KeySequence Sequence="{Binding Properties._Sequence}" RecordingTag="PercentLayer" Title="Affected Keys" Margin="272,0,0,0" Width="230" HorizontalAlignment="Left" />
     </Grid>