remove instance synchronizations from AudioDeviceProxy and add error handling for NAudio thread

Author: Aytackydln

Project-Aurora/Project-Aurora/Modules/AudioCapture/AudioDeviceProxy.cs

@@ -2,7 +2,6 @@
 using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Linq;
-using System.Runtime.CompilerServices;
 using System.Threading;
 using System.Threading.Tasks;
 using NAudio.CoreAudioApi;
@@ -36,6 +35,10 @@ public sealed class AudioDeviceProxy : IDisposable, IMMNotificationClient
             {
                 return;
             }
+            catch (Exception e)
+            {
+                Global.logger.Error(e, "Unexpected error in NAudio thread");
+            }
         }
     })
     {
@@ -306,7 +309,6 @@ private void DisposeCurrentDeviceOnThread()
         DeviceChanged?.Invoke(this, EventArgs.Empty);
     }
 
-    [MethodImpl(MethodImplOptions.Synchronized)]
     public void OnDeviceStateChanged(string deviceId, DeviceState newState)
     {
         if (DeviceId != deviceId)
@@ -339,15 +341,13 @@ public void OnDeviceStateChanged(string deviceId, DeviceState newState)
         }
     }
 
-    [MethodImpl(MethodImplOptions.Synchronized)]
     public void OnDeviceAdded(string pwstrDeviceId)
     {
         if (pwstrDeviceId != DeviceId) return;
         var mmDevice = _deviceEnumerator.GetDevice(pwstrDeviceId);
         SetDevice(mmDevice);
     }
 
-    [MethodImpl(MethodImplOptions.Synchronized)]
     public void OnDeviceRemoved(string deviceId)
     {
         if (Device?.ID == deviceId && Device?.State != DeviceState.Active)
@@ -359,7 +359,6 @@ public void OnDeviceRemoved(string deviceId)
     /// <summary>
     /// Update the device when changed by the system.
     /// </summary>
-    [MethodImpl(MethodImplOptions.Synchronized)]
     public void OnDefaultDeviceChanged(DataFlow flow, Role role, string? defaultDeviceId)
     {
         if (Flow != flow || !AudioDevices.DefaultDeviceId.Equals(DeviceId)) return;