fix(premium): Re-order session handling, so premium user don't consume session uselessly

Author: Xephi

authme-core/src/main/java/fr/xephi/authme/process/join/AsynchronousJoin.java

@@ -178,13 +178,16 @@ public void processJoin(Player player) {
                 }
             }
 
-            // Session logic
-            if (sessionService.canResumeSession(player)) {
-                service.send(player, MessageKey.SESSION_RECONNECTION);
-                // Run commands
-                bukkitService.scheduleSyncTaskFromOptionallyAsyncTask(player,
-                    () -> commandManager.runCommandsOnSessionLogin(player));
-                bukkitService.runTaskOptionallyAsync(() -> asynchronousLogin.forceLogin(player));
+            // Premium players are always verified by Mojang — skip the session mechanism entirely,
+            // which would send a misleading SESSION_RECONNECTION message and run session commands.
+            if (canBypassWithPremium(player)) {
+                // Premium bypass: player has a verified Mojang UUID matching the connecting player's UUID
+                if (bungeeSender.isEnabled()) {
+                    // Proxy handles routing; do not attempt backend-side BungeeCord redirect
+                    bukkitService.runTaskOptionallyAsync(() -> asynchronousLogin.forceLoginFromProxy(player));
+                } else {
+                    bukkitService.runTaskOptionallyAsync(() -> asynchronousLogin.forceLogin(player));
+                }
                 return;
             } else if (proxySessionManager.shouldResumeSession(name)) {
                 service.send(player, MessageKey.SESSION_RECONNECTION);
@@ -198,14 +201,12 @@ public void processJoin(Player player) {
                 logger.info("The user " + player.getName() + " has been automatically logged in, "
                     + "as present in autologin queue.");
                 return;
-            } else if (canBypassWithPremium(player)) {
-                // Premium bypass: player has a verified Mojang UUID matching the connecting player's UUID
-                if (bungeeSender.isEnabled()) {
-                    // Proxy handles routing; do not attempt backend-side BungeeCord redirect
-                    bukkitService.runTaskOptionallyAsync(() -> asynchronousLogin.forceLoginFromProxy(player));
-                } else {
-                    bukkitService.runTaskOptionallyAsync(() -> asynchronousLogin.forceLogin(player));
-                }
+            } else if (sessionService.canResumeSession(player)) {
+                service.send(player, MessageKey.SESSION_RECONNECTION);
+                // Run commands
+                bukkitService.scheduleSyncTaskFromOptionallyAsyncTask(player,
+                    () -> commandManager.runCommandsOnSessionLogin(player));
+                bukkitService.runTaskOptionallyAsync(() -> asynchronousLogin.forceLogin(player));
                 return;
             }
         } else if (!service.getProperty(RegistrationSettings.FORCE) && pendingRegistration == null) {