Skip to content

Commit 25b961c

Browse files
fix the regression to do LAUNCH debug and it has a prompt dialog in ACAD (#69)
##### Objective In this submission I want to fix the regression to do launch debug, then ACAD has a prompt message. This is the bug logged by our tester: Reproducible Steps: 1. Download the latest extension from https://github.com/Autodesk-AutoCAD/AutoLispExt/releases/tag/v1.3.5-e89e0583505fa944bf959348745e8caf8ff6b47c.0 2. Open a lisp in vscode 3. Press F5 and choose launch Actual Result: Sequoia will pop up a below message dialog AutoCAD Message Cannot find the specified drawing file. Please verify that the file exists. OK ##### Abstractions I think this bug is introduced by this PR #55 If user doesn't fill any thing in the `Paramter ` field in the extension setting, then it will fill null to API `vscode.DebugAdapterExecutable`. It looks like this API will translate null to some bad file parameter inside to ACAD. I think this PR this PR #55 introduced the point that the parameter can be null. So it introduced this issue. ##### Tests performed - retest the bug mentioned above, and test debug launch mode with/without start parameters. ![image](https://user-images.githubusercontent.com/68938334/105286420-333fd780-5bf1-11eb-8a21-9e47afbb5a78.png) ##### Screen shot Not applicable, only bugfix
1 parent a0531c5 commit 25b961c

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

DevREADME.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,14 @@
33
AutoCAD Lisp Extension is a vscode extension for debug AutoCAD AutoLISP. The Extension plays the roles of both debug adapter and language server which could enable you debug lisp with AutoCAD. The following description is for developers.
44

55
## How to setup the Dev env and compile the code
6-
7-
You could do all the steps in the script pack.py, it is python2; or run it directly:
6+
Firstly you should make sure you have installed python and NodeJS.
7+
Then you could do all the steps in the script pack.py, it is python2; or run it directly:
88
```
99
cd AutoLispExt
10+
npm install --global gulp-cli
1011
python pack.py
1112
```
13+
1214
### How to compile the codes
1315
The script pack.py will copy some utility files to correct location for making package. After run that script and then change some TS codes, you can also use the follow command to compile codes simply:
1416
```

extension/src/debug.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ class LaunchDebugAdapterExecutableFactory
3636
let productStartCommand = ProcessPathCache.globalProductPath;
3737
let productStartParameter = ProcessPathCache.globalParameter;
3838

39-
const args = ["--", productStartCommand, productStartParameter];
39+
let args = ["--", productStartCommand, productStartParameter];
40+
if (productStartParameter == null) args = ["--", productStartCommand];
4041
return new vscode.DebugAdapterExecutable(lispadapterpath, args);
4142
}
4243
}

0 commit comments

Comments
 (0)