Skip to content

Commit f201943

Browse files
author
NikolayAvramov
committed
rename screenshot method
1 parent c29c49a commit f201943

File tree

6 files changed

+8
-7
lines changed

6 files changed

+8
-7
lines changed

@bellatrix/appium/src/android/AndroidDriver.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ export class AndroidDriver extends AppiumDriver {
135135
});
136136
}
137137

138-
async getScreenshot(): Promise<Image> {
138+
async takeScreenshot(): Promise<Image> {
139139
const base64image = await this.commandExecutor.execute<Promise<string>>(MobileCommands.SCREENSHOT);
140140
return Image.fromBase64(base64image);
141141
}

@bellatrix/extras/src/plugins/ScreenshotOnFailPlugin.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class ScreenshotOnFailPlugin extends Plugin {
2020
}
2121

2222
const app = ServiceLocator.resolve(App);
23-
const screenshotImage = await app.browser.getScreenshot();
23+
const screenshotImage = await app.browser.takeScreenshot();
2424

2525
const outputPath = pluginSettings?.outputPath;
2626

@@ -77,4 +77,5 @@ interface ScreenshotOnFailPluginSettings {
7777
isPluginEnabled: boolean;
7878
outputPath: string,
7979
shouldCreateFolderPerSuite?: boolean,
80+
shouldCaptureFullPage?: boolean,
8081
}

@bellatrix/web/src/infrastructure/browsercontroller/core/BrowserController.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export abstract class BrowserController implements SearchContext {
3131
abstract getCookie(name: string): Promise<Cookie | null>;
3232
abstract getAllCookies(): Promise<Cookie[]>;
3333
abstract clearCookies(): Promise<void>;
34-
abstract getScreenshot(): Promise<Image>;
34+
abstract takeScreenshot(): Promise<Image>;
3535
abstract executeJavascript<T, VarArgs extends unknown[] = []>(script: string | ((...args: VarArgs) => T), ...args: VarArgs): Promise<T>;
3636
abstract waitUntil(condition: (browserController: Omit<BrowserController, 'waitUntil'>) => boolean | Promise<boolean>, timeout: number, pollingInterval: number): Promise<void>
3737

@bellatrix/web/src/infrastructure/browsercontroller/playwright/PlaywrightBrowserController.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export class PlaywrightBrowserController extends BrowserController {
4949
return await this._page.content();
5050
}
5151

52-
override async getScreenshot(): Promise<Image> {
52+
override async takeScreenshot(): Promise<Image> {
5353
return await Image.fromBase64((await this._page.screenshot()).toString('base64'));
5454
}
5555

@bellatrix/web/src/infrastructure/browsercontroller/selenium/SeleniumBrowserController.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export class SeleniumBrowserController extends BrowserController {
3333
return await this.wrappedDriver.getPageSource();
3434
}
3535

36-
override async getScreenshot(): Promise<Image> {
36+
override async takeScreenshot(): Promise<Image> {
3737
const base64image = (await this.wrappedDriver.takeScreenshot());
3838
return Image.fromBase64(base64image);
3939
}

@bellatrix/web/src/services/BrowserService.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ export class BrowserService extends WebService {
2222
return await this.driver.getPageSource();
2323
}
2424

25-
async getScreenshot(): Promise<Image> {
26-
const base64image = (await this.driver.getScreenshot()).base64;
25+
async takeScreenshot(): Promise<Image> {
26+
const base64image = (await this.driver.takeScreenshot()).base64;
2727
return Image.fromBase64(base64image);
2828
}
2929

0 commit comments

Comments
 (0)