Remove strong references of self in closures (#765)

Co-authored-by: Pinar Olguc <[email protected]>

Author: etoledom

Demo/Demo/Gravatar-Demo/DemoQuickEditorViewController.swift

@@ -284,18 +284,18 @@ final class DemoQuickEditorViewController: UIViewController {
 
     lazy var schemeToggle: UISegmentedControl = {
         let control = UISegmentedControl(items: [
-            UIAction.init(title: "System") { _ in self.customColorScheme = .unspecified },
-            UIAction.init(title: "Light") { _ in self.customColorScheme = .light },
-            UIAction.init(title: "Dark") { _ in self.customColorScheme = .dark },
+            UIAction.init(title: "System") { [weak self] _ in self?.customColorScheme = .unspecified },
+            UIAction.init(title: "Light") { [weak self] _ in self?.customColorScheme = .light },
+            UIAction.init(title: "Dark") { [weak self] _ in self?.customColorScheme = .dark },
         ])
         control.selectedSegmentIndex = 0
         return control
     }()
 
     lazy var imageEditorToggle: UISegmentedControl = {
         let control = UISegmentedControl(items: [
-            UIAction.init(title: "Default Image Editor") { _ in self.useCustomImageEditor = false },
-            UIAction.init(title: "Custom Image Editor") { _ in self.useCustomImageEditor = true },
+            UIAction.init(title: "Default Image Editor") { [weak self] _ in self?.useCustomImageEditor = false },
+            UIAction.init(title: "Custom Image Editor") { [weak self] _ in self?.useCustomImageEditor = true },
         ])
         control.selectedSegmentIndex = 0
         return control

Sources/GravatarUI/QuickEditor/QuickEditorConfiguration.swift

@@ -1,6 +1,6 @@
 import UIKit
 
-public class QuickEditorConfiguration {
+public struct QuickEditorConfiguration {
     let interfaceStyle: UIUserInterfaceStyle
     let customImageEditorProvider: CustomImageEditorControllerProvider?
 

Sources/GravatarUI/QuickEditor/QuickEditorViewController.swift

@@ -19,11 +19,11 @@ final class QuickEditorViewController<ImageEditor: ImageEditorView>: UIViewContr
 
     private lazy var isPresented: Binding<Bool> = Binding {
         true
-    } set: { isPresented in
+    } set: { [weak self] isPresented in
         Task { @MainActor in
             guard !isPresented else { return }
-            self.dismiss(animated: true)
-            self.onDismiss?()
+            self?.dismiss(animated: true)
+            self?.onDismiss?()
         }
     }
 
@@ -87,7 +87,6 @@ final class QuickEditorViewController<ImageEditor: ImageEditorView>: UIViewContr
 
     override func viewDidLoad() {
         super.viewDidLoad()
-
         quickEditor.willMove(toParent: self)
         addChild(quickEditor)
         view.addSubview(quickEditor.view)
@@ -111,7 +110,8 @@ final class QuickEditorViewController<ImageEditor: ImageEditorView>: UIViewContr
 
     func updateDetents() {
         if let sheet = sheetPresentationController {
-            sheet.animateChanges {
+            sheet.animateChanges { [weak self] in
+                guard let self else { return }
                 sheet.detents = QEDetent.detents(
                     for: scopeOption,
                     intrinsicHeight: sheetHeight,

Sources/GravatarUI/SwiftUI/AvatarPicker/AvatarPickerViewModel.swift

@@ -125,7 +125,9 @@ class AvatarPickerViewModel: ObservableObject {
                 // Determine if the warning should be displayed
                 selectedAvatarURL == nil && loadedAvatarCount > 0
             }
-            .assign(to: \.shouldDisplayNoSelectedAvatarWarning, on: self)
+            .sink { [weak self] shouldShowWarning in
+                self?.shouldDisplayNoSelectedAvatarWarning = shouldShowWarning
+            }
             .store(in: &cancellables)
 
         $profileResult.sink { [weak self] profileResult in