Requested changes from PR review (#782)

etoledom · web-flow · commit ce04275c6237 · 2025-06-13T17:04:29.000+02:00
diff --git a/Sources/GravatarUI/Resources/Media.xcassets/square.and.arrow.top.right.symbolset/Contents.json b/Sources/GravatarUI/Resources/Media.xcassets/square.and.arrow.top.right.symbolset/Contents.json
@@ -0,0 +1,16 @@
+{
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  },
+  "properties" : {
+    "localizable" : true
+  },
+  "symbols" : [
+    {
+      "filename" : "square.and.arrow.top.right.svg",
+      "idiom" : "universal",
+      "language-direction" : "left-to-right"
+    }
+  ]
+}
diff --git a/Sources/GravatarUI/Resources/Media.xcassets/square.and.arrow.top.right.symbolset/square.and.arrow.top.right.svg b/Sources/GravatarUI/Resources/Media.xcassets/square.and.arrow.top.right.symbolset/square.and.arrow.top.right.svg
diff --git a/Sources/GravatarUI/Resources/ar.lproj/Localizable.strings b/Sources/GravatarUI/Resources/ar.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "عرض الملف الشخصي ←";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "عرض الملف الشخصي";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "اسمك";
 
diff --git a/Sources/GravatarUI/Resources/de.lproj/Localizable.strings b/Sources/GravatarUI/Resources/de.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "Profil anzeigen →";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "Profil anzeigen";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "Dein Name";
 
diff --git a/Sources/GravatarUI/Resources/en.lproj/Localizable.strings b/Sources/GravatarUI/Resources/en.lproj/Localizable.strings
@@ -124,6 +124,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "View profile →";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "View profile";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "Your Name";
 
diff --git a/Sources/GravatarUI/Resources/es.lproj/Localizable.strings b/Sources/GravatarUI/Resources/es.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "Ver perfil →";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "Ver perfil";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "Tu nombre";
 
diff --git a/Sources/GravatarUI/Resources/fr.lproj/Localizable.strings b/Sources/GravatarUI/Resources/fr.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "Afficher le profil →";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "Afficher le profil";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "Votre Nom";
 
diff --git a/Sources/GravatarUI/Resources/he.lproj/Localizable.strings b/Sources/GravatarUI/Resources/he.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "להצגת הפרופיל ←";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "להצגת הפרופיל";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "השם שלך";
 
diff --git a/Sources/GravatarUI/Resources/id.lproj/Localizable.strings b/Sources/GravatarUI/Resources/id.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "Lihat profil →";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "Lihat profil";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "Nama Anda";
 
diff --git a/Sources/GravatarUI/Resources/it.lproj/Localizable.strings b/Sources/GravatarUI/Resources/it.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "Visualizza profilo →";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "Visualizza profilo";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "Il tuo nome";
 
diff --git a/Sources/GravatarUI/Resources/ja.lproj/Localizable.strings b/Sources/GravatarUI/Resources/ja.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "プロフィールを表示→";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "プロフィールを表示";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "あなたの名前";
 
diff --git a/Sources/GravatarUI/Resources/ko.lproj/Localizable.strings b/Sources/GravatarUI/Resources/ko.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "프로필 보기 →";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "프로필 보기";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "이름";
 
diff --git a/Sources/GravatarUI/Resources/nl.lproj/Localizable.strings b/Sources/GravatarUI/Resources/nl.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "Profiel bekijken →";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "Profiel bekijken";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "Je naam";
 
diff --git a/Sources/GravatarUI/Resources/pt-BR.lproj/Localizable.strings b/Sources/GravatarUI/Resources/pt-BR.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "Visualizar perfil →";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "Visualizar perfil";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "Seu nome";
 
diff --git a/Sources/GravatarUI/Resources/ru.lproj/Localizable.strings b/Sources/GravatarUI/Resources/ru.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "Просмотреть профиль →";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "Просмотреть профиль";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "Ваше имя";
 
diff --git a/Sources/GravatarUI/Resources/sv.lproj/Localizable.strings b/Sources/GravatarUI/Resources/sv.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "Visa profil →";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "Visa profil";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "Ditt namn";
 
diff --git a/Sources/GravatarUI/Resources/tr.lproj/Localizable.strings b/Sources/GravatarUI/Resources/tr.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "Profili görüntüle →";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "Profili görüntüle";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "İsminiz";
 
diff --git a/Sources/GravatarUI/Resources/zh-Hans.lproj/Localizable.strings b/Sources/GravatarUI/Resources/zh-Hans.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "查看个人资料 →";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "查看个人资料";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "您的姓名";
 
diff --git a/Sources/GravatarUI/Resources/zh-Hant.lproj/Localizable.strings b/Sources/GravatarUI/Resources/zh-Hant.lproj/Localizable.strings
@@ -129,6 +129,9 @@
 /* Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view */
 "AvatarPickerProfile.Button.ViewProfile.title" = "檢視個人檔案 →";
 
+/* Title of a button that will take you to your Gravatar profile */
+"Profile.Button.ViewProfile.title" = "檢視個人檔案";
+
 /* Placeholder text for the name field */
 "AvatarPickerProfile.Name.placeholder" = "你的姓名";
 
diff --git a/Sources/GravatarUI/SwiftUI/AvatarPicker/AvatarPickerProfileView.swift b/Sources/GravatarUI/SwiftUI/AvatarPicker/AvatarPickerProfileView.swift
@@ -61,8 +61,13 @@ struct AvatarPickerProfileView<AccessoryView>: View where AccessoryView: View {
                         if let details = model.profileDetails {
                             secondaryText(text: details)
                         }
-                        Button(Localized.viewProfileButtonTitle) {
+                        Button {
                             viewProfileAction?()
+                        } label: {
+                            HStack(spacing: .DS.Padding.half) {
+                                Text(Localized.viewProfileButtonTitle)
+                                Image("square.and.arrow.top.right", bundle: .module)
+                            }
                         }
                         .font(.footnote)
                         .foregroundColor(Color(UIColor.label))
@@ -155,9 +160,9 @@ private enum Constants {
 
 private enum Localized {
     static let viewProfileButtonTitle = SDKLocalizedString(
-        "AvatarPickerProfile.Button.ViewProfile.title",
-        value: "View profile →",
-        comment: "Title of a button that will take you to your Gravatar profile, with an arrow indicating that this action will cause you to leave this view"
+        "Profile.Button.ViewProfile.title",
+        value: "View profile",
+        comment: "Title of a button that will take you to your Gravatar profile"
     )
     static let namePlaceholder = SDKLocalizedString(
         "AvatarPickerProfile.Name.placeholder",
diff --git a/Sources/GravatarUI/SwiftUI/ProfileEditor/QuickEditor.swift b/Sources/GravatarUI/SwiftUI/ProfileEditor/QuickEditor.swift
@@ -29,6 +29,7 @@ struct QuickEditor<ImageEditor: ImageEditorView>: View {
     @Environment(\.oauthSession) private var oauthSession
     @Environment(\.colorScheme) var colorScheme: ColorScheme
     @Environment(\.verticalSizeClass) var vertcalSizeClass
+    @Environment(\.dynamicTypeSize) var dynamicTypeSize
 
     @AppStorage("QuickEditor.startOAuthOnAppear") private var startOAuthOnAppear: Bool = false
     @State private var fetchedToken: String?
@@ -230,15 +231,22 @@ struct QuickEditor<ImageEditor: ImageEditorView>: View {
         let screenHeight = UIScreen.main.bounds.height
         let iPhoneSE3rdGenScreenHeight: CGFloat = 667
 
-        return (vertcalSizeClass == .compact || screenHeight <= iPhoneSE3rdGenScreenHeight) && model.isKeyboardPresented
+        return model.isKeyboardPresented && (
+            vertcalSizeClass == .compact ||
+                screenHeight <= iPhoneSE3rdGenScreenHeight ||
+                dynamicTypeSize >= .accessibility3
+        )
     }
 
     @ViewBuilder
     func profileCardHeaderView() -> some View {
         if !shouldHideProfileCardHeader {
-            EmailText(email: model.email)
-                .accumulateIntrinsicHeight()
+            if fetchedToken != nil {
+                EmailText(email: model.email)
+                    .accumulateIntrinsicHeight()
+            }
             profileView()
+                .dynamicTypeSize(...DynamicTypeSize.xxxLarge)
                 .accumulateIntrinsicHeight()
         } else {
             EmptyView()
diff --git a/Sources/GravatarUI/SwiftUI/QEDetent.swift b/Sources/GravatarUI/SwiftUI/QEDetent.swift
@@ -54,11 +54,7 @@ enum QEDetent {
                 case .avatarPicker:
                     .init([.height(intrinsicHeight)])
                 case .aboutEditor:
-                    if intrinsicHeight >= QEModalPresentationConstants.bottomSheetEstimatedHeight {
-                        .init([.height(QEModalPresentationConstants.bottomSheetEstimatedHeight), .large])
-                    } else {
-                        .init([.height(intrinsicHeight)])
-                    }
+                    .init([.height(intrinsicHeight)])
                 }
             }
         case .vertical(let presentationStyle):
diff --git a/Tests/GravatarUITests/AboutEditorViewTests.swift b/Tests/GravatarUITests/AboutEditorViewTests.swift
@@ -181,7 +181,7 @@ struct AboutEditorViewTests {
             await testModel.fetchProfile()
         }
         // Awaits for the previous task to start executing, and the view to start loading.
-        try await Task.sleep(nanoseconds: 10)
+        try await Task.sleep(nanoseconds: 20)
         assertSnapshots(
             of: view,
             as: [
diff --git a/Tests/GravatarUITests/__Snapshots__/AvatarPickerProfileViewTests/testAvatarPickerProfileView.1.png b/Tests/GravatarUITests/__Snapshots__/AvatarPickerProfileViewTests/testAvatarPickerProfileView.1.png
diff --git a/Tests/GravatarUITests/__Snapshots__/AvatarPickerProfileViewTests/testAvatarPickerProfileView.2.png b/Tests/GravatarUITests/__Snapshots__/AvatarPickerProfileViewTests/testAvatarPickerProfileView.2.png
diff --git a/Tests/GravatarUITests/__Snapshots__/AvatarPickerProfileViewTests/testAvatarPickerProfileViewWithoutLocation.1.png b/Tests/GravatarUITests/__Snapshots__/AvatarPickerProfileViewTests/testAvatarPickerProfileViewWithoutLocation.1.png
diff --git a/Tests/GravatarUITests/__Snapshots__/AvatarPickerProfileViewTests/testAvatarPickerProfileViewWithoutLocation.2.png b/Tests/GravatarUITests/__Snapshots__/AvatarPickerProfileViewTests/testAvatarPickerProfileViewWithoutLocation.2.png
