Merge pull request #846 from Automattic/fix/845-bounded-form-topology

Keep truncated form topology fallback-only

Author: chubes4

php-transformer/src/ArtifactCompiler/ArtifactCompiler.php

@@ -595,6 +595,7 @@ private function runtimeDeclarationsFromFallbacks(array $declarations, array $fa
                     $products[$productSlug] = $row;
                 }
             } elseif ( 'html_form_fallback' === $code && is_array($fallback['controls'] ?? null) ) {
+                if ( true === ($fallback['control_topology']['truncated'] ?? false) ) continue;
                 $selector = is_string($fallback['selector'] ?? null) ? $fallback['selector'] : '';
                 $form = array('selector' => $selector, 'source_path' => $sourcePath, 'form' => is_array($fallback['form'] ?? null) ? $fallback['form'] : array(), 'controls' => array_values(array_filter($fallback['controls'], 'is_array')));
                 if ( is_array($fallback['control_topology'] ?? null) ) $form['control_topology'] = $fallback['control_topology'];

php-transformer/tests/contract/run.php

@@ -597,6 +597,13 @@ public function match(DOMElement $element, PatternContext $context): ?array
 $assert(128 === count($exactTopology['nodes'] ?? array()) && false === ($exactTopology['truncated'] ?? null), 'form control topology retains exactly the configured node limit without reporting truncation');
 $assert(128 === count($overflowTopology['nodes'] ?? array()) && true === ($overflowTopology['truncated'] ?? null), 'form control topology truncates deterministically when one source-ordered control exceeds the node limit');
 $assert(64 === ($overflowTopology['nodes'][127]['control'] ?? null), 'node-limit truncation preserves the last in-bounds flat control reference');
+$exactTopologyResult = (new ArtifactCompiler())->compile(array('entrypoint' => 'index.html', 'files' => array('index.html' => $boundedTopologyHtml(0))))->toArray();
+$overflowTopologyResult = (new ArtifactCompiler())->compile(array('entrypoint' => 'index.html', 'files' => array('index.html' => $boundedTopologyHtml(1))))->toArray();
+$runtimeDeclarationKeys = static fn(array $result): array => array_map(static fn(array $declaration): string => ($declaration['kind'] ?? '') . ':' . ($declaration['type'] ?? $declaration['capability'] ?? ''), $result['source_reports']['wordpress_site_plan']['runtime_declarations'] ?? array());
+$assert(in_array('entity_collection:forms', $runtimeDeclarationKeys($exactTopologyResult), true), 'complete bounded form topology remains provider-materializable');
+$assert(!in_array('entity_collection:forms', $runtimeDeclarationKeys($overflowTopologyResult), true) && !in_array('dependency:form', $runtimeDeclarationKeys($overflowTopologyResult), true), 'truncated form topology remains fallback-only without claiming provider materialization');
+$assert('html_form_fallback' === ($overflowTopologyResult['fallbacks'][0]['diagnostic_code'] ?? '') && true === ($overflowTopologyResult['fallbacks'][0]['control_topology']['truncated'] ?? null), 'fallback-only overflow forms retain explicit source-loss evidence');
+$assert(isset($overflowTopologyResult['source_reports']['wordpress_site_plan']), 'fallback-only overflow forms still produce a WordPress site plan');
 $presentationTopology = ( new HtmlTransformer() )->transform('<main><form><custom-element id="bad id" class="safe bad/token one two three four five six seven eight nine ' . str_repeat('x', 81) . '"><input name="safe"></custom-element><button type="submit">Send</button></form></main>')->toArray()['fallbacks'][0]['control_topology']['nodes'][0] ?? array();
 $assert(! isset($presentationTopology['tag']) && ! isset($presentationTopology['source_id']), 'form topology omits unsupported wrapper tags and malformed source IDs');
 $assert('safe one two three four five six seven' === ($presentationTopology['class'] ?? ''), 'form topology retains only the first eight bounded safe class tokens');