Skip to content

Commit 4e95bc6

Browse files
committed
fix(core): remove cause of #581
1 parent 1797148 commit 4e95bc6

File tree

3 files changed

+4
-18
lines changed

3 files changed

+4
-18
lines changed

harper-core/src/linting/lint_group.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ use super::merge_words::MergeWords;
1717
use super::multiple_sequential_pronouns::MultipleSequentialPronouns;
1818
use super::number_suffix_capitalization::NumberSuffixCapitalization;
1919
use super::phrase_corrections::{
20-
Decision, HumanLife, NeedHelp, NoLonger, OfCourse, ThatChallenged, TurnItOff,
20+
HumanLife, NeedHelp, NoLonger, OfCourse, ThatChallenged, TurnItOff,
2121
};
2222
use super::plural_conjugate::PluralConjugate;
2323
use super::pronoun_contraction::PronounContraction;
@@ -198,7 +198,6 @@ create_lint_group_config!(
198198
SomewhatSomething => true,
199199
LetsConfusion => true,
200200
DespiteOf => true,
201-
Decision => true,
202201
HumanLife => true,
203202
NeedHelp => true,
204203
NoLonger => true,

harper-core/src/linting/mod.rs

+1-3
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,7 @@ pub use multiple_sequential_pronouns::MultipleSequentialPronouns;
6363
pub use number_suffix_capitalization::NumberSuffixCapitalization;
6464
pub use oxford_comma::OxfordComma;
6565
pub use pattern_linter::PatternLinter;
66-
pub use phrase_corrections::{
67-
Decision, HumanLife, NeedHelp, NoLonger, OfCourse, ThatChallenged, TurnItOff,
68-
};
66+
pub use phrase_corrections::{HumanLife, NeedHelp, NoLonger, OfCourse, ThatChallenged, TurnItOff};
6967
pub use plural_conjugate::PluralConjugate;
7068
pub use pronoun_contraction::PronounContraction;
7169
pub use proper_noun_capitalization_linters::{

harper-core/src/linting/phrase_corrections.rs

+2-13
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,7 @@ create_linter_for_phrase!(HumanLife, "human life", 1);
7272
create_linter_for_phrase!(ThatChallenged, "that challenged", 2);
7373
create_linter_for_phrase!(NoLonger, "no longer", 1);
7474
create_linter_for_phrase!(NeedHelp, "need help", 1);
75-
create_linter_for_phrase!(Decision, "make a decision", 1);
7675
create_linter_for_phrase!(OfCourse, "of course", 1);
77-
7876
create_linter_for_phrase!(AndAlike, "and alike", 1);
7977
create_linter_for_phrase!(BadRap, "bad rap", 1);
8078
create_linter_for_phrase!(BatedBreath, "bated breath", 1);
@@ -93,8 +91,8 @@ mod tests {
9391
use crate::linting::tests::{assert_lint_count, assert_suggestion_result};
9492

9593
use super::{
96-
BadRap, BatedBreath, ChangeTack, Decision, EnMasse, HungerPang, LetAlone, LoAndBehold,
97-
MootPoint, OfCourse, SneakingSuspicion, SupposeTo, TurnItOff,
94+
BadRap, BatedBreath, ChangeTack, EnMasse, HungerPang, LetAlone, LoAndBehold, MootPoint,
95+
OfCourse, SneakingSuspicion, SupposeTo, TurnItOff,
9896
};
9997

10098
#[test]
@@ -122,15 +120,6 @@ mod tests {
122120
assert_suggestion_result("Turn i of", TurnItOff::default(), "Turn it off");
123121
}
124122

125-
#[test]
126-
fn take_a_decision() {
127-
assert_suggestion_result(
128-
"we should take a decision on this",
129-
Decision::default(),
130-
"we should make a decision on this",
131-
);
132-
}
133-
134123
#[test]
135124
fn off_course() {
136125
assert_suggestion_result(

0 commit comments

Comments
 (0)