fix(core): remove problematic MootPoint rule

Author: elijah-potter

harper-core/src/linting/lint_group.rs

@@ -18,7 +18,7 @@ use super::multiple_sequential_pronouns::MultipleSequentialPronouns;
 use super::number_suffix_capitalization::NumberSuffixCapitalization;
 use super::phrase_corrections::{
     AndAlike, BadRap, BatedBreath, BeckAndCall, ChangeTack, EnMasse, HumanLife, HungerPang,
-    LetAlone, LoAndBehold, MootPoint, NeedHelp, NoLonger, OfCourse, SneakingSuspicion, SupposeTo,
+    LetAlone, LoAndBehold, NeedHelp, NoLonger, OfCourse, SneakingSuspicion, SupposeTo,
     ThatChallenged, TurnItOff,
 };
 use super::plural_conjugate::PluralConjugate;
@@ -215,7 +215,6 @@ create_lint_group_config!(
     EnMasse => true,
     LetAlone => true,
     LoAndBehold => true,
-    MootPoint => true,
     SneakingSuspicion => true,
     SupposeTo => true
 );

harper-core/src/linting/mod.rs

@@ -65,7 +65,7 @@ pub use oxford_comma::OxfordComma;
 pub use pattern_linter::PatternLinter;
 pub use phrase_corrections::{
     AndAlike, BadRap, BatedBreath, BeckAndCall, ChangeTack, EnMasse, HumanLife, HungerPang,
-    LetAlone, LoAndBehold, MootPoint, NeedHelp, NoLonger, OfCourse, SneakingSuspicion, SupposeTo,
+    LetAlone, LoAndBehold, NeedHelp, NoLonger, OfCourse, SneakingSuspicion, SupposeTo,
     ThatChallenged, TurnItOff,
 };
 pub use plural_conjugate::PluralConjugate;

harper-core/src/linting/phrase_corrections.rs

@@ -82,7 +82,6 @@ create_linter_for_phrase!(HungerPang, "hunger pang", 3);
 create_linter_for_phrase!(EnMasse, "en masse", 1);
 create_linter_for_phrase!(LetAlone, "let alone", 1);
 create_linter_for_phrase!(LoAndBehold, "lo and behold", 2);
-create_linter_for_phrase!(MootPoint, "moot point", 3);
 create_linter_for_phrase!(SneakingSuspicion, "sneaking suspicion", 3);
 create_linter_for_phrase!(SupposeTo, "suppose to", 1);
 
@@ -91,8 +90,8 @@ mod tests {
     use crate::linting::tests::{assert_lint_count, assert_suggestion_result};
 
     use super::{
-        BadRap, BatedBreath, ChangeTack, EnMasse, HungerPang, LetAlone, LoAndBehold, MootPoint,
-        OfCourse, SneakingSuspicion, SupposeTo, TurnItOff,
+        BadRap, BatedBreath, ChangeTack, EnMasse, HungerPang, LetAlone, LoAndBehold, OfCourse,
+        SneakingSuspicion, SupposeTo, TurnItOff,
     };
 
     #[test]
@@ -173,11 +172,6 @@ mod tests {
         assert_suggestion_result("long and behold", LoAndBehold::default(), "lo and behold");
     }
 
-    #[test]
-    fn mute_point() {
-        assert_suggestion_result("mute point", MootPoint::default(), "moot point");
-    }
-
     #[test]
     fn sneaky_suspicion() {
         assert_suggestion_result(