fix(harper.js): create disposal function and use it (#2445)

* test(harper.js): in firefox

* test(harper.js): to ensure that memory does not leak with minimal loops

* test(harper-wasm): that the issue is not in the WebAssembly code

* test(harper.js): make the test fail when memory is used

* potential fix

* chore: `just format`

* fix: dispose `Linter` properly in Obsidian and the Web Extension

* fix(chrome-ext): return Serializer test to its rightful place

* fix: revert changes to the example

* fix(harper.js): clean up trash

* chore: `just format`

* fix(harper.js): bad interface method

* fix(harper.js): dispose `OrganizedGroup` objects and the linters in the tests

* fix(harper.js): make test only run for the `LocalLinter`

Author: elijah-potter

Cargo.lock

@@ -659,4 +659,19 @@ mod tests {
         let lints = linter.lint(text, Language::Plain, false);
         assert!(lints.is_empty());
     }
+
+    #[test]
+    fn does_not_oom_with_repeated_lints() {
+        for _ in 0..3000 {
+            let mut linter = Linter::new(Dialect::American);
+
+            let results = linter.lint(
+                "This is a grammatically correct sentence.".to_string(),
+                Language::Plain,
+                false,
+            );
+
+            assert!(results.is_empty())
+        }
+    }
 }

harper-wasm/src/lib.rs

@@ -394,6 +394,10 @@ async function setActivationKey(key: ActivationKey) {
 }
 
 function initializeLinter(dialect: Dialect) {
+	if (linter != null) {
+		linter.dispose();
+	}
+
 	linter = new LocalLinter({
 		binary: BinaryModule.create(chrome.runtime.getURL('./wasm/harper_wasm_bg.wasm')),
 		dialect,