Merge pull request #72 from Automattic/git-mirror-minimal-size

Only publish git mirror if the archive file is 50 MB or larger

Author: crazytonyli

README.md

@@ -4,7 +4,6 @@ A description of this package.
 
 ## Release
 
-1. Create a PR to update the [`appVersion`](Sources/hostmgr/main.swift).
-1. After the PR is merged, create a tag named same as the `appVersion`,
-1. Once the tag is pushed up to this repo, a CI job will be automatically kicked off to create a GitHub release for the tag. Wait for the CI job to finish.
-1. Update [the hostmgr homebrew formula](https://github.com/Automattic/homebrew-build-tools/blob/trunk/hostmgr.rb)'s `url` and `sha256` fields, whose value can be found in the GitHub release created above.
+1. Create a PR to update [the version property](Sources/libhostmgr/libhostmgr.swift).
+1. After the PR is merged, create a tag named same as the updated version,
+1. Once the tag is pushed up to this repo, a CI job will be automatically kicked off to create a GitHub release for the tag.

Sources/hostmgr/commands/cache/GitMirrorPublishCommand.swift

@@ -37,6 +37,18 @@ struct GitMirrorPublishCommand: AsyncParsableCommand {
         Console.info("Compressing \(gitMirror.localPath.path()) to \(gitMirror.archivePath)")
         try gitMirror.compress()
 
+        // At the moment `service.uploadFile` does a multi-part upload, which fails if one of those batches is less
+        // than 5 MB. Instead of implementing a direct upload in tinys3, we'll put a random minimal size limit (50 MB)
+        // to git mirror files. If the file size is too small, git checkout should be pretty fast and it's okay to not
+        // save the git repo in S3.
+        let archiveSize = try FileManager.default.size(ofObjectAt: gitMirror.archivePath)
+        let archiveSizeInMB = Measurement(value: Double(archiveSize), unit: UnitInformationStorage.bytes)
+            .converted(to: .megabytes)
+        if archiveSizeInMB.value < 50 {
+            Console.info("Skipping uploading the git mirror because it is too small")
+            return
+        }
+
         let progress = Console.startProgress("Uploading mirror to \(gitMirror.remoteFilename)", type: .upload)
         try await server.uploadFile(at: gitMirror.archivePath, to: gitMirror.remoteFilename, progress: progress.update)
 

Sources/libhostmgr/libhostmgr.swift

@@ -1,7 +1,7 @@
 import Foundation
 import OSLog
 
-public let hostmgrVersion = "0.50.0-beta.10"
+public let hostmgrVersion = "0.50.0-beta.11"
 
 public extension Logger {
     private static let subsystem = "com.automattic.hostmgr"