Skip to content

Commit 6c8d728

Browse files
p-jacksonmatticbot
authored andcommitted
Remove the launchpad's updated_write_tasklist param (#42560)
* Remove the launchpad's updated_write_tasklist param The publish a blog project changes have deployed in Calypso, and the updated_write_tasklist param is now always set to true. This means we can clean up this temporary flag from Jetpack. * changelog Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/13960445895 Upstream-Ref: Automattic/jetpack@1794810
1 parent 76346c0 commit 6c8d728

File tree

9 files changed

+105
-181
lines changed

9 files changed

+105
-181
lines changed

composer.lock

+32-32
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

jetpack_vendor/automattic/jetpack-mu-wpcom/CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ This is an alpha version! The changes listed here are not final.
8181
- Launchpad: Replace newsletter preview task with launch task
8282
- Launchpad: show site title task in updated write launchpad
8383
- Launchpad: update copy for adding subscribers to a site
84+
- Launchpad: updated_write_tasklist param no longer needed
8485
- Launchpad: Update select a design step allowing user to interact with it
8586
- Launchpad: Update tasks so sites created through onboarding have different design task links
8687
- Launchpad: verify email task uses heuristic for visibility, regardless of experiment cohort

jetpack_vendor/automattic/jetpack-mu-wpcom/src/features/launchpad/class-launchpad-task-lists.php

+4-7
Original file line numberDiff line numberDiff line change
@@ -375,11 +375,10 @@ public function get_all_tasks() {
375375
*
376376
* @param string $id Task list id.
377377
* @param string|null $launchpad_context Optional. Screen in which launchpad is loading.
378-
* @param bool $updated_write_tasklist Optional. Whether we're using the updated `write` task list.
379378
*
380379
* @return Task[] Collection of tasks associated with a task list.
381380
*/
382-
public function build( $id, $launchpad_context = null, $updated_write_tasklist = false ) {
381+
public function build( $id, $launchpad_context = null ) {
383382
$task_list = $this->get_task_list( $id );
384383
$tasks_for_task_list = array();
385384

@@ -396,7 +395,7 @@ public function build( $id, $launchpad_context = null, $updated_write_tasklist =
396395
$task_definition = $this->get_task( $task_id );
397396

398397
// if task can't be found don't add anything
399-
if ( $this->is_visible( $task_definition, $launchpad_context, $updated_write_tasklist ) ) {
398+
if ( $this->is_visible( $task_definition, $launchpad_context ) ) {
400399
$tasks_for_task_list[] = $this->build_task( $task_definition, $launchpad_context );
401400
}
402401
}
@@ -410,17 +409,15 @@ public function build( $id, $launchpad_context = null, $updated_write_tasklist =
410409
*
411410
* @param Task $task_definition A task definition.
412411
* @param string|null $launchpad_context Optional. Screen in which launchpad is loading.
413-
* @param bool $updated_write_tasklist Optional. Whether we're using the updated `write` task list.
414412
* @return boolean True if task is visible, false if not.
415413
*/
416-
protected function is_visible( $task_definition, $launchpad_context = null, $updated_write_tasklist = false ) {
414+
protected function is_visible( $task_definition, $launchpad_context = null ) {
417415
if ( empty( $task_definition ) ) {
418416
return false;
419417
}
420418

421419
$data = array(
422-
'launchpad_context' => $launchpad_context,
423-
'updated_write_tasklist' => $updated_write_tasklist,
420+
'launchpad_context' => $launchpad_context,
424421
);
425422

426423
return $this->load_value_from_callback( $task_definition, 'is_visible_callback', true, $data );

0 commit comments

Comments
 (0)