Forms: Fix checkbox field value not output in classic editor (#46354)

* Update class-editor-view.php

* Create replace-escape-function-in-checkbox-input-value

* Add unit test for checkbox template value output

Verifies that the checkbox template outputs a non-empty value attribute,
catching the bug where esc_attr__() was used instead of esc_attr_e().

* chore: add Jetpack plugin changelog for checkbox fix

---------

Co-authored-by: Brandon Kraft <[email protected]>

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/20973734962

Upstream-Ref: Automattic/jetpack@35f8571

Author: kraftbj

CHANGELOG.md

@@ -11,6 +11,7 @@ This is an alpha version! The changes listed here are not final.
 - Instant Search: Show WooCommerce product filters in filter widget
 
 ### Bug fixes
+- Contact Form: Fixed checkbox field value not being properly output in the classic editor form builder.
 - Shortcode: Fix broken YouTube URL on the classic editor
 - Slideshow: Ensure slideshows do not stretch to parent container width on mobile if no list height is set.
 

jetpack_vendor/automattic/jetpack-forms/CHANGELOG.md

@@ -16,6 +16,7 @@ This is an alpha version! The changes listed here are not final.
 ### Changed
 - Forms: update dataviews actions to match between old and new dashboard.
 - Forms: update form submission confirmation page with new design.
+- Replace escape function in checkbox input value.
 - Update package dependencies.
 - Update read/unread status column style to match old dashboard.
 - Use Gravatar component in new dashboard inbox.

jetpack_vendor/automattic/jetpack-forms/src/contact-form/class-editor-view.php

@@ -179,7 +179,7 @@ public static function editor_view_js_templates() {
 <script type="text/html" id="tmpl-grunion-field-checkbox">
 	<div>
 		<label class='grunion-field-label checkbox'>
-			<input type='checkbox' name='{{ data.id }}' value='<?php esc_attr__( 'Yes', 'jetpack-forms' ); ?>' class="{{ data.class }}" <# if ( data.value ) print( 'checked="checked"' ) #> />
+			<input type='checkbox' name='{{ data.id }}' value='<?php esc_attr_e( 'Yes', 'jetpack-forms' ); ?>' class="{{ data.class }}" <# if ( data.value ) print( 'checked="checked"' ) #> />
 				<span>{{ data.label }}</span><# if ( data.required ) print( " <span>" + data.required + "</span>" ) #>
 		</label>
 		<div class='clear-form'></div>

jetpack_vendor/i18n-map.php

@@ -66,7 +66,7 @@
     ),
     'jetpack-forms' => array(
       'path' => 'jetpack_vendor/automattic/jetpack-forms',
-      'ver' => '7.4.0-alpha1768326783',
+      'ver' => '7.4.0-alpha1768340822',
     ),
     'jetpack-image-cdn' => array(
       'path' => 'jetpack_vendor/automattic/jetpack-image-cdn',