Jetpack Forms: cleanup dashboard migration code (#43825)

* remove TODOs and code from legaacy view requests

* changelog

* remove all now unused view switch methods

* assume first 3 filters for the migration are now active, remove wrapped conditional code

* update docblock, add note on how to handle polldaddy interaction

* remove force param on get_forms_admin_url and append_tab_to_url as we don't offer classic view anymore

* update phan baseline for forms

* update phan baseline

* fixes after rebase

* update tests

* update phan baselines

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/20957059136

Upstream-Ref: Automattic/jetpack@3ba0640

Author: CGastrell

jetpack_vendor/automattic/jetpack-forms/CHANGELOG.md

@@ -16,6 +16,9 @@ This is an alpha version! The changes listed here are not final.
 ### Changed
 - Update package dependencies.
 
+### Removed
+- Forms: clean up all dashboard migration code (filters, methods and wrapped up code)
+
 ### Fixed
 - Consent block: automatically set required to false when consent type is implicit
 - Forms: fix dashboard routing on wpcom.

jetpack_vendor/automattic/jetpack-forms/src/contact-form/class-contact-form-plugin.php

@@ -1426,7 +1426,9 @@ public static function gutenblock_render_field_image_select( $atts, $content, $b
 	public function admin_menu() {
 		$slug = 'feedback';
 
-		if ( is_plugin_active( 'polldaddy/polldaddy.php' ) ) {
+		// Do we still need to create the Feedback menu item for polldaddy?
+		// WPCOM already handles this. Self hosted will depend on us until we produce a new release for polldaddy.
+		if ( is_plugin_active( 'polldaddy/polldaddy.php' ) || ! Jetpack_Forms::is_legacy_menu_item_retired() ) {
 			add_menu_page(
 				__( 'Feedback', 'jetpack-forms' ),
 				__( 'Feedback', 'jetpack-forms' ),
@@ -1517,22 +1519,6 @@ public function unread_count() {
 			}
 			return;
 		}
-
-		if ( isset( $submenu['feedback'] ) && is_array( $submenu['feedback'] ) && ! empty( $submenu['feedback'] ) ) {
-			foreach ( $submenu['feedback'] as $index => $menu_item ) {
-				if ( 'edit.php?post_type=feedback' === $menu_item[2] ) {
-					$unread = self::get_unread_count();
-
-					if ( $unread > 0 ) {
-						$unread_count = current_user_can( 'publish_pages' ) ? " <span class='feedback-unread jp-feedback-unread-counter count-{$unread} awaiting-mod'><span class='feedback-unread-count'>" . number_format_i18n( $unread ) . '</span></span>' : '';
-
-						// phpcs:ignore WordPress.WP.GlobalVariablesOverride.Prohibited
-						$submenu['feedback'][ $index ][0] .= $unread_count;
-					}
-					break;
-				}
-			}
-		}
 	}
 
 	/**
@@ -3020,15 +3006,6 @@ public function get_feedback_entries_from_post() {
 			$args['s'] = sanitize_text_field( wp_unslash( $_POST['search'] ) );
 		}
 
-		// TODO: We can remove this when the wp-admin UI is removed.
-		if ( ! empty( $_POST['year'] ) && intval( $_POST['year'] ) > 0 ) {
-			$args['date_query']['year'] = intval( $_POST['year'] );
-		}
-		// TODO: We can remove this when the wp-admin UI is removed.
-		if ( ! empty( $_POST['month'] ) && intval( $_POST['month'] ) > 0 ) {
-			$args['date_query']['month'] = intval( $_POST['month'] );
-		}
-
 		if ( ! empty( $_POST['after'] ) && ! empty( $_POST['before'] ) ) {
 			$before = strtotime( sanitize_text_field( wp_unslash( $_POST['before'] ) ) );
 			$after  = strtotime( sanitize_text_field( wp_unslash( $_POST['after'] ) ) );